Code Monkey home page Code Monkey logo

heroku-ipfs-ghost's Issues

Change app.json to use Fission's Heroku addon

The app.json file currently references env variables for setup. This can be simplified/streamlined by adding Fission's Heroku addon like so:

{
  "addons": [
    "jawsdb",
    "mailgun",
    {
      "plan": "interplanetary-fission:test"
    }
  ],
}

Update for Ghost 3.x

Newest version of default theme should be included and checked-in.

Have no idea if this will just work by updating package.json and/or what the DB migration is.

Heroku build failing

Hi - the Heroku deploy button wasn't working for me so I hacked it and got a bit further along by using this link:

https://dashboard.heroku.com/new?button-url=https%3A%2F%2Fgithub.com%2Ffission-suite%2Fheroku-ipfs-ghost&template=https%3A%2F%2Fgithub.com%2Ffission-suite%2Fheroku-ipfs-ghost

I got the the attached screen which was looking more promising, however the build failed at the Pruning devDependencies step.

Any help resolving this greatly appreciated thanks!

image

       
-----> Creating runtime environment
       
       NPM_CONFIG_LOGLEVEL=error
       NODE_ENV=production
       NODE_MODULES_CACHE=true
       NODE_VERBOSE=false
       
-----> Installing binaries
       engines.node (package.json):  12.x
       engines.npm (package.json):   unspecified (use default)
       
       Resolving node version 12.x...
       Downloading and installing node 12.18.4...
       Using default npm version: 6.14.6
       
-----> Installing dependencies
       Installing node modules
       
       > [email protected] install /tmp/build_e652f5ec_/node_modules/dtrace-provider
       > node-gyp rebuild || node suppress-error.js
       
       make: Entering directory '/tmp/build_e652f5ec_/node_modules/dtrace-provider/build'
         TOUCH Release/obj.target/DTraceProviderStub.stamp
       make: Leaving directory '/tmp/build_e652f5ec_/node_modules/dtrace-provider/build'
       
       > [email protected] install /tmp/build_e652f5ec_/node_modules/sqlite3
       > node-pre-gyp install --fallback-to-build
       
       [sqlite3] Success: "/tmp/build_e652f5ec_/node_modules/sqlite3/lib/binding/node-v72-linux-x64/node_sqlite3.node" is installed via remote
       
       > [email protected] install /tmp/build_e652f5ec_/node_modules/sharp
       > (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)
       
       info sharp Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.8.1/libvips-8.8.1-linux-x64.tar.gz
       
       > [email protected] postinstall /tmp/build_e652f5ec_/node_modules/core-js
       > node postinstall || echo "ignore"
       
       
       > [email protected] postinstall /tmp/build_e652f5ec_/node_modules/jsonpath
       > node lib/aesprim.js > generated/aesprim-browser.js
       
       added 1082 packages in 22.923s
       
-----> Build
       
-----> Caching build
       - node_modules
       
-----> Pruning devDependencies
       npm ERR! code 1
       npm ERR! Command failed: git checkout beta
       npm ERR! error: pathspec 'beta' did not match any file(s) known to git.
       npm ERR! 
       
       npm ERR! A complete log of this run can be found in:
       npm ERR!     /tmp/npmcache.fVzOl/_logs/2020-09-21T06_11_13_369Z-debug.log
-----> Build failed
       
       We're sorry this build is failing! You can troubleshoot common issues here:
       https://devcenter.heroku.com/articles/troubleshooting-node-deploys
       
       If you're stuck, please submit a ticket so we can help:
       https://help.heroku.com/
       
       Love,
       Heroku
       
 !     Push rejected, failed to compile Node.js app.
 !     Push failed```

Coding style guide

A recent PR highlighted the lack of coding style guidelines for this project.

In addition to adding a linter, a popular solution for JS projects is to use Prettier which helps do all the grunt work: https://prettier.io/docs/en/why-prettier.html

This issue could also apply to other repos, but this might be a good place to have the conversation.

Re-enable minor update (or update documentation)

According to documentation:

Upgrading Ghost

On each deployment, the Heroku Node/npm build process will auto-upgrade Ghost to the newest 3.x version. To prevent this behavior, use npm 5+ (or yarn) to create a lockfile.

During upgrades, package lock was added and package files were changed from ^(minor) to ~(patch) based on a related conversation. These will need to be reverted to allow for the described functionality.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.