Add configuration for optional IPFS gateway url about heroku-ipfs-ghost HOT 7 CLOSED

@MCTaylor17 so, the default gateway URL should be https://ipfs.runfission.com. It's also part of the reason for the images downloading automatically when visiting the URL.

The https://runfission.com is actually our Web API, not our gateway. It CAN serve up individual hashes for files, but doesn't do anything for directories.

from heroku-ipfs-ghost.

@MCTaylor17 I merged your PR, but please do the following:

• Make ipfs.runfission.com the default
• Ask for the env variable without /ipfs -- should be just top level path -- e.g. gateway.ipfs.io or ipfs.runfission.com

from heroku-ipfs-ghost.

@bmann I checked a list of gateways (the "normal" list is currently 404) and only 1 out 29 didn't use /ipfs. That makes it almost standard spec (if it isn't already).

With that said, I can check/append /ipfs either here or in the adapter itself. I'm already doing some minor URL normalization over there so I'm inclined to do it there.

Do you have any thoughts on that?

from heroku-ipfs-ghost.

Yes, they all use /ipfs -- but that's the server path, not the host, and yes, /ipfs should be appended in the storage adapter.

from heroku-ipfs-ghost.

Just to make sure I'm making the right changes, the storage adapter currently uses ipfs.io as the default based on a requirement pulled out of the original discourse description. I can:

1. Change the default in the storage adapter
2. Change the default in the config file

    if(!!process.env.IPFS_GATEWAY_URL) {
      storageOptions.gatewayURL = process.env.IPFS_GATEWAY_URL;
    } else {
      storageOptions.gatewayURL = "https://ipfs.runfission.com"
    }

3. Change the default in app.json

    "IPFS_GATEWAY_URL": {
      "description": "The HTTPS URL of your prefered IPFS gateway.  Defaults to https://ipfs.io/ipfs",
      "value": "https://ipfs.runfission.com",
      "required": false
    }

4. Some combination of the above

I'm guessing 3, but the discourse specs were drafted back in June.

from heroku-ipfs-ghost.

Yes, fine to edit in just app.json for now.

The storage adapter won’t work with anything other than our API so someone will have to add support for other APIs or run their own copy of our Web API.

from heroku-ipfs-ghost.

Oops! This was resolved in commit caa991b

from heroku-ipfs-ghost.