Error in class transforms.Translate about pytorch3d HOT 5 CLOSED

@hfutcgncas this just depends on whether you are using row-major or column-major ordering. As explained in the __init__ function of the Translate class, we assume row-major ordering.

See this guide for a more detailed explanation.

from pytorch3d.

Thank you very much for the explanation.

from pytorch3d.

@nikhilaravi I still have a problem here. In the case of using row-major, I suppose the matrix of RotateAxisAngle(a, axis="X") should be like

m = [ [1,       0,       0,     0],
      [0,  cos(a),  sin(a),     0],
      [0, -sin(a),  cos(a),     0],
      [0,       0,       0,     1]]

but in the code of RotateAxisAngle it is write like

m = [ [1,       0,       0,     0],
      [0,  cos(a), -sin(a),     0],
      [0,  sin(a),  cos(a),     0],
      [0,       0,       0,     1]]

Is there something wrong or I got some mistake about the Coordinate Systems?

from pytorch3d.

@hfutcgncas you're right, thanks for pointing this out. If we assume row-major ordering, a right hand coordinate system and that positive angles result in counter clockwise rotation then we need to transpose the rotation matrix as you mentioned. I will make the fix ASAP.

from pytorch3d.

@hfutcgncas This fix has now been landed.

from pytorch3d.