elgbar / instant-inventory Goto Github PK

Is your feature request related to a problem? Please describe.
When I'm using inventory and I'm dropping many things, id like it to hide inventory tags when the item is hidden. One use-case is when you're barbarian fishing, you may tag trout/salmon one color and tag sturgeon another color. With low opacity these tags are still very much showing.

Describe the solution you'd like
I would like to hide the inventory tag for a given item if one exists when it is hidden because the item was dropped.

Describe alternatives you've considered
This could potentially be a configuration option, but I feel its what you would intuitively want so I think it would remove inventory tags by default and not a config option.

Additional context
N/A

Describe the bug
A clear and concise description of what the bug is.
When you have an item set to shift click wear with menu entry swapper and the instant equip feature on, the item will not equip.

To Reproduce
Steps to reproduce the behaviour:

1. Click on '....'
2. See error
   menu entry swap a piece of armor to shift click equip.
   enable equip items instantly in the instant inventory plugin settings
   shift click the piece of armor to equip in your inventory
   the item does not equip

Expected behaviour
A clear and concise description of what you expected to happen.
the item should equip
Screenshots
If applicable, add screenshots/video to help explain your problem.

Additional context
Add any other context about the problem here.

When depositing items via the Deposit-X menu option you must enter the amount to deposit in the Enter amount: input box.
When pressing enter to deposit the amount the item in the inventory is not updated instantly, but rather the next tick.

Suggested solution

Add a listener for the Enter amount: input box and update the size of the item stack last clicked

Dropping any light source in a dark area gives the message "Dropping that would leave you without a light source" from the runescape client and prevents the item from being removed from your inventory.

If I decide to enter a dark area, such Tears of Guthix or the Tunnel in Lumby castle basement, and drop my light source then the inventory spot appears empty, but i may not swap with this inventory spot or pick up any additional items. In order to fix it I have to go to a bank, deposit the item (it appears in a bank window), CLOSE THE BANK, then access the bank again and retrieve my item.

Almost thought I had to buy another firemaking cape, scared the shit out of me man! lol

I appreciate your plugin so I just wanted to take this time to additionally thank you for your work on it. This bug is pretty preventable by not being a dingus so don't worry too much about it!

The plugin (beneficially) supports clicking on the same equipment item more than once in the same tick, but I noticed that the icon doesn't update to match. This has been coming up a lot while fighting Tormented Demons lately, which reward quick and accurate switches. I might click a weapon and quickly click it again to undo that input (say if I anticipated incorrectly), but the icon doesn't update to reflect this. Rather, the icon only reflects the first input on that item for the duration of the value shown in the "Min Changed Millis" box. Hopefully this is a simple fix, where the icon automatically changes based on the last input rather than the first one in the allotted period. The equipment icon not changing to match my inputs has made me do double takes multiple times, and occasionally click again thinking a click didn't register. For reference I've been using all the default settings on a 20ms ping server.

As a related suggestion, I think other people might also enjoy the ability to toggle off the ability to input more than one interaction for an item in the same game tick. Personally I wouldn't use it, but it's more akin to what the vanilla client does so it has the advantage of familiarity.

Thanks a ton! Great plugin.

Describe the bug

The bank interface does not display the deposited item if there is no existing item in the bank

To Reproduce
Steps to reproduce the behaviour:

1. Have an item in your inventory which your bank does not contain (nor exist a placeholder)
2. Deposit the item
3. The item will appear as if the plugin is not enabled after a tick.

Expected behaviour

The deposited item should be shown with change opacity where it will be placed the next tick

Screenshots

Additional context

We must be able to identify which tab is active in the bank. This should be possible with the CURRENT_BANK_TAB (4150) varbit

https://cdn.discordapp.com/attachments/442492468307427330/1096596190071640144/RuneLite_-_Boynk_2023-04-14_19-00-52.mp4

Is it feasible to extend the plugin to instantly update the inventory when withdrawing/depositing from a bank?

Describe the bug

While stunned, you cannot change equipment. But the plugin still tries to update the inventory.

To Reproduce
Steps to reproduce the behaviour:

1. Get fully stunned (though NOT by failing to pickpocket, you can still switch gear)
2. Try to equip items while stunned
3. See the item flicker back into the inventory.

Expected behaviour

The items should not be be handled as equipped

Screenshots

TODO

Additional context
Originally reported on reddit: https://www.reddit.com/r/2007scape/comments/1ayadd5/comment/kruvbpz/

Describe the bug
Equipping 2H weapon in bank-equipment interface with a full inventory will cause items to be stuck as the preview items. And the items will not be reset to their correct item.

To Reproduce
Steps to reproduce the behaviour:

1. Have a full inventory with a 2h item and items in the weapon and shield slots
2. Open the bank and click Show worn Items (top left)
3. Try to wield the 2h item
4. The item in the inventory will be replaced with the item in the weapon slot, but never be reset.

Expected behaviour

1. The item should reset
2. The item should not be changed in the inventory.

Screenshots

Additional context

Reported originally by Cuziiik

Noticed when using this plugin that one time I dropped 2 logs while mid-animation entering Kharazi jungle.

Because of this the client side update from this plugin "removed" them from my inventory, but they were infact still there. So possibly needs to check if the drop actually happened and if not, revert the client side change.

Opening the bank alerted me to this as they now became visible, but even banking and re-withdrawing them did not update the client side. Had to disable plugin, then bank/re-withdraw.

Describe the bug

When equipping items while in the bank, the inventory interface is updated correctly (i.e., items are hidden) but the equipment page on the bank slot is not instantly updated.

To Reproduce
Steps to reproduce the behaviour:

1. Open bank
2. Click Show worn Items (top left)
3. equip and unequip items
4. See error that the equipment stat is not updated instantly

Expected behaviour

The equipment page is updated instantly

Screenshots

Additional context

N/A

I've noticed that any items that open a dialog box to warn/verify that you want to drop (e.g. based on the limit set in-game) hide the item immediately regardless of whether the drop is confirmed or not. This is especially problematic if you are mid-combat and the dialog box gets interrupted, as it effectively causes the item to disappear from your inventory.

To prevent similar issues, I think following each "hide" action with an inventory state check at the next game tick in order to verify synchronization may help to minimize these sorts of errors, especially if support for gear switches is intended to be added in the near future. It would be very unfortunate to have certain crucial items accidentally become inaccessible from your inventory during difficult PvM and PvP situations.

Hide as dropped if the equal slot is empty
Swap with current equipped item if there is something in the slot (and you can equip it)

Hello sir,

My issue isn't related to Instant Inventory. I apologize, but I couldn't figure out any other way to contact you. I am in desperate need of your Tileman-Async-Mode plugin; Tileman mode has become virtually unplayable for me, after unlocking tens of thousands of tiles. Is there any way I can use that code/plugin? I have already tried myself, with IntelliJ, but to no avail. Many thanks.

• Spigotron

Can you bring back the old version of instant inventory this no one feels so buggy and weird.

Currently its hardcoded to 2 ticks with

/**
 * Maximum number of ticks an item should be displayed as something else
 */
public static final int MAX_UNMODIFIED_TICKS = 2;

It should be a config option with the default value of MAX_UNMODIFIED_TICKS

After setting an item from "use" to "drop" left click, Instant Inventory causes there to be problems while spam clicking to drop items. As shown in the .gif above, double-clicking causes the item to be clicked again as a "use" action once Instant Inventory considers the item to be dropped. This behavior doesn't happen when Drop Items Instantly is disabled as shown on the left.

Describe the bug

Group ironman bank storage; upon depositing items to the group storage (with this plugin enabled) the items actually go to the storage. However, the item I just deposited "appears" on my inventory still, yet having the option to still "deposit" them, even though they don't actually exist in my inventory anymore.

To Reproduce
Steps to reproduce the behaviour:

1. Open Group Storage on a Group Ironman
2. Deposit item(s) into the bank
3. The item will reappear in the bank container.

Expected behaviour

The item should disappear when being deposited into the group ironman bank.

Screenshots

Additional context

Originally reported in #14 (comment)

When depositing items into the bank, it would be nice if the plugin was more intelligent about item stacks / noted items.

If I'm depositing 10 items from a stack of 20 I don't want the stack to disappear. It would be extra fancy if it instantly updated the count to 10, but that's not as pressing of a request as not making the stack disappear.

I received a report for my plugin not working. It seems like it's a conflict with your plugin. I looked into it, and it seems that your plugin will override any other plugin which attempts to hide items.

This is the offending section of code which forcefully hides/shows items based on your set of rules.

Is there a way that your plugin can respect items hidden by other plugins? Something like, if an item's visibility changes, and you didn't change it, then you don't mess with it?

Happy to work together to figure out a solution. But this seems like an issue that is wider than just between our two plugins.