elgbar / instant-inventory Goto Github PK
View Code? Open in Web Editor NEWRunelite plugin to instantly do inventory actions
Home Page: https://runelite.net/plugin-hub/show/instant-inventory
License: BSD 2-Clause "Simplified" License
Runelite plugin to instantly do inventory actions
Home Page: https://runelite.net/plugin-hub/show/instant-inventory
License: BSD 2-Clause "Simplified" License
Describe the bug
The bank interface does not display the deposited item if there is no existing item in the bank
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
The deposited item should be shown with change opacity where it will be placed the next tick
Screenshots
Additional context
We must be able to identify which tab is active in the bank. This should be possible with the CURRENT_BANK_TAB
(4150
) varbit
Dropping any light source in a dark area gives the message "Dropping that would leave you without a light source" from the runescape client and prevents the item from being removed from your inventory.
If I decide to enter a dark area, such Tears of Guthix or the Tunnel in Lumby castle basement, and drop my light source then the inventory spot appears empty, but i may not swap with this inventory spot or pick up any additional items. In order to fix it I have to go to a bank, deposit the item (it appears in a bank window), CLOSE THE BANK, then access the bank again and retrieve my item.
Almost thought I had to buy another firemaking cape, scared the shit out of me man! lol
I appreciate your plugin so I just wanted to take this time to additionally thank you for your work on it. This bug is pretty preventable by not being a dingus so don't worry too much about it!
I received a report for my plugin not working. It seems like it's a conflict with your plugin. I looked into it, and it seems that your plugin will override any other plugin which attempts to hide items.
This is the offending section of code which forcefully hides/shows items based on your set of rules.
Is there a way that your plugin can respect items hidden by other plugins? Something like, if an item's visibility changes, and you didn't change it, then you don't mess with it?
Happy to work together to figure out a solution. But this seems like an issue that is wider than just between our two plugins.
I've noticed that any items that open a dialog box to warn/verify that you want to drop (e.g. based on the limit set in-game) hide the item immediately regardless of whether the drop is confirmed or not. This is especially problematic if you are mid-combat and the dialog box gets interrupted, as it effectively causes the item to disappear from your inventory.
To prevent similar issues, I think following each "hide" action with an inventory state check at the next game tick in order to verify synchronization may help to minimize these sorts of errors, especially if support for gear switches is intended to be added in the near future. It would be very unfortunate to have certain crucial items accidentally become inaccessible from your inventory during difficult PvM and PvP situations.
Noticed when using this plugin that one time I dropped 2 logs while mid-animation entering Kharazi jungle.
Because of this the client side update from this plugin "removed" them from my inventory, but they were infact still there. So possibly needs to check if the drop actually happened and if not, revert the client side change.
Opening the bank alerted me to this as they now became visible, but even banking and re-withdrawing them did not update the client side. Had to disable plugin, then bank/re-withdraw.
Describe the bug
A clear and concise description of what the bug is.
When you have an item set to shift click wear with menu entry swapper and the instant equip feature on, the item will not equip.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
A clear and concise description of what you expected to happen.
the item should equip
Screenshots
If applicable, add screenshots/video to help explain your problem.
Additional context
Add any other context about the problem here.
Is your feature request related to a problem? Please describe.
When I'm using inventory and I'm dropping many things, id like it to hide inventory tags when the item is hidden. One use-case is when you're barbarian fishing, you may tag trout/salmon one color and tag sturgeon another color. With low opacity these tags are still very much showing.
Describe the solution you'd like
I would like to hide the inventory tag for a given item if one exists when it is hidden because the item was dropped.
Describe alternatives you've considered
This could potentially be a configuration option, but I feel its what you would intuitively want so I think it would remove inventory tags by default and not a config option.
Additional context
N/A
Can you bring back the old version of instant inventory this no one feels so buggy and weird.
After setting an item from "use" to "drop" left click, Instant Inventory causes there to be problems while spam clicking to drop items. As shown in the .gif above, double-clicking causes the item to be clicked again as a "use" action once Instant Inventory considers the item to be dropped. This behavior doesn't happen when Drop Items Instantly is disabled as shown on the left.
Describe the bug
Group ironman bank storage; upon depositing items to the group storage (with this plugin enabled) the items actually go to the storage. However, the item I just deposited "appears" on my inventory still, yet having the option to still "deposit" them, even though they don't actually exist in my inventory anymore.
To Reproduce
Steps to reproduce the behaviour:
Group Storage
on a Group IronmanExpected behaviour
The item should disappear when being deposited into the group ironman bank.
Screenshots
Additional context
Originally reported in #14 (comment)
Is it feasible to extend the plugin to instantly update the inventory when withdrawing/depositing from a bank?
When depositing items via the Deposit-X
menu option you must enter the amount to deposit in the Enter amount:
input box.
When pressing enter to deposit the amount the item in the inventory is not updated instantly, but rather the next tick.
Suggested solution
Add a listener for the Enter amount:
input box and update the size of the item stack last clicked
Describe the bug
While stunned, you cannot change equipment. But the plugin still tries to update the inventory.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
The items should not be be handled as equipped
Screenshots
TODO
Additional context
Originally reported on reddit: https://www.reddit.com/r/2007scape/comments/1ayadd5/comment/kruvbpz/
When depositing items into the bank, it would be nice if the plugin was more intelligent about item stacks / noted items.
If I'm depositing 10 items from a stack of 20 I don't want the stack to disappear. It would be extra fancy if it instantly updated the count to 10, but that's not as pressing of a request as not making the stack disappear.
Hide as dropped if the equal slot is empty
Swap with current equipped item if there is something in the slot (and you can equip it)
Currently its hardcoded to 2 ticks with
/**
* Maximum number of ticks an item should be displayed as something else
*/
public static final int MAX_UNMODIFIED_TICKS = 2;
It should be a config option with the default value of MAX_UNMODIFIED_TICKS
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.