Exists property is missing from ExistsResponse and ExistsAliasResponse about elasticsearch-net HOT 5 CLOSED

Hi @gpetrou,

thanks for reporting!

These properties are not defined in the specification. The old generator had a hardcoded condition to emit these properties. I'll manually add them back in the next patch release.

from elasticsearch-net.

Do we need them? I think that "IsValidResponse" is enough to validate that, no?

from elasticsearch-net.

@TheFireCookie That's correct, we don't really need them. These properties are just checking the status code - just like IsValidResponse:

public bool Exists => ApiCallDetails is
{
    HasSuccessfulStatusCode: true, HttpStatusCode: 200
};

For now I'll still add them back to not introduce more breaking changes than needed 🙂

I might remove them in the next major version. Another option would be to keep them and override IsValidResponse in addition. For these endpoints, a 404 is actually valid in my opinion. But that might over-complicate things as users are probably used to expect false for IsValidResponse when entities are non existing.

from elasticsearch-net.

This property exists since NEST. Why remove it? There are already too many breaking changes to worry about.

from elasticsearch-net.

Fixed in 8.13.4

from elasticsearch-net.