Comments (5)
Hi @gpetrou,
thanks for reporting!
These properties are not defined in the specification. The old generator had a hardcoded condition to emit these properties. I'll manually add them back in the next patch release.
from elasticsearch-net.
Do we need them? I think that "IsValidResponse" is enough to validate that, no?
from elasticsearch-net.
@TheFireCookie That's correct, we don't really need them. These properties are just checking the status code - just like IsValidResponse
:
public bool Exists => ApiCallDetails is
{
HasSuccessfulStatusCode: true, HttpStatusCode: 200
};
For now I'll still add them back to not introduce more breaking changes than needed 🙂
I might remove them in the next major version. Another option would be to keep them and override IsValidResponse
in addition. For these endpoints, a 404 is actually valid in my opinion. But that might over-complicate things as users are probably used to expect false
for IsValidResponse
when entities are non existing.
from elasticsearch-net.
This property exists since NEST. Why remove it? There are already too many breaking changes to worry about.
from elasticsearch-net.
Fixed in 8.13.4
from elasticsearch-net.
Related Issues (20)
- Cannot retrieve mapping of index with `icu_collation_keyword` field HOT 6
- cannot instantiate new DynamicTemplate when creating index. HOT 4
- Default index is not used in query with 8.13.15 client HOT 6
- Missing properties in aggregation API HOT 3
- Improve documentation for error handling
- Elastic.Transport.UnexpectedTransportException when calling elasticClient.MachineLearning.InferTrainedModelAsync HOT 1
- Support for using input_output option in inference processor
- CI: Automate reference documentation
- Intervals query is missing the option to set Field HOT 3
- Fluent API for composite aggregation sources
- IndexSettingsConverter tries to deserialize routing_path as collection of string even if there is a string in raw JSON response HOT 1
- ESQL Arrow support
- Implement Connectors API
- Add back TermsRangeQuery in the Elasticsearch .Net Client HOT 1
- error in elastic client when trying to get the mappings HOT 5
- Cannot run knn query using elasticClient.RequestResponseSerializer HOT 4
- Improve usability of `FiltersAggregation` HOT 1
- Adding document to Elastic with Client.IndexAsync doesn't await result; also ambigious function parameters HOT 7
- ElasticsearchClient.Indicies.GetAsync throws UnexpectedTransportException
- IndexSettings NumberOfShards and NumberOfReplicas are objects, not int/long as expected HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elasticsearch-net.