Im trying to run a knn query in version 8.14.2 of dotnet client by passing json strin

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

i can confirm that using the typed client for knn works : <div class="snippet-clip

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Cannot run knn query using elasticClient.RequestResponseSerializer about elasticsearch-net HOT 4 CLOSED

giannik commented on July 17, 2024

Cannot run knn query using elasticClient.RequestResponseSerializer

from elasticsearch-net.

Comments (4)

flobernd commented on July 17, 2024 1

Going to close this issue for now, but please feel free to open a new one, if you have additional questions, etc.

from elasticsearch-net.

flobernd commented on July 17, 2024

Hi @giannik,

I think this might be the same case that I tried to explain to you a few days ago in this comment.

Manual (De-)serialization of the data structures is an unsupported use-case.
[...] certain types only implement either serialization OR deserialization

For the majority of cases, Request types only implement serialization (because they are never deserialized in the client).

Could you please check, if the same query as well causes an error, if you build it by using e.g. the fluent API? If that's the case I will investigate further, but otherwise this best thing I can recommend to you is:

Usually we suggest using your own custom CLR types and copy over / assign the values from the Elasticsearch types.

from elasticsearch-net.

giannik commented on July 17, 2024

i can confirm that using the typed client for knn works :

 var floatList = new List<float> { 0.0185484141f, -0.000538613356f };

                var searchResponse1 = await _elasticClient.SearchAsync<Dictionary<string, object>>(s =>
                                s.Index(_indexPrefix + indexName)

                                .Knn(qd =>
                                {
                                    qd.k(2)
                                        .NumCandidates(100)
                                        .Field("ContentItem_Vector.vector")
                                        .QueryVector(floatList);
                                }));

but i was looking for a generic mechanism to just pass the json i write in the dev console to the c# client and execute it . it works for query dsl type queries but not for knn.

so basically given my current code for the generic mechanism is this :


    using var stream = new MemoryStream(Encoding.UTF8.GetBytes(query));
                var deserializedSearchRequest = _elasticClient.RequestResponseSerializer.Deserialize<SearchRequest>(stream);

                var searchRequest = new SearchRequest(_indexPrefix + indexName)
                {

                   // Knn = deserializedSearchRequest.Knn,
                    Query = deserializedSearchRequest.Query,
                    From = deserializedSearchRequest.From,
                    Size = deserializedSearchRequest.Size,
                    Fields = deserializedSearchRequest.Fields,
                    Sort = deserializedSearchRequest.Sort,
                    Source = deserializedSearchRequest.Source,
                };

                var searchResponse = await _elasticClient.SearchAsync<Dictionary<string, object>>(searchRequest);

the sugestion is i should skip this part :

  using var stream = new MemoryStream(Encoding.UTF8.GetBytes(query));
                var deserializedSearchRequest = _elasticClient.RequestResponseSerializer.Deserialize<SearchRequest>(stream);

and rather deserialize to my own objects and then pass in the values needed the the client :


                var searchRequest = new SearchRequest(_indexPrefix + indexName)
                {

                    Knn = MYdeserializedSearchRequest.Knn,
                    Query = MYdeserializedSearchRequest.Query,
                    From = MYdeserializedSearchRequest.From,
                    Size = MYdeserializedSearchRequest.Size,
                    Fields = MYdeserializedSearchRequest.Fields,
                    Sort = MYdeserializedSearchRequest.Sort,
                    Source = MYdeserializedSearchRequest.Source,
                };

   var searchResponse = await _elasticClient.SearchAsync<Dictionary<string, object>>(searchRequest);

Correct ?

from elasticsearch-net.

flobernd commented on July 17, 2024

Hi @giannik, yes that's essentially what we suggest in these cases 🙂

I understand that a full round-trippable (de-)serialization would provide a convenient way of executing queries that are stored as JSON, but at the moment there are not plans to support this.

i was looking for a generic mechanism to just pass the json i write in the dev console to the c# client and execute it . it works for query dsl type queries but not for knn.

The query-dsl types are round-trippable, because they are as well returned by some APIs, which mans we need both serialization- and deserialization support for them in the client.

Maybe reflection could be used to implement a completely generic way of executing queries for your console app use-case.

from elasticsearch-net.

Cannot run knn query using elasticClient.RequestResponseSerializer about elasticsearch-net HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent