IndexSettings NumberOfShards and NumberOfReplicas are objects, not int/long as expected about elasticsearch-net HOT 4 OPEN

Some additional context here.

Sadly, there won't be a fix for this before the above mentioned feature is implemented.

from elasticsearch-net.

Ah gotcha. I'll manage for now by wrapping them in a Convert.ToInt32() so no rush.

Question: According to your spec above, they are defined as nullable. Is this correct? I thought they were always present in the Index Settings?

from elasticsearch-net.

I think the fields are all nullable at the moment, to make sure some of the other clients don't break if a field is not present. The Java client e.g. fails to deserialize objects, if a required field is missing. The Elasticsearch server on the other hand tends to omit certain fields under certain shady conditions 😋 Modelling it like this was probably the most safe way - this surely must be checked in detail as well as soon as we get to improve the IndexSettings in the spec.

from elasticsearch-net.

Hi @andersosthus, the IndexSettings are not completely modelled in the specification at the moment.

This is how it currently looks for these 2 fields:

  /** @server_default 1 */
  number_of_shards?: integer | string // TODO: should be only int
  /** @server_default 0 */
  number_of_replicas?: integer | string // TODO: should be only int

As .NET does not support unions discriminated by type, the generator simplifies this construct as object. As you can see in your screenshot, the values are actually not ints, but strings containing a number.

The specification should probably be changed like this:

  /** @server_default 1 */
  number_of_shards?: Stringified<integer>
  /** @server_default 0 */
  number_of_replicas?: Stringified<integer>

from elasticsearch-net.