Code Monkey home page Code Monkey logo

Comments (3)

sbenthall avatar sbenthall commented on May 31, 2024

@alanlujan91 did you go ahead and do this with #1216 ? Shall we close this issue?

from hark.

alanlujan91 avatar alanlujan91 commented on May 31, 2024

Was using that branch to test github actions. I'm still not sure that test does anything other than test whether everything is formatted. What I wanted to see was if it would format anything that was not formatted.

from hark.

sbenthall avatar sbenthall commented on May 31, 2024

Some open questions here:

  • It is possible to use black for formatting notebooks and maybe even docs. Do we want to enforce black on all these materials, or just the library code?
  • Do we want to automatically run black?
    • We could have black run automatically on PRs with GitHub actions.
    • We could also have black run automatically as a 'pre-commit hook', which would happen in local development before pushing a branch to GitHub to be a PR.

We probably don't need black both as a pre-commit hook and a GitHub Action.

On the other hand, I've seen in another project that @MridulS swapped out black for ruff, which looks...fast

https://github.com/charliermarsh/ruff

Do we need to revisit the choice of black now that ruff is cool?

from hark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.