IndShockConsumerType.calc_jacobian() changes cFunc_terminal_ about hark HOT 4 CLOSED

@wdu9 @Mv77 this might be relevant to you

from hark.

I mean sure, its hacky.

But @wdu9 did it to get hark to do something it was not meant to do. It would be really annoying to have had to define a new class to do it properly.

The way I did it when I needed to do the same in my own branch was to add an optional extra argument to solve which would be a solution to serve as the start of backward induction. It makes it ignore the default terminal solution.

Should I make a PR with that change?

from hark.

from hark.

This is now fixed in #1410 by adding an optional boolean input to AgentType.solve, which overrides the usual call to presolve at the top of solve. The presolve routine does setup work, but in unusual situations a user might want to not do some of those things, like when they want to start with a "custom" terminal solution (as in calc_jacobian). With that in place, it's just a one line change in calc_jacobian to change how the "terminal solution hacking" works so that it doesn't touch something unintended.

from hark.