Comments (8)
mnwhite
commented on May 29, 2024
1
Yes, something like that will likely be part of the solution. This is the
kind of problem that will be fixed by the parameters overhaul I'm beginning
work on now, to make constructed inputs more systematic and structured. The
terminal solution is a special constructed input, in that it's required.
…On Sat, Apr 6, 2024, 10:01 AM Mateo Velásquez-Giraldo < ***@***.***> wrote:
Maybe a policy for this would be that every agent type should define (not
simply inherit) its full update, pre_solve, and post_solve methods? You'd
be free to call super.update_whatever(...) in them, but at least you
would be doing it consciously?
—
Reply to this email directly, view it on GitHub
<#1405 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFMQLIOVAF6BEXUY6BDY3754DAVCNFSM6AAAAABFZ5UZJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGA4TOMJSGA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
from hark.
alanlujan91
commented on May 29, 2024
I think the solution is to remove the following lines
HARK/HARK/ConsumptionSaving/ConsPortfolioModel.py
Lines 174 to 178 in 3ee3979
but this might not be the only model that does something like this
from hark.
mnwhite
commented on May 29, 2024
The good news is that as long as all of the classes are doing
`self.update_terminal_solution()`, they will call the right one. The bad
news is that we're doing redundant work. For the record, pre_solve is
probably the right place for it to be called (but update is often called by
pre_solve, so...?).
…On Fri, Apr 5, 2024 at 7:44 PM Alan Lujan ***@***.***> wrote:
I think the solution is to remove the following lines
https://github.com/econ-ark/HARK/blob/3ee397993a1db76bbc9ae24d3196dc31ccfe4874/HARK/ConsumptionSaving/ConsPortfolioModel.py#L174-L178
but this might not be the only model that does something like this
—
Reply to this email directly, view it on GitHub
<#1405 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFLGGIUYMNXBQBQ37C3Y34ZONAVCNFSM6AAAAABFZ5UZJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQG43TAOBVGU>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
from hark.
alanlujan91
commented on May 29, 2024
Why don't we use super?
from hark.
mnwhite
commented on May 29, 2024
Because I don't think we want to use the parent class version at any point.
I could be wrong, however.
…On Fri, Apr 5, 2024 at 8:04 PM Alan Lujan ***@***.***> wrote:
Why don't we use super?
—
Reply to this email directly, view it on GitHub
<#1405 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFJ6UHMA6SYQV64W66TY343ZLAVCNFSM6AAAAABFZ5UZJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQHAYDAOJYGI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
from hark.
alanlujan91
commented on May 29, 2024
No I mean in general, super at instantiation
from hark.
Mv77
commented on May 29, 2024
Yeah, this is a problem. I think some agent types run the "create income process" from ConsIndShock as much as 3 times each for a single solve. Which can take longer than the solve itself...
from hark.
Mv77
commented on May 29, 2024
Maybe a policy for this would be that every agent type should define (not simply inherit) its full update, pre_solve, and post_solve methods? You'd be free to call super.update_whatever(...) in them, but at least you would be doing it consciously?
from hark.
Related Issues (20)
- Configurable mortality and aging in an AgentTypeMonteCarloSimulator HOT 1
- YAML config file to New Python Model Format (NPMF)
- NPMF for ConsIndShock HOT 4
- utilities.py: metadata bug in make_figs() HOT 7
- IndexError when solving ConsPortfolioModel HOT 2
- PermShk's are not random enough HOT 2
- We should not use both `seed` and `RNG`. HOT 4
- ImportError: cannot import name 'generated_jit' from 'numba' HOT 4
- Module not found... numpy? HOT 6
- calc_stable_points is being run when it shouldn't be
- ConsBequestModel and related example notebooks HOT 1
- Improve contributor guide with respect to API documentation
- Inheritance... HOT 4
- Proposed constructed input framework HOT 11
- Make sure our links are updated to the new doc website
- Should pytest be a requirement? HOT 3
- IndShockConsumerType.calc_jacobian() changes cFunc_terminal_ HOT 4
- Why does PerfForesightLabeled inherit from ConsIndShock? HOT 7
- DeprFac should be DeprRte
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hark.