eclipse / eclipse-collections-kata Goto Github PK

The pet-kata slides.md have the solutions inlined in the slides. Since the pet-kata-solutions module exists now, we should replace the solutions in the slides.md with links to the appropriate exercise solutions similar to how the company-kata slides handles this.

The link to Java Streams Tests framework has a broken path.

Dependency: Issue #114 is closed.

The method distinctLetters() in the TextProcessorEC class for the haiku-kata-solutions module is not yet implemented. Follow the TODOs and hints given in the method. Please do not add solutions to the non-solution modules. After writing the code, uncomment the test and tag annotations and check that the test case distinctLetters() in the TextProcessorECTest passes for the haiku-kata-solutions module. Make sure to adhere to our contribution guide.

Please note that this issue is created for GHC 2023 Open Source Day, thus priority will be given to the attendees of this event. After the event, this issue will be open to anyone.

Adding tags, updating the surefire configuration.

Please assign to me.

Add solutions links to Company kata slides

The current Eclipse Collections (org.eclipse.collections:eclipse-collections-api and org.eclipse.collections:eclipse-collections) version is 11.1.0. Upgrade it to 12.0.0.M3.

11.0.0.M6 was released yesterday and we need to update the katas to the newest version.

Eclipse shows "No projects are found" when following the steps described for Eclipse users in Initialize Kata section.

About the IDE:
Eclipse IDE for Enterprise Java and Web Developers
Version: 2021-03 (4.19.0)
Build id: 20210312-0638

The method getHaikuAsCharAdapter() in the TextProcessorEC class for the haiku-kata-solutions module is not yet implemented. Follow the TODOs and hints given in the method. Please do not add solutions to the non-solution modules. Make sure to adhere to our contribution guide.

Please note that this issue is created for GHC 2023 Open Source Day, thus priority will be given to the attendees of this event. After the event, this issue will be open to anyone.

Pet kata doesn't currently have a README. A README that describes the domain of the pet kata and has links to the appropriate slides.md for the kata could be very helpful.

There could be a link to this README in the main repo README so that it's easier to navigate to and read about the pet kata.

Exercise8Test

Javadoc links in slides.md need to be updated from 10.4.0 -> 11.0.0

The method findWordleWords() in the TextProcessorEC class for the haiku-kata-solutions module is not yet implemented. Follow the TODOs and hints given in the method. Please do not add solutions to the non-solution modules. After writing the code, uncomment the test and tag annotations and check that the test case findWordleWords() in the TextProcessorECTest passes for the haiku-kata-solutions module. Make sure to adhere to our contribution guide.

Please note that this issue is created for GHC 2023 Open Source Day, thus priority will be given to the attendees of this event. After the event, this issue will be open to anyone.

Exercise5Test

Exercise4Test

Similar to https://github.com/eclipse/eclipse-collections/actions?query=workflow%3ACheckstyle

The method topVowelAndConsonant() in the TextProcessorEC class for the haiku-kata-solutions module is not yet implemented. Follow the TODOs and hints given in the method. Please do not add solutions to the non-solution modules. After writing the code, uncomment the test and tag annotations and check that the test case topVowelAndConsonant() in the TextProcessorECTest passes for the haiku-kata-solutions module. Make sure to adhere to our contribution guide.

Please note that this issue is created for GHC 2023 Open Source Day, thus priority will be given to the attendees of this event. After the event, this issue will be open to anyone.

Add tag "KATA" to the exercises in haiku-kata and wordle-kata to keep it consistent with other katas.

Candy Kata example here. Similarly, add tag KATA to haiku-kata tests and wordle-kata tests.

There is a new reference guide for Eclipse Collections and wanted to update the link in the Reference Guide section of the ReadMe to point to this new document.

There exists no solutions module for the candy kata today. Follow the model for the solutions model currently checked in for the Pet Kata.

Start out by checking in unfinished tests for the CandyKataTest. Solutions for the test should be a separate pull request.

The method guess(String guess) in the WordleEC record for the wordle-kata-solutions module is not yet implemented. This is a more difficult exercise as it involves more EC APIs and has less guiding hints. Please complete the haiku-kata first if you're struggling with this issue. Follow the TODOs and hints given in the method. Please do not add solutions to the non-solution modules. After writing the code, uncomment the test and tag annotations and check that the test case matchWordWithGuess() in the WordleECTest class passes for the wordle-kata-solutions module. Make sure to adhere to our contribution guide.

Please note that this issue is created for GHC 2023 Open Source Day, thus priority will be given to the attendees of this event. After the event, this issue will be open to anyone.

this should be:

        Assertions.assertEquals(list.toReversed(), stack.pop(3));

Exercise7Test

The Work on Kata Exercises section of the README mentions the other 2 katas in the repo, but makes no mention of the candy-kata.

Candy-kata should be referenced alongside the other katas in the README.

Company kata doesn't currently have a README. A README that describes the domain of the company kata and has links to the appropriate slides.md for the kata could be very helpful.

There could be a link to this README in the main repo README so that it's easier to navigate to and read about the company kata.

Exercise1Test

Upgrade the JUnit 5 version to the latest stable one in all modules

Exercise2Test

The method duplicatesAndUnique() in the TextProcessorEC class for the haiku-kata-solutions module is not yet implemented. Follow the TODOs and hints given in the method. Please do not add solutions to the non-solution modules. After writing the code, uncomment the test and tag annotations and check that the test case duplicatesAndUnique() in the TextProcessorECTest passes for the haiku-kata-solutions module. Make sure to adhere to our contribution guide.

Please note that this issue is created for GHC 2023 Open Source Day, thus priority will be given to the attendees of this event. After the event, this issue will be open to anyone.

A code coverage report is a nice addition to Eclipse Collections. It allows the community to find areas that need improvement and it's a good source of future work

Since Eclipse Collections is compatible with Java 8, the Kata should work with Java 8 as well. If we want to use features of versions higher than Java 8 we might want to have a separate module for it. The reason for this is two fold:

1. Incorrect impression of users that Java 11 is required to use the library
2. For the majority of folks who are in Java 8, it means setting up their environment for Java 11 to use the Kata

Thoughts?

Candy kata doesn't currently have a README. A README that describes the domain of the candy kata would be very helpful.

There could be a link to this README in the main repo README so that it's easier to navigate to and read about the candy kata.

Exercise6Test

There exists no solutions module for the company kata today. Follow the model for the solutions model currently checked in for the Pet Kata.

Start out by checking in unfinished tests for each exercise. Solutions for each exercise should be separate pull requests. This will allow multiple developers to potentially complete them.

Reference: Link

Pet kata:

Exercise2Test:

My Pet.java is like this:

public @Slf4j record Pet(PetType type, String name, int age) {
  public String name() {
    log.trace("Pet type: {}, name: {}", type, name);
    return name;
  }
}

My Person.java is like this (I don't change anything except that I put a message logging in the getPets method):

public @Slf4j class Person {
  ...
  public MutableList<Pet> getPets() {
    log.trace("Person: first name: {}, last name: {}", firstName, lastName);
    return pets;
  }
}

findPetNamedSerpy() in Eclipse Collections:

Pet serpy =
    people
        .flatCollect(Person::getPets)
        .detectWith((pet, name) -> pet.name().equals(name), "Serpy");
assertTrue(serpy.type().toString().startsWith("snake "));

prints 13 method accesses

16:04:08.464 orker TRACE llection.pet.Person.getPets      - Person: first name: Mary, last name: Smith
16:04:08.474 orker TRACE llection.pet.Person.getPets      - Person: first name: Bob, last name: Smith
16:04:08.475 orker TRACE llection.pet.Person.getPets      - Person: first name: Ted, last name: Smith
16:04:08.475 orker TRACE llection.pet.Person.getPets      - Person: first name: Jake, last name: Snake
16:04:08.476 orker TRACE llection.pet.Person.getPets      - Person: first name: Barry, last name: Bird
16:04:08.476 orker TRACE llection.pet.Person.getPets      - Person: first name: Terry, last name: Turtle
16:04:08.477 orker TRACE llection.pet.Person.getPets      - Person: first name: Harry, last name: Hamster
16:04:08.477 orker TRACE llection.pet.Person.getPets      - Person: first name: John, last name: Doe
16:04:08.478 orker TRACE _collection.pet.Pet.name         - Pet type: cat ↺, name: Tabby
16:04:08.479 orker TRACE _collection.pet.Pet.name         - Pet type: cat ↺, name: Dolly
16:04:08.480 orker TRACE _collection.pet.Pet.name         - Pet type: dog ⇪, name: Spot
16:04:08.480 orker TRACE _collection.pet.Pet.name         - Pet type: dog ⇪, name: Spike
16:04:08.481 orker TRACE _collection.pet.Pet.name         - Pet type: snake ↭, name: Serpy

findPetNamedSerpy() in Java 8 Stream:

Optional<Pet> serpyOptional =
    people.stream()
        .flatMap(person -> person.getPets().stream())
        .filter(pet -> pet.name().equals("Serpy"))
        .findAny();
assertTrue(serpyOptional.isPresent());
assertTrue(serpyOptional.get().type().toString().startsWith("snake "));

prints 9 method accesses:

16:04:08.488 orker TRACE llection.pet.Person.getPets      - Person: first name: Mary, last name: Smith
16:04:08.489 orker TRACE _collection.pet.Pet.name         - Pet type: cat ↺, name: Tabby
16:04:08.490 orker TRACE llection.pet.Person.getPets      - Person: first name: Bob, last name: Smith
16:04:08.490 orker TRACE _collection.pet.Pet.name         - Pet type: cat ↺, name: Dolly
16:04:08.490 orker TRACE _collection.pet.Pet.name         - Pet type: dog ⇪, name: Spot
16:04:08.491 orker TRACE llection.pet.Person.getPets      - Person: first name: Ted, last name: Smith
16:04:08.491 orker TRACE _collection.pet.Pet.name         - Pet type: dog ⇪, name: Spike
16:04:08.492 orker TRACE llection.pet.Person.getPets      - Person: first name: Jake, last name: Snake
16:04:08.492 orker TRACE _collection.pet.Pet.name         - Pet type: snake ↭, name: Serpy

Is there any way in Eclipse Collections that makes this at least as good as Java 8 Stream?

I guess that Eclipse Collections is worse than Java 8 Stream whenever it has to create an intermediate collection. Is there any example to prove that my guessing is wrong?

Exercise3Test

The code I see is:

int keySize = Math.min(n, this.sizeDistinct());
MutableList<ObjectIntPair<T>> sorted = this.toListWithOccurrences().sortThisByInt(function);
MutableList<ObjectIntPair<T>> results = sorted.subList(0, keySize).toList();

If this.toListWithOccurrences() returns 100 pairs (100 /*number of occurrencies*/, Object), (1, Object), ... and to pickup the top 3 pairs, we have to sort all 100 pairs? If that's true, it's quite inefficient in this case. If that's untrue, how does it work for this case?

Katas currently depend on milestone 4. Update it to the latest milestone and verify solutions modules build.