dovops / sefariasidebarextension Goto Github PK

When searching free text at the top, also filter the entire set of references that are already sitting in the side bar.

Sefaria doesn't always tolerate all spelling variants of masechtot, and sometimes is case sensitive where it should not be. As a result empty result lists are common on certain sites
see also:
Sefaria/Sefaria-Project#1016

Per comments on https://github.com/Sefaria/Sefaria-Project/wiki/Projects-Powered-by-Sefaria - The Sefaria Logo itself should not be used given it is trademarked. Given this is no longer a prototype, The Sefaria Logo should with the Powered-by badge and/or similar non-trademarked assets.

cc: @EliezerIsrael

Rather than force the user to select each category to add/remove. Add a button to toggle them all on.

By accident, I regressed the CSS while updating the logo button that floats on the page, and went with 'absolute' instead of 'fixed. This causes the button to flow off the screen with scrolling instead of permanently hovering at the top of the screen regardless of page position.

When dual-amud events were supported, calls to getLinks were modified to support single/double mode (default being single). AllDaf change events don't call the correct method signature so they end up only defaulting to single mode. Fix is to call getLinks with DOUBLE as the second argument

Currently this is hard coded to filter ner mitsva/ein mishpat as this started as a prototype for daf yomi sites and the focus was Halacha related resources.

There’s no reason this isn’t more flexible with filterable sidebar categories especially since all the data is retrieved already.

Requested by sefaria team to use the powered by text in the extension name. The name that appears in the google store is controlled by the manifest file in this project.

Clean up regexes used to scrub and escape parameters, and urls :

Incomplete string escaping or encoding
master
contentScript.js#L68 • Detected 5 days ago

Incomplete string escaping or encoding
master
contentScript.js#L68 • Detected 5 days ago

Incomplete URL substring sanitization
master
recognizers.js#L184 • Detected 5 days ago

E-daf uses 'kesuvos' and Sefaria doesn't grok that. Need to swap to ketuvot, or ketubot, at least for now.

Bug in certain links that have apostrophes due to links being generated with single quotes. This causes links to things like Yore De'ah to break when generated.

Either escape the names at link generation time, or use double quotes for links as a stopgap.

At the top of the side bar there is currently a "feeling lucky" to navigate to a specific Sefaria topic / text by name / number . It would also be good to allow free text searches by linking to that url as well in the type ahead results

Right now sefaria defaults to hebrew. Make this a toggle option that's remembered with browser/extn local storage.

Given new branding added per #5 , re-work all screenshots and images.

Certain sites like shiurim are full daf sites. Make sure to query or enable sub tabs for both sides of the page since the default query is only for amud aleph.

Right now the api is called upon document load, that’s too greedy/aggressive.

Defer until sefaria logo is clicked and sidebar expanded.

If no results found, show a generic search bar

Currently the reader displays in a fixed width - there should be an option to widen it to full or 90% width (and contract it back to original width)