donutdan4114 / shopify Goto Github PK

I am using this library for building an Public App but after getting getAccessToken() it is not redirecting user under Shop Admin with dashboard.php open under it.

I'm reading the documentation at https://help.shopify.com/api/tutorials/sell-through-the-checkout-api and I thought "there should already be a PHP library that can create a checkout payment" and I stumbled here, but I didn't found anything related to the checkout.

Is this possible with this library?

I found the bug in the Drupal module but I guess it might be in this library?

https://www.drupal.org/project/shopify/issues/3223573#comment-14163593

Hi, is there any plan to release a stable version?

Situation
At the moment the Client class only pulls Products and their respective fields. In case the Shopify Product has some metafields attached to it, they are not made available through the client's getProducts and getProduct methods.

Current workaround
It is still possible to retrieve the metafields through the get method.

Feature request
The Product or Products returned from getProduct or getProducts could - optionally - return Product objects that include a metafields property with the metafields data.

Technical suggestion
Since this is not a must-have for all use-cases of the Shopify client, it could be implemented as a Decorator class, so that an application needing access to the metafields of a product could simply do the following:

$client = new Shopify\PrivateApp($domain, $api_key, $password, $shared_secret));
$client = new MetafieldsClient($client);

Laravel 8 was released on 9/8/2020, and it increased Guzzle's minimum version requirement from ^6.3 to ^7.0.1. This unfortunately means that this package can't be used because it's requiring ~6.0.

One potential problem is that Guzzle 7 requires PHP >=7.2, so it would make a pretty big bump from your current >=5.5.0 requirement. Nobody should be using PHP 5.* at this point anyway. PHP 7.2 hasn't been actively supported since 11/30/2019, and PHP 7.3 only has active support until 12/6/2020, 2 months from now. Anybody that runs into issues with the version bump is likely having many more issues than just this package ;)

Looking through your package's source, I don't see anything in the Guzzle 6 to 7 upgrade guide that will cause any incompatibilities or problems. I don't think you'll need to change any code at all, actually. I haven't spun up a dev store to run the tests against yet though so I'm not 100% sure. I'd be happy to do that, if you'd like.

Thanks!

Hi,

I suggest to add more example with product in documentation.
For example, how can i add a product with price, with weight, etc ...
In fact, examples onto Shopify documentation could be great: https://help.shopify.com/en/api/reference/products/product#create

Best regards,

Looks like there is no checking for null values:

PHP Error: Call to a member function getBody() on null in /vendor/donutdan4114/shopify/src/Shopify/Client.php on line 110

I am unable to get more than 250 items from the resource pager when using a limit over 250. I get an error that the max limit is 250.

Hi! Thanks for this great SDK, what's its license?

I am just trying out this package and I am getting a request failed when trying to execute this example from the documentation:

$data = [
      "product" => [
        "title" => "Burton Custom Freestyle 151",
        "body_html" => "<strong>Good snowboard!</strong>",
        "vendor" => "Burton",
        "product_type" => "Snowboard",
        "images" => [
          [
            "src" => "https://images.blue-tomato.com/is/image/bluetomato/303918343_front.jpg-3LUB_zANeWE0vFkg1nUL6gG4MVo/Custom+166W+2020.jpg"
            ]
        ]
      ]
];

$result = $client->post('products', $data);

But when executing the same request through Postman it doesn't produce an error:

{
  "product": {
    "title": "Burton Custom Freestyle 151",
    "body_html": "<strong>Good snowboard!</strong>",
    "vendor": "Burton",
    "product_type": "Snowboard",
    "images": [
      {
        "src": "https://images.blue-tomato.com/is/image/bluetomato/303918343_front.jpg-3LUB_zANeWE0vFkg1nUL6gG4MVo/Custom+166W+2020.jpg"
      }
    ]
  }
}

In either situation the product is created in the Shopify store.

I'm coping this error:[Sat Jul 09 05:25:27 2016] [error] [client 127.0.0.1] Invalid webhook: Invalid webhook. using PageKite locally for testing. Is there any settings I'm missing? All other requests work well, except incoming webhooks.

This seems to be a known issue in the Shopify community. I haven't figured out the best way to create a valid HMAC that would match Shopify's.

This code should work, per Shopify's own guidelines.
https://github.com/donutdan4114/shopify/blob/master/src/Shopify/PublicApp.php#L144

  public function hmacSignatureValid(array $params = []) {
    $original_hmac = $params['hmac'];
    unset($params['hmac']);
    unset($params['signature']);
    sort($params);
    $data = http_build_query($params);
    return TRUE; // @todo: Figure out why HMAC isn't working. This should work based on the docs.
    return ($original_hmac === $this->calculateHmac($data, $this->shared_secret));
  }

When calling the GraphQL endpoint (/admin/graphql.json) it'll throw an exception when trying to work out the number of API calls made/left in Client.php on the first line of this function:
protected function setCallLimitParams() { $limit_parts = explode('/', $this->last_response->getHeader(self::CALL_LIMIT_HEADER)[0]); $this->call_limit = $limit_parts[0]; $this->call_bucket = $limit_parts[1]; }
with the error

Undefined offset: 0
due to the way GraphQL returns data.
Commenting out the checks for API limits allows it to work, but then means call rate limiting is redundant

Hey, trying to understand why you did it this way, i didn't test it yet, but it doesn't seems right

1. if for example the call limit your app can make is 40, the callLimitReached function will return true if you still have 8 calls left,
2. you are doing a random sleep of between 3-10 seconds if the "limit" is reached

It seems like worse case you will wait 10 seconds to make a request while you still have 8 requests available left, best case is 3 seconds.

You are doing the limit check after each request, so why don't you just check if you have 1 available request left, if you do sleep for 1 second?

Anything i'm missing why this was built this way?

Can a release be created when new feature is added or we risk breaks when new features are not backwards compatibe?

when I new a PublicApp object with shopDomain ,apiKey, apiSecretKey. It always remind me "syntax error, unexpected '$object' (T_VARIABLE)" . what happen . please help

We need a new exception for when a missing scopes error occurs.

Hi, there.

We have just received an email from Shopify stating that:-

Shopify API version 2019-04 on will be removed on April 1, 2020. Update to version 2019-07 and replace the following deprecated API calls to avoid breaking changes."

The page filter has been removed. Please use cursor-based pagination instead.

The featured field has been removed from the Collects resource

I am just wondering if this is something that is in the pipeline to fix in this repo or if it requires more developers to work on this?

Thanks

installation with composer leads to error:
[InvalidArgumentException]
Could not find a version of package donutdan4114/shopify@dev matching your minimum-stability (stable). Require it with
an explicit version constraint allowing its desired stability.