sleep on requests limit reach issue about shopify HOT 5 OPEN

I totally agree with to you. The api limit check is still not optimized

from shopify.

Do you have any idea to deal with this problem? @Art3miX

from shopify.

I didn't use this lib in the end and can't do a pull request.

But yea, its pretty easy to change it.

in client.php :
getCallLimit should return the exact number of request left, so we take the bucket size and reduce the amount of calls we already did :
return $this->call_bucket - $this->call_limit;

callLimitReached should return true if 1 or less requests left (just in case we leave extra 1 request in bucket).
return $this->getCallLimit() <= 1;

And the sleep should be changed to 1 second, because shopify give us 2 requests each second, so we wait 1 second and we get extra 2 requests, this will ensure us we only wait the minimum time needed between requests.
in request function:

if ($this->rate_limit && self::$delay_next_call) {
      // Sleep a random amount of time to help prevent bucket overflow.
      usleep(1 * 1000000);
    }

Sorry for this poor answer, but this should get you going (unless i forgot something), i'm sure someone can find the time to do a pull request.

from shopify.

Ok. I think it's great idea. But how can I do it inside this lib without processing in the request method?

from shopify.

I found a solve in the internet by reading header named Retry-After, but I don't test it.

from shopify.