Code Monkey home page Code Monkey logo

Comments (11)

singh88 avatar singh88 commented on June 12, 2024 2

Now, I guess we can close this issue because I have enough information on what can and can not be done at this moment. Thank you @marcelofabri and @diogot for your help!!

from danger-xcode_summary.

marcelofabri avatar marcelofabri commented on June 12, 2024 1

result only contains the message and the location: https://github.com/diogot/danger-xcode_summary/blob/master/lib/xcode_summary/plugin.rb#L21-L22

At this point it's probably easier to change the JSON file in your script, before xcode_summary is called.

from danger-xcode_summary.

marcelofabri avatar marcelofabri commented on June 12, 2024 1

You can set it to an array: https://github.com/diogot/danger-xcode_summary/blob/master/lib/xcode_summary/plugin.rb#L30-L36

from danger-xcode_summary.

marcelofabri avatar marcelofabri commented on June 12, 2024

Can you provide a sample JSON?

from danger-xcode_summary.

singh88 avatar singh88 commented on June 12, 2024

@marcelofabri, sure, Just added that in my issue notes.

from danger-xcode_summary.

singh88 avatar singh88 commented on June 12, 2024

@marcelofabri , Just wanted to add more information on this issue. I am trying to ignore any warnings from Pods directory and I can achieve that by using xcode_summary.ignored_files but since all the
Pods warnings are part of compile_warnings key, I thought it's better to just avoid compile_warnings but its not working.

from danger-xcode_summary.

diogot avatar diogot commented on June 12, 2024

If you want to ignore compile warnings from Pods it's better to use:

# Ignoring warnings from Pods
xcode_summary.ignored_files = 'Pods/**'

from danger-xcode_summary.

singh88 avatar singh88 commented on June 12, 2024

Thanks @diogot, how can I use

xcode_summary.ignored_results { |result|
 result.message.start_with? 'compile_warnings' # Ignore compile_warnings

to achieve the same.

from danger-xcode_summary.

diogot avatar diogot commented on June 12, 2024

I think you can't. The text is used to search for message content, not the message type.

from danger-xcode_summary.

singh88 avatar singh88 commented on June 12, 2024

@diogot, Is there any way I can use keys from the xcodebuild.json mentioned here because I don't want to show any compile_warnings or ld_warnings so If I choose xcode_summary.ignored_files then I am just limited Pods/** but actually my requirement to avoid any compile_warnings or ld_warnings.

from danger-xcode_summary.

singh88 avatar singh88 commented on June 12, 2024

thanks for the quick response @marcelofabri, last doubt, can xcode_summary.ignored_filesstore comma seperated values?

from danger-xcode_summary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.