Code Monkey home page Code Monkey logo

Comments (3)

frknbasaran avatar frknbasaran commented on July 20, 2024

Hello

I tried with an app by generated Vue app generator and couldn't reproduce this situation. Can you provide smaller set for the reproduce this problem please?

Thank you for reporting.

from countly-sdk-web.

raulotaolea avatar raulotaolea commented on July 20, 2024

Hi @frknbasaran !

Sure, here it is:

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <title>Countly issue-39</title>
  <script type='text/javascript'>
    let elements = [];

    function initialize() {
      elements = [document.getElementById('text0')];
    }

    function changeColor(newColor) {
      for (let e of elements) {
        e.style.color = newColor;
      }
    }

    function addFeedbackWidget() {
      Countly.q.push(['enable_feedback', { popups: ['WIDGET_ID'] }]);
    }

    document.addEventListener('DOMContentLoaded', function() {
      initialize();
    });
  </script>

  <script type='text/javascript'>

    var Countly = Countly || {};
    Countly.q = Countly.q || [];

    Countly.app_key = "APP_KEY";
    Countly.url = "SERVER_URL";

    (function() {
      var cly = document.createElement('script'); cly.type = 'text/javascript';
      cly.async = true;
      cly.src = 'https://cdn.jsdelivr.net/npm/countly-sdk-web@latest/lib/countly.min.js';
      cly.onload = function(){Countly.init()};
      var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(cly, s);
    })();
  </script>
</head>

<body>
     <div id="text0">This is the issue #39 demo.</div>

     <button onclick="changeColor('red')">Red</button>
     <button onclick="changeColor('green')">Green</button>
     <button onclick="changeColor('blue')">Blue</button>
     <button onclick="addFeedbackWidget()">Call enable feedback</button>
</body>
</html>

Please, change WIDGET_ID, APP_KEY and SERVER_URL appropriately.

Indeed, it isn't a problem with Vue or any other framework. The problem is that if you insert anything in a script before the call to enable_feedback, when the function execute document.body.innberHTML += 'whatever' it regenerates everything loosing any reference to a previous generated variables.

I created the PR #40 to fix it, changing document.body.innerHTML += '...' with document.body.insertAdjacentHTML('beforeend', '...');. This way, the body is not reprocessed.

from countly-sdk-web.

mt-ronkorving avatar mt-ronkorving commented on July 20, 2024

Fixed by #40

from countly-sdk-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.