Can not work when the salt on Countly server is set about countly-sdk-web HOT 5 CLOSED

BTW, I have done some improvements on the branch at https://github.com/leewenbil/countly-sdk-web/tree/add-salt, so it can work when set up the salt. You can also reach the minified SDK countly.with.salt.min.js

from countly-sdk-web.

Hello,
"If set the salt, the Countly can not work. "
I would assume that countly still works, but it doesn't have the salt feature.
This is by design as it is not really possible to have it in a secure way in the browser. We don't plan on adding the salt feature to the web SDK.

I did look at the changes done in your branch. in total in has ~12500 lines changed. There is no way of telling what specific changes you did because you changed the whole formatting.

from countly-sdk-web.

Hello, "If set the salt, the Countly can not work. " I would assume that countly still works, but it doesn't have the salt feature. This is by design as it is not really possible to have it in a secure way in the browser. We don't plan on adding the salt feature to the web SDK.

I did look at the changes done in your branch. in total in has ~12500 lines changed. There is no way of telling what specific changes you did because you changed the whole formatting.

Thank you for your feedback. I got it. I have some change and create the pull request you can review the code(not format).
BTW, why do I do the change? We know that If salt on Countly server is set, all requests would be checked for the validity of &checksum field before being processed. So need to set exactly the same salt on the on the SDK side, then salt to be used for calculating checksum of request data, which will be sent with each request using &checksum field.

from countly-sdk-web.

@ArtursKadikis would you please check this? Thank you

from countly-sdk-web.

Hello, @leewenbil , I answered in the PR

from countly-sdk-web.