Comments (6)
corrados
commented on June 28, 2024
1
BTW, I may convert this Issue in a Discussion thread later on because as soon as I close it, most people will not find the investigation results you have given in your initial post. I assume that new users will only check for help in the Discussion forums.
from edrumulus.
corrados
commented on June 28, 2024
If there's no clipping, then you're apparently in that range.
Some clipping is allowed. I have implemented a clipping compensation in software.
Therefore imho it would be more honest to tell people that they need to play with the parameters to find a circuit that may work for them.
This is the current disclaimer on the main page:
DISCLAIMER All these circuit diagrams are used for my first prototypes and work fine for me. Use them at your own risk.
If you want to see a different text then please make a proposal.
from edrumulus.
3hhh
commented on June 28, 2024
This is the current disclaimer on the main page:
**DISCLAIMER All these circuit diagrams are used for my first prototypes and work fine for me. Use them at your own risk.**
If you want to see a different text then please make a proposal.
I guess "In particular the circuits may not work for currently unsupported pieces of hardware." might be fair enough for a disclaimer.
However additionally some documentation on how to support new pieces of hardware would've been clarifying and helpful.
Currently the steps appear to be:
1. Start with prototype2 & optimize the analog circuit (atm it is unclear to me how to do that apart from random testing; I might know more once I can verify my simulation in practice).
2. Create samples for the edrumulus Octave model according to the existing doc. Probably getting them from the edrumulus hardware itself is more realisitic than from whatever sound card.
3. Analyze the samples in the Octave model to identify the edrumulus parameters. We discussed that in the forum.
4. Set the identified parameters in the edrumulus C++ code and test them in practice. Modify the available real-time parameters for hopefully better results. Possibly go back to previous steps.
from edrumulus.
corrados
commented on June 28, 2024
I guess "In particular the circuits may not work for currently unsupported pieces of hardware." might be fair enough for a disclaimer.
done
from edrumulus.
corrados
commented on June 28, 2024
I have added your step-by-step guide to https://github.com/corrados/edrumulus/blob/main/doc/manual.md. Feel free to correct/improve the text.
from edrumulus.
3hhh
commented on June 28, 2024
Nice, thanks!
Btw I tested it in practice and unfortunately I couldn't record a signal that looked significantly better than previous ones (maybe there's some generic issue with the way I'm recording, idk). However I could lower the edrumulus threshold from an unusable 20 to around 10. Therefore I guess I'm going to stick with Rs=1k, Rp=100k, Cp=0 for the MPS 750x Tom for now. Cp dampens the gain as expected, but it doesn't look like I need it for the MPS 750x Tom.
from edrumulus.
Related Issues (20)
- edrumuluscontrol.m: add midi in/out labels HOT 2
- Is Prototype 2 still supported/recommended? (get_prototype_pins) HOT 3
- Floating signal on disconnected ports HOT 12
- spike cancellation looks like a local parameter, but is a global one HOT 7
- Disconnecting a rimshot input makes regular hits become rimshots HOT 23
- Rim signals may be too strong for edrumulus HOT 13
- Teensy: High pins don't work HOT 1
- Hihat stomp is weak and cannot be mixed alone HOT 3
- Pos sensing only works with middle piezo HOT 8
- edrumulus_gui.py removes trigger settings, if killed HOT 2
- Cross talk cancellation doesn't work reliably HOT 10
- cymbal choke causes rim triggers HOT 6
- hihat pedal cross-talk HOT 20
- Unable to run edrumulus_gui.py on Windows HOT 19
- Add video to readme HOT 3
- Bad cymbal rim dynamics HOT 6
- Idea: Test edrumulus on x64 hardware
- Direct piezo hits sometimes cause a MIDI mute HOT 5
- Half-open hihat play tends to cause soft pedal stomps HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edrumulus.