Comments (6)
corrados
commented on September 26, 2024
I cannot reproduce this issue. With my Roland CY pad, I get good dynamics when I hit the rim.
from edrumulus.
3hhh
commented on September 26, 2024
Interesting. Then I'll have to investigate this further...
from edrumulus.
3hhh
commented on September 26, 2024
So I went to some lengths to obtain proper samples from my Teensy with this code.
(Btw it would be useful to have some standardized way of obtaining samples in the repo.)
The results:
Unfortunately I cannot see any fault in my signals as their peak voltage clearly indicates the velocity. Also, the rim switch capacitor circuit correctly indicates that it was used - admittedly sometimes a bit earlier or later than the hit piezo.
So in total I still think that the issue must be with the edrumulus code...
Also, with regards to #126 the plots look neither good for the sample counting of the rim switch open time nor for the second threshold method to discern the bell from the edge. :-(
Maybe the velocity of the hit also has to be taken into account somehow, idk. Or use the hit piezo ripple length, but I don't understand the electronic background for that atm and it makes the different rim input impedances pointless.
Maybe I'll go back to the original circuit...
from edrumulus.
corrados
commented on September 26, 2024
Maybe it is an issue with the internal pad trigger parameters. Maybe Edrumulus detects the main peak at the beginning of the burst:
BTW, you should use logarithmic voltage-axis to better visualize the dynamics of the signal.
from edrumulus.
3hhh
commented on September 26, 2024
On 12/20/23 07:21, Volker Fischer wrote:
Maybe it is an issue with the internal pad trigger parameters. Maybe Edrumulus detects the main peak at the beginning of the burst
Ok, I increased the scan time to 8ms and since then I obtain _some_ dynamics in the range of 70 to 127 on the MPS750x crash and ride. I still cannot obtain lower velocities though. In fact, if I move from the center of the pad to the rim at constant low velocity, I can get velocity 10-20 hits until I reach the rim - then it suddenly becomes a rim hit of velocity ~70. Any idea why?
The high scan time is only needed for rim hits - I guess I _sometimes_ (definitely not in my test above) hit the pad multiple times during a rim hit (once at the rim and possibly one more time at the regular piezo location - at least that way I appear to get better dynamics) and I guess those signals may come in at different points in time.
I haven't tested increasing the scan time with the Lemon hihat yet (it has the same issue).
from edrumulus.
3hhh
commented on September 26, 2024
I went back to the original voltage divider circuit with my parameters and I now have good cymbal rim dynamics for the MPS750x pads again. So apparently this issue was a byproduct of my capacitor circuit for the rim switch.
The Lemon hihat is still not perfect imo, but I'll look into that separately. Maybe the parameters could be chosen a bit differently.
from edrumulus.
Related Issues (20)
- Rim signals may be too strong for edrumulus HOT 13
- Teensy: High pins don't work HOT 1
- Hihat stomp is weak and cannot be mixed alone HOT 3
- Pos sensing only works with middle piezo HOT 8
- edrumulus_gui.py removes trigger settings, if killed HOT 2
- Cross talk cancellation doesn't work reliably HOT 10
- cymbal choke causes rim triggers HOT 6
- hihat pedal cross-talk HOT 20
- Unable to run edrumulus_gui.py on Windows HOT 19
- Add video to readme HOT 3
- Idea: Test edrumulus on x64 hardware
- Direct piezo hits sometimes cause a MIDI mute HOT 5
- Half-open hihat play tends to cause soft pedal stomps HOT 5
- edrumuluscontrol.m: add midi in/out labels HOT 2
- Is Prototype 2 still supported/recommended? (get_prototype_pins) HOT 3
- Floating signal on disconnected ports HOT 12
- Analog circuit HOT 6
- spike cancellation looks like a local parameter, but is a global one HOT 7
- Disconnecting a rimshot input makes regular hits become rimshots HOT 23
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edrumulus.