Comments (6)
Yes, this is true. I can see this with my Roland cymbal as well. But it is not noticeable during my normal playing.
The choke detection in Edrumulus is delayed a bit. Therefore, you will have a similar issue like you had with the cross-talk cancellation. The invalid detected strike will be there before the choke is detected.
Maybe you could try to suppress these MIDI notes with your Python script like you do with the cross-talk cancellation. Would be interesting to know if that works.
from edrumulus.
I just tested this with my Roland TD-27 and the Roland cymbal pad and I sometimes see exactly the same behavior as in Edrumulus, i.e., a Note On with MIDI note 49 is output on pressing the pad (choking it):
from edrumulus.
from edrumulus.
Would be interesting to know how your Millenium brain performs in this situation. Do you see similar effects?
from edrumulus.
This could partially be fixed via my script. Only partially as the first incorrect MIDI event happens ~10ms before the choke, the second ~5ms and I only want to delay events by at most 5ms, i.e. the first will continue to pass. In theory 10ms delay is supported though.
from edrumulus.
Btw increasing the sense time helped with this issue. However it caused worse rim detection, so that I dropped the change again.
from edrumulus.
Related Issues (20)
- Rim signals may be too strong for edrumulus HOT 13
- Teensy: High pins don't work HOT 1
- Hihat stomp is weak and cannot be mixed alone HOT 3
- Pos sensing only works with middle piezo HOT 8
- edrumulus_gui.py removes trigger settings, if killed HOT 2
- Cross talk cancellation doesn't work reliably HOT 10
- hihat pedal cross-talk HOT 20
- Unable to run edrumulus_gui.py on Windows HOT 19
- Add video to readme HOT 3
- Bad cymbal rim dynamics HOT 6
- Idea: Test edrumulus on x64 hardware
- Direct piezo hits sometimes cause a MIDI mute HOT 5
- Half-open hihat play tends to cause soft pedal stomps HOT 5
- Hihat bow play sometimes not working HOT 1
- Is Prototype 2 still supported/recommended? (get_prototype_pins) HOT 3
- Floating signal on disconnected ports HOT 12
- Analog circuit HOT 6
- spike cancellation looks like a local parameter, but is a global one HOT 7
- Disconnecting a rimshot input makes regular hits become rimshots HOT 23
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edrumulus.