Comments (6)
Change Manager: Confirmed that the issue exists.
from copilot.
Technical Lead: Confirmed that the issue should be addressed.
from copilot.
Technical Lead: Issue scheduled for fixing in Copilot 3.18.
Fix assigned to: @ivanperez-keera .
from copilot.
Implementor: Solution implemented, review requested.
from copilot.
Change Manager: Verified that:
- Solution is implemented:
-
The code proposed compiles and passes all tests. Details:
Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/267963797 -
The solution proposed produces the expected result. Details:
The following Dockerfile checks thatcopilot-theorem
's tests can be executed, in which case it prints the messageSuccess
:--- Dockerfile-verify-474 FROM ubuntu:focal RUN apt-get update RUN apt-get install --yes libz-dev RUN apt-get install --yes git RUN apt-get install --yes wget RUN mkdir -p $HOME/.ghcup/bin RUN wget https://downloads.haskell.org/~ghcup/0.1.19.2/x86_64-linux-ghcup-0.1.19.2 -O $HOME/.ghcup/bin/ghcup RUN chmod a+x $HOME/.ghcup/bin/ghcup ENV PATH=$PATH:/root/.ghcup/bin/ ENV PATH=$PATH:/root/.cabal/bin/ RUN apt-get install --yes curl RUN apt-get install --yes gcc make libgmp3-dev g++ SHELL ["/bin/bash", "-c"] RUN ghcup install ghc 9.4.7 RUN ghcup install cabal 3.8 RUN ghcup set ghc 9.4.7 RUN cabal update RUN apt-get install --yes z3 CMD git clone $REPO && \ cd $NAME && \ git checkout $COMMIT && \ cd copilot-theorem && \ cabal test copilot-theorem:unit-tests && \ echo Success
Command (adjust repo as necessary):
$ docker run -e "REPO=https://github.com/ivanperez-keera/copilot" -e "NAME=copilot" -e "COMMIT=e717ae2620bfd7cf8e2339addb74eb2c7e1f64ea" -it copilot-verify-474
-
- Implementation is documented. Details:
Change to tests. No changes to the public documentation are needed. Comments are added to all new modules and functions. - Change history is clear.
- Commit messages are clear.
- Changelogs are updated.
- Examples are updated. Details:
No updates needed. - Required version bumps are evaluated. Details:
Bump not needed. This is a change to the tests.
from copilot.
Change Manager: Implementation ready to be merged.
from copilot.
Related Issues (20)
- `copilot-language`: `Copilot.Language.Spec.forall` will be forbidden HOT 7
- `copilot-c99`: compiler warnings during tests HOT 10
- `copilot-c99`: compliance with MISRA C 2012 HOT 8
- `copilot-libraries`: Introduce testing infrastructure HOT 6
- `copilot`: Update README to reflect new contribution process
- `copilot-core`: record field `uTypeType` is unnecessary
- Release 3.18 HOT 6
- `copilot`: Extend range of versions `optparse-applicative` HOT 6
- `copilot-theorem`: Failure to compile with GHC 9.6.3 HOT 6
- Release 3.18.1 HOT 6
- `copilot-theorem`: `kind2Prover` gives parse error when disproving a property HOT 10
- ' ' is not a nondigit error HOT 4
- Formal methods with stateful functions HOT 4
- `copilot-core`: Remove deprecated functions in `Copilot.Core.Type` and `Copilot.Core.Type.Array` HOT 6
- `copilot-core`: Increase test coverage HOT 6
- Release 3.19 HOT 6
- `copilot-c99`: Can C99 generator declare stream functions as static? HOT 10
- Release 3.19.1 HOT 6
- `copilot-theorem`: Extend range of versions `what4` to include 1.6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from copilot.