Code Monkey home page Code Monkey logo

Comments (6)

ivanperez-keera avatar ivanperez-keera commented on August 24, 2024

Change Manager: Confirmed that the issue exists.

from copilot.

ivanperez-keera avatar ivanperez-keera commented on August 24, 2024

Technical Lead: Confirmed that the issue should be addressed.

from copilot.

ivanperez-keera avatar ivanperez-keera commented on August 24, 2024

Technical Lead: Issue scheduled for fixing in Copilot 3.19.

Fix assigned to: @ivanperez-keera .

from copilot.

ivanperez-keera avatar ivanperez-keera commented on August 24, 2024

Implementor: Solution implemented, review requested.

from copilot.

ivanperez-keera avatar ivanperez-keera commented on August 24, 2024

Change Manager: Verified that:

  • Solution is implemented:
    • The code proposed compiles and passes all tests. Details:
      Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/269344778
    • The solution proposed produces the expected result. Details:
      Evaluated by manual inspection. Running tests with coverage enabled achieves coverage of 97% for top-level definitions (37 out of 38 definitions). The one not tested is uTypeType, which cannot be tested due to being part of an existential type (it's necessity is being discussed in #484). The modules Copilot.Core.Operators and Copilot.Core.Spec and Copilot.Core.Expr only contain datatype definitions, so they do not need to be tested.
  • Implementation is documented. Details:
    New tests are documented.
  • Change history is clear.
  • Commit messages are clear.
  • Changelogs are updated.
  • Examples are updated. Details:
    No updates needed.
  • Required version bumps are evaluated. Details:
    Bump not needed. Changes affect tests only.

from copilot.

ivanperez-keera avatar ivanperez-keera commented on August 24, 2024

Change Manager: Implementation ready to be merged.

from copilot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.