Comments (6)
Change Manager: Confirmed version is ready to be released.
from copilot.
Technical Lead: Confirmed that the issue should be addressed.
from copilot.
Technical Lead: Issue scheduled for Copilot 3.19.1.
Fix assigned to: @ivanperez-keera.
from copilot.
Implementor: Solution implemented, review requested.
from copilot.
Change Manager: Verified that:
- Solution is implemented:
-
The code proposed compiles and passes all tests. Details:
Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/270361976 -
The solution proposed addresses the necessary modification to cabal packages. The following docker image installs copilot enforcing the new version via compiler constraints. It prints the message "Success" at the end if all completes correctly, and shows an error message otherwise.
FROM ubuntu:focal ENV DEBIAN_FRONTEND=noninteractive RUN apt-get update RUN apt-get install --yes libz-dev pkg-config RUN apt-get install --yes git RUN apt-get install --yes wget RUN mkdir -p $HOME/.ghcup/bin RUN wget https://downloads.haskell.org/~ghcup/0.1.17.7/x86_64-linux-ghcup-0.1.17.7 -O $HOME/.ghcup/bin/ghcup RUN chmod a+x $HOME/.ghcup/bin/ghcup ENV PATH=$PATH:/root/.ghcup/bin/ ENV PATH=$PATH:/root/.cabal/bin/ RUN apt-get install --yes curl RUN apt-get install --yes gcc g++ make libgmp3-dev RUN ghcup install ghc 9.6.3 RUN ghcup install cabal 3.4 RUN ghcup set ghc 9.6.3 RUN cabal update SHELL ["/bin/bash", "-c"] CMD git clone $REPO \ && cd $NAME \ && git checkout $COMMIT \ && cabal install --lib copilot**/ \ --constraint="copilot==3.19.1" \ --constraint="copilot-c99==3.19.1" \ --constraint="copilot-core==3.19.1" \ --constraint="copilot-prettyprinter==3.19.1" \ --constraint="copilot-interpreter==3.19.1" \ --constraint="copilot-language==3.19.1" \ --constraint="copilot-libraries==3.19.1" \ --constraint="copilot-theorem==3.19.1" \ && echo Success
Command (substitute variables based on new path after merge):
$ docker run -e "REPO=https://github.com/ivanperez-keera/copilot" -e "NAME=copilot" -e "COMMIT=3a2be02e232322d339b89a036787791dc3b61e8f" -it copilot-verify-512
-
- Implementation is documented. Details:
No changes to the documentation needed (change to fields in cabal). - Change history is clear.
- Commit messages are clear.
- Changelogs are updated.
- Examples are updated. Details:
No examples affected. - Required version bumps are evaluated. Details:
No bump needed (minor bump implemented by the change).
from copilot.
Change Manager: Implementation ready to be merged.
from copilot.
Related Issues (20)
- `copilot-core`: record field `uTypeType` is unnecessary
- Release 3.18 HOT 6
- `copilot`: Extend range of versions `optparse-applicative` HOT 6
- `copilot-theorem`: Failure to compile with GHC 9.6.3 HOT 6
- Release 3.18.1 HOT 6
- `copilot-theorem`: `kind2Prover` gives parse error when disproving a property HOT 10
- ' ' is not a nondigit error HOT 4
- Formal methods with stateful functions HOT 4
- `copilot-core`: Remove deprecated functions in `Copilot.Core.Type` and `Copilot.Core.Type.Array` HOT 6
- `copilot-core`: Increase test coverage HOT 6
- Release 3.19 HOT 6
- `copilot-c99`: Can C99 generator declare stream functions as static? HOT 12
- `copilot-theorem`: Extend range of versions `what4` to include 1.6 HOT 7
- `copilot-language`: Remove deprecated function `Copilot.Language.Spec.forall` HOT 6
- `copilot-language`: Support modifying fields of structs HOT 6
- Release 3.20 HOT 6
- `copilot-theorem`: Support translating struct updates to `what4` HOT 5
- `copilot-core`: Add documentation for `updateField` describing how (and why) to implement it
- `copilot-prettyprinter`: Support pretty-printing struct updates HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from copilot.