Indra can contain all the sub-repos simply as directories, this makes deployment much easier and reduces the amount of places things need to be duplicated.

We need a pre-commit hook that checks if the hub has local client changes that the client module does not. If so, block commit.

Expected Behavior

Should be able to pay users who don't have channels open

Current Behavior

Collateralization for tipping breaks

Steps to Reproduce (for bugs)

1. Start Indra hub.
2. Load up wallet UI (http://localhost).
3. Get 1 token from MetaMask (make sure MetaMask is set to the Ganache [0] address, since that's the only one that has the tokens).
4. Deposit some amount of tokens.
5. Attempt to pay user who hasn't opened a channel and deposited

Should take an optional fee parameter, and wrap the buy controller's functionality. The optional fee will come from outside of the thread balance, and that should be reflected in the algorithm for floor of collateral when creating threads and displayed/operational balances.

Should make sure that the collateral is managed appropriately with thread opening and closing in the "bouncer"

Expected Behavior

Right now we only withdraw ETH, with an exchange. We need to be able to withdraw tokens as well.

Current Behavior

Withdraw exchanges tokens into ETH based on the exchange rate.

Possible Solution

I think everything exists to make this happen, we just need to pass in the correct parameters.

Having an issue starting up a Hub using the instructions in the Readme. This is on Debian 9.

Followed the Readme steps to the letter. Ganache is running fine at the same time.

#truffle migrate --reset --network development
ReferenceError: account is not defined
    at Object.<anonymous> (/root/Indra/truffle.js:19:13)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Function.Config.load (/usr/lib/node_modules/truffle/build/webpack:/packages/truffle-config/index.js:254:1)
    at Function.Config.detect (/usr/lib/node_modules/truffle/build/webpack:/packages/truffle-config/index.js:243:1)
    at Object.run (/usr/lib/node_modules/truffle/build/webpack:/packages/truffle-core/lib/commands/migrate.js:35:1)
    at Command.run (/usr/lib/node_modules/truffle/build/webpack:/packages/truffle-core/lib/command.js:101:1)
    at Object.<anonymous> (/usr/lib/node_modules/truffle/build/webpack:/packages/truffle-core/cli.js:22:1)
    at __webpack_require__ (/usr/lib/node_modules/truffle/build/webpack:/webpack/bootstrap b393854eec71a4a28b46:19:1)
    at /usr/lib/node_modules/truffle/build/webpack:/webpack/bootstrap b393854eec71a4a28b46:65:1
    at Object.<anonymous> (/usr/lib/node_modules/truffle/build/cli.bundled.js:71:10)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Function.Module.runMain (module.js:694:10)
    at startup (bootstrap_node.js:204:16)
    at bootstrap_node.js:625:3

Seems that despite trying to use the development configuration the lack of a defined account in truffle.js is causing the error:

    ropsten: {
      host: "127.0.0.1",
      port: 8545,
      network_id: "3",
      from: account,
      gas: 4700000
    },

Removing the from: account, line fixes the error.

Wallet is currently using the NPM version of the Connext package. This is probably okay for now, but we may want to have yalc or some way to dev with a local client.

Expected Behavior

A script should take the code from the wallet module in Indra and copy it to Payment Starter Kit

Context

Versioning issues are arising between PSK and the wallet in indra. We should develop in one place and then pull into the other on a regular basis.

Automatically deposit balances associated with signing address into the channel. This functionality should be run on a poller, much like in existing AddressBalanceController

The Readme example has ganache using port 8545, but the development network in truffle.js uses port 9545.

Need to update either the Readme example (ganache ... -p 9545) or truffle.js to use the same port.

Expected Behavior

After deposit, I should receive confirmPending status and then the transaction should get confirmed, and funds should show up in the channel.

Current Behavior

When I deposit, i get a proposependingdeposit back, everything gets signed correctly, the console tells me the update was sent to chain. But nothing shows up in chainsaw, I don't get confirmPending, then eventually it times out and nothing ever gets deposited to channel.

Sending userAuthorizedUpdate to 0x9fbda871d559710256a2502a2517b794b482db40: in mempool: 0x1001f5856382df053221a5b8ae06511135d315113b012dfdf68438e094143038

Steps to Reproduce (for bugs)

1. Launch indra from branch UI-flow
2. Deposit ETH

Context

Trying to bundle some actions together to improve UX.

Expected Behavior

Tokens should correctly deposit without depositing ETH.

Current Behavior

Console shows ProposePending is generated and sent to hub, but the userAuthorizedDeposit does not happen on chain.

Possible Solution

Not sure why the deposit isn't happening, everything works if you deposit ETH too.

Steps to Reproduce (for bugs)

1. Start Indra hub.
2. Load up wallet UI (http://localhost).
3. Get 1 token from MetaMask (make sure MetaMask is set to the Ganache [0] address, since that's the only one that has the tokens).
4. Deposit some amount of tokens and 0 ETH.

Context

Demo needs to work end to end.

Your Environment

• Version used: Latest
• Browser Name and version: Chrome
• Operating System and version (desktop or mobile): MacOS
• Link to your project: This repo.

All tests, and any requisite updates. Also includes any internal peer reviews, code walkthroughs, requisite updates. External audits should be in process as well. See here for the full test spec.

Test case for requires in contract verified. Here is full test spec to verify. Include:

• final balance always increases recipient balance on closeThread
• cannot open channel with contract

Make sure the threads work for:

• ArgsTypes
• Overloads
• Conversions
• SyncResults

The following changes still need to be made in order to allow the hub to handle threads

• Collateralization algorithm needs to be tweaked (@rhlsthrm what needs to happen here?)
• Add a tunable fee on each payment. Thread updates should be rejected if they don't include fee.

Expected Behavior

Should be able to pay tokens and eth directly to a metamask account that has no channel open

Current Behavior

Can only pay counterparties with channels

Make auth function in the client so that it can make calls to the hub. This should happen on a poller when the appropriate AuthController.

User should be able to send a noncustodial P2P payment

Includes any updates relevant to:

• Client code
• Contracts
• Database schema/migrations
• Chainsaw
• Any business logic (i.e. collateralization)

Heuristic will be as follows:

On deposit:

• Check if 10FIN in browser wallet
• If not, deposit up to 40FIN + desired deposit

On balance poller:

• Do not deposit if under 40FIN
• Deposit everything above 40FIN

Expected Behavior

Manually clicking through channel operations after every code change is tedious and lazy people like me tend to just not do it.

We need an automated way to test the wallet's logic and it's interactions with the hub code.

Given my painful experiences writing selenium-based e2e tests, I'm going to suggest we explore Cypress as an alternative first before trying to incorporate the traditional e2e test stack.

Run npm install cypress and then figure it out from there

Prune all old DB tables and add necessary pieces for threads.

Steps to Reproduce (for bugs)

1. Type a number in the ETH section
2. Switch to tokens and change the already incorrect value
3. Switch back to ETH

Updates to make sure not all payments happen in channel.

Should reflect configurable "fee" on per-payment basis

Expected Behavior

Users should be able to use metamask rather than the browser wallet to interact with their channel

Current Behavior

Sample payment UX defaults to browser wallet (done this way so that autosigning works)

Possible Solution

Need toggle that lets users instantiate the client with metamask's web3 injection rather than the custom one

We need to be able to run the individual modules (hub, chainsaw, ethprovider) locally without Docker.

Turns out we do need to see the address, since that's where the counterparty would send you money and right now it only shows up in the console. We should add a display somewhere.

Expected Behavior

Depositing into channel from metamask using the deposit button is broken.

Current Behavior

Does not allow for ETH deposits, or token deposits to channel from metamask. Currently, metamask will say the transaction failed, while there is no indication of that in the application.

Low level contract dispute wrapper functions implemented within the client

Maybe we should block token deposit if the onchain ETH balance of the signer is 0?

Expected Behavior

Hub operator should have option to let users pay gas costs

Current Behavior

Hub pays all gas costs

Chainsaw needs to conditionally handle disputes if it catches a dispute event.

• Channel dispute events
• Thread dispute events
• Tests for above

Pseudocode for this can be found in attached code snippet

https://app.zenhub.com/files/151768617/843eb475-8af4-491c-b08b-c6a2c10c39e7/download

Mirror the pipeline Spank uses. We should have a staging deployment that deploys to Rinkeby and a production deployment that deploys to mainnet.

Sometimes when you click create new autosigner, it defaults back to the previous one. This behavior hasn't been consistent for me, so I'll dig deeper.

I want to see onchain channel balance so I can see if there is any ETH in the browser wallet (i.e. for token deposits).

Camsite repo got some updates to structure things into migrations. We need to implement this in Indra.

Should include

• Validator, Utils, and StateGenerator updates
• Controller updates
• Any wrapper updates

• Remove timeout check in thread verification
• Add address checks for the parties in thread state
• Verify recipient balance increases at every opportunity

Work with Lex to figure out how to make it build and deploy into the cloud.

Expected Behavior

After resetting auto signer, it should pop up a better message than "You have an autosigner set up already! You can either use it, recover an old one, or set up an entirely new one.". This behavior is confusing, since I just reset so I want to use the existing one but that's not clear.

Current Behavior

Described above.

Possible Solution

Maybe you can add a storage state like resetHappened so on the next reload it defaults to the signer it just created?

Steps to Reproduce (for bugs)

1. Choose "Select Signer"
2. Choose "Autosigner"
3. Choose "Create New Signer"
4. Wait for page reload.

Expected Behavior

Hub should be able to unilaterally close disputes, client should handle this appropriately and recover channel as needed.

Context

Allows hub to reclaim collateral from offline users unilaterally.

We are seeing a variety of yarn related issues mostly from running yarn start. Some of the errors we have seen include:

warning machinomy > @types/[email protected]: This is a stub types definition for commander (https://github.com/tj/commander.js). commander provides its own type definitions, so you don't need @types/commander installed!
warning machinomy > @machinomy/contracts > @machinomy/hdwallet-provider > web3-provider-engine > ethereumjs-block > merkle-patricia-tree > level-ws > xtend > [email protected]:
[2/4] Fetching packages...
[3/4] Linking dependencies...
error An unexpected error occurred: "ENOENT: no such file or directory, lstat '/root/.cache/yarn/v4/npm-@machinomy-hdwallet-provider-1.3.1-a7ecf4b70dfb1f59d550856b8e1884ac0ff6591f/node_modules/@machinomy/hdwallet-provider/

=============
[Makefile] => Start building hub-node-modules
docker run --name=connext_buidler --tty --rm --user 501:20 --volume=/Users/rahul/Desktop/connext/connext/indra/modules/hub:/root connext_builder:dev 501:20 "yarn install --network-timeout 1000000"
Running command as user 501:20
yarn install v1.12.3
info No lockfile found.
[1/4] Resolving packages...
warning connext > web3 > web3-bzz > swarm-js > [email protected]: Use mz or fs-extra^3.0 with Promise Support
warning connext > web3 > web3-bzz > swarm-js > [email protected]: ⚠️  WARNING ⚠️ tar.gz module has been deprecated and your application is vulnerable. Please use tar module instead: https://npmjs.com/tar
warning machinomy > @types/[email protected]: This is a stub types definition for commander (https://github.com/tj/commander.js). commander provides its own type definitions, so you don't need @types/commander installed!
error Received malformed response from registry for "mocha". The registry may be down.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Same user, skipping permission fix
make: *** [hub-node-modules] Error 1
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[2/4] Fetching packages...
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error https://registry.yarnpkg.com/scrypt.js/-/scrypt.js-0.2.1.tgz: Extracting tar content of undefined failed, the file appears to be corrupt: "EEXIST: file already exists, mkdir '/root/.cache/yarn/v4/npm-scrypt-js-0.2.1-cc3f751933d6bac7a4bedf5301d7596e8146cdcd/node_modules/scrypt.js'"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Same user, skipping permission fix
make: *** [hub-node-modules] Error 1
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

The errors appear intermittent and some combination of purging, clearing yarn cache, and simply retrying makes them go away usually. However, this is an annoying issue and needs to be addressed.

Import the snapshot-create and snapshot-restore scripts from the camsite hub & make sure they work in the indra env.

Expected Behavior

When I click "Reveal Browser Wallet Mnemonic" in the wallet UX, it should reveal the 12-word recovery phrase.

Current Behavior

I click and nothing happens, although the console registers that getKey() was called. It's possible that this is a weird issue with my web3 injection rather than the function, but we should take a look.

Possible Solution

Steps to Reproduce (for bugs)

1. Start Indra
2. navigate to localhost
3. click "reveal browser wallet mnemonic" under Wallet utilities

Thread statuses should be enforced off chain, reflective of the types used by the hub

Verify channel statuses in the controllers of the client

Fix error message in line 401 in validator.ts

We should make the UI for the wallet a little cleaner prior to demoing it further. UI mockups coming here soon.

This one's high priority so that we can get it out asap.