Comments (11)
Awesome, starting on the signer flow now. Update on where the rest of things stand (lots of fiddly css things to go, but most of the pieces are in place):
from indra.
from indra.
@ArjunBhuptani in the above diagram:
- What's the function of the
reselect signer
button? - Do you think we need to have something for the user to see browser wallet mnemonic? Or if everything sent to the wallet just gets automatically deposited, it's probably a moot point..
from indra.
@hthillman I think we need the browser wallet mnemonic. We will eventually need a "recover from mnemonic" function as well.
from indra.
Oh sorry. There should be multiple screens here. Onload, it should popup with a modal that has you choose your signer. Either you choose metamask or the browser. If the latter, it creates a browser wallet, shows you the mnemonic and then you hit accept and it takes you to the normal page.
reselect signer
is effectively the same as "create a new browser wallet" except it gives you the option of having metamask be your signer instead (obviously this would now be a new channel so maybe that's going to be an issue here?)
In general, I want to get rid of the "browser wallet" terminology and just have user choose a signer
from indra.
Showing the mnemonic is still necessary even if everything gets deposited immediately (which it should). You need it in order to recover funds in your channel if you lose your signer.
However, we can follow traditional best practices here and only show the mnemonic upon creation instead of always.
from indra.
Gonna thing through colors some more tomorrow and get back to you on those
from indra.
Looks awesome!! We should figure out how to make the channel info pop a bit more since that's the most important stuff to watch.
Can you align the wallet info to the right of the Withdraw component? i.e. have the top components and the bottom component the same width
from indra.
Tomorrow, I'll also write up the text that goes in the tooltips
from indra.
Yep, will do. I wrote some placeholder tooltip text but it could use some work.
from indra.
Remaining todos
- merge in the most recent hub/client code (high priority)
- make it work end to end (high priority)
- get wallet recovery working
- add wallet recovery/key entry functionality (medium priority)
- add buttons for collateralization and reselecting signer (medium priority--collateralization will be very easy, reselecting signer will probably take a lil more work)
- mnemonic not showing up on getKey (medium priority, after adding recovery functionality) . #38
- fiddly css stuff, colors, spacing etc (low priority)
from indra.
Related Issues (20)
- [Apps] Allow passing in string data input to SignedTransferApp
- [DevOps] Set up cloudflare w/ DDOS protection for instances HOT 1
- [client, node] Robustness around withdrawals HOT 3
- [watcher] Multichain enabled
- [client] Registry Apps
- do not install transfer apps when client receives 60 sec timeout error HOT 2
- USDT transfers and withdrawals don't work HOT 2
- [node] add prometheus queries for balance monitoring HOT 2
- [client] Allow injected middleware
- [All] Pino for Logging HOT 1
- [node] Admin function to uninstall deposit apps
- [client/node] Restore broken for certain states HOT 1
- [node] Support multiple ERC20s and swaps
- Pre-Collateralization HOT 1
- [Node] Deposit app gets stuck for async transfers
- [watcher] performance concerns & final wrap up
- [node] Add appIdentityHash to response of getHashlockTransferStatus
- [node] Separate offline and online transfers
- [node] if client supplies collateralization amount, use amount, else use target
- Ask for the https://github.com/connext/indra/issues
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from indra.