Comments (21)
Looks good!
Would definitely appreciate a bit more description about the assays that are described in more detail in the notebooks. Think of yourself as a potential user looking to try to figure out if these examples are the most similar to what you are trying to do: what would you want to see?
from assaytools.
Or... should we not have data in this repository at all? Just have a bare minimum for tests? We were planning on putting all the raw data for the manuscript in the manuscript repository anyway...
from assaytools.
Here's my thinking:
assaytools
should only contain (1) example data to illustrate how to use each capability, and (2) test data for us to include in nosetests.- All other data for a paper should be in a repository specific for that paper.
from assaytools.
I think this sounds reasonable, will shift to working in the manuscript repo for the datasets relevant to that. We can revisit if this becomes stranger than expected.
from assaytools.
I'm guessing we want to keep the files in data/full_example/
, but maybe move everything to the examples
directory. Maybe you can do this in your PR @jchodera ?
from assaytools.
So after discussing with @MehtapIsik, it seems like it is a good idea to make a new branch, e.g. assaytools/July2016
that could keep all the data and notebooks relatively as is, while we work on cleaning up the master branch. In the master branch we will remove/clean up any raw data and notebooks that don't serve as a minimal example.
from assaytools.
I copied all HSA experimental data in examples/.../hsa folder to organize it under another repository (hsa-affinity).
from assaytools.
I'm guessing we want to keep the files in data/full_example/, but maybe move everything to the examples directory. Maybe you can do this in your PR @jchodera ?
Let's leave this for now since I use that data in my new implementation. We can clean it up next week.
So after discussing with @MehtapIsik, it seems like it is a good idea to make a new branch, e.g. assaytools/July2016 that could keep all the data and notebooks relatively as is, while we work on cleaning up the master branch. In the master branch we will remove/clean up any raw data and notebooks that don't serve as a minimal example.
Sounds great!
from assaytools.
Great Mehtap! thanks!
from assaytools.
Just had a quick meeting with @MehtapIsik where we mapped out a better organization for the examples
directory (among other things):
autoprotocol
data
- ~four python scripts
probe assay
data
- ~three ipynb's
- modeling
- MLE
- simple bayes model
- README also describes how to use
xml2png
andquickmodel
for this data
competition assay
data
- ~three ipynb's
- modeling
- MLE
- simple bayes model
- README also describes how to use
xml2png
andquickmodel
for this data
Also note, according to the discussion above the plan is to completely delete the data
directory.
Also planning to make a branch that will just be the repo as it currently is called 'Nov2016'.
from assaytools.
Sounds good!
from assaytools.
Branch now made: https://github.com/choderalab/assaytools/tree/Nov2016
from assaytools.
@jchodera do you have any opinion about whether this notebook stays: https://github.com/choderalab/assaytools/blob/master/examples/ipynbs/models/competition-assay-modeling/competition-assay-modeling.ipynb
from assaytools.
What if we move it to https://github.com/choderalab/fluorescence-assay-manuscript in case we use a derivative of it to model some fluorescence assays?
from assaytools.
if we use a derivative to model fluorescence assays we can just include that no?
from assaytools.
Do you have it somewhere else? I feel like maybe it is?
from assaytools.
I don't believe there is a copy somewhere else.
Since it's not an example of analyzing an experimental assay, I think we should add it to https://github.com/choderalab/fluorescence-assay-manuscript, perhaps under a notebooks/
or modeling/
or figures/
directory, and delete it from here.
from assaytools.
I think it makes less sense in fluorescence-assay-manuscript
than here, I will just keep it here.
from assaytools.
I have a derivative that I have used in the passed, and will add here when we get something going for the simpler competition assay prediction. If these two notebooks are redundant, we can delete one.
from assaytools.
Our fluorescence assay manuscript outline contains a figure on modeling the competition assay, so I thought it was much more relevant to have this there---where we actually need to make figures depicting a modeled competition assay---than in this repo, which contains examples of real data and scripts/notebooks to analyze them. But I'm happy with whatever you think is best!
from assaytools.
We have both the modeling and analysis here right now, and I think this makes sense for testing our methods. What do you think of this: https://github.com/choderalab/assaytools/tree/data_clean/examples/probe-assay ? We can add more description in the readme about what actually happens in these notebooks:
from assaytools.
Related Issues (20)
- Could we just set a slightly more restrictive prior on F_PL? HOT 1
- Missing dependencies HOT 4
- Cut a new assaytools release HOT 2
- Fix win install HOT 1
- Make better error message when using wrong path in quickmodel inputs file.
- Travis build failing - libgfortran related? HOT 5
- Deprecate assaytools-dev package HOT 3
- Travis is still broken HOT 1
- Clean up old branches
- Make Docs clearer for General Binding Model
- Integrate scripts/ into installed codebase and use entry-points instead
- Analysis for the single-well titration experiment HOT 2
- getting error in assaytools parser.py when running quickmodel HOT 9
- xml2png python 3.6 travis tests are failing HOT 1
- security alert for pyyaml dependency HOT 2
- Adding Quickmodel script the option to use informed F_PL priors HOT 1
- New release? HOT 1
- Add new `GeneralBindingModel` API that accepts/returns concentrations instead of log concentrations
- Getting print out of 'Skipping analysis of rows: []' for each protein from parser.py when running quickmodel HOT 3
- how to omit a well from analysis?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from assaytools.