Code Monkey home page Code Monkey logo

Comments (21)

jchodera avatar jchodera commented on June 12, 2024 1

Looks good!

Would definitely appreciate a bit more description about the assays that are described in more detail in the notebooks. Think of yourself as a potential user looking to try to figure out if these examples are the most similar to what you are trying to do: what would you want to see?

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

Or... should we not have data in this repository at all? Just have a bare minimum for tests? We were planning on putting all the raw data for the manuscript in the manuscript repository anyway...

from assaytools.

jchodera avatar jchodera commented on June 12, 2024

Here's my thinking:

  • assaytools should only contain (1) example data to illustrate how to use each capability, and (2) test data for us to include in nosetests.
  • All other data for a paper should be in a repository specific for that paper.

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

I think this sounds reasonable, will shift to working in the manuscript repo for the datasets relevant to that. We can revisit if this becomes stranger than expected.

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

I'm guessing we want to keep the files in data/full_example/, but maybe move everything to the examples directory. Maybe you can do this in your PR @jchodera ?

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

So after discussing with @MehtapIsik, it seems like it is a good idea to make a new branch, e.g. assaytools/July2016 that could keep all the data and notebooks relatively as is, while we work on cleaning up the master branch. In the master branch we will remove/clean up any raw data and notebooks that don't serve as a minimal example.

from assaytools.

MehtapIsik avatar MehtapIsik commented on June 12, 2024

I copied all HSA experimental data in examples/.../hsa folder to organize it under another repository (hsa-affinity).

from assaytools.

jchodera avatar jchodera commented on June 12, 2024

I'm guessing we want to keep the files in data/full_example/, but maybe move everything to the examples directory. Maybe you can do this in your PR @jchodera ?

Let's leave this for now since I use that data in my new implementation. We can clean it up next week.

So after discussing with @MehtapIsik, it seems like it is a good idea to make a new branch, e.g. assaytools/July2016 that could keep all the data and notebooks relatively as is, while we work on cleaning up the master branch. In the master branch we will remove/clean up any raw data and notebooks that don't serve as a minimal example.

Sounds great!

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

Great Mehtap! thanks!

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

Just had a quick meeting with @MehtapIsik where we mapped out a better organization for the examples directory (among other things):

  • autoprotocol
    • data
    • ~four python scripts
  • probe assay
    • data
    • ~three ipynb's
      • modeling
      • MLE
      • simple bayes model
      • README also describes how to use xml2png and quickmodel for this data
  • competition assay
    • data
    • ~three ipynb's
      • modeling
      • MLE
      • simple bayes model
      • README also describes how to use xml2png and quickmodel for this data

Also note, according to the discussion above the plan is to completely delete the data directory.

Also planning to make a branch that will just be the repo as it currently is called 'Nov2016'.

from assaytools.

jchodera avatar jchodera commented on June 12, 2024

Sounds good!

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

Branch now made: https://github.com/choderalab/assaytools/tree/Nov2016

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

@jchodera do you have any opinion about whether this notebook stays: https://github.com/choderalab/assaytools/blob/master/examples/ipynbs/models/competition-assay-modeling/competition-assay-modeling.ipynb

from assaytools.

jchodera avatar jchodera commented on June 12, 2024

What if we move it to https://github.com/choderalab/fluorescence-assay-manuscript in case we use a derivative of it to model some fluorescence assays?

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

if we use a derivative to model fluorescence assays we can just include that no?

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

Do you have it somewhere else? I feel like maybe it is?

from assaytools.

jchodera avatar jchodera commented on June 12, 2024

I don't believe there is a copy somewhere else.

Since it's not an example of analyzing an experimental assay, I think we should add it to https://github.com/choderalab/fluorescence-assay-manuscript, perhaps under a notebooks/ or modeling/ or figures/ directory, and delete it from here.

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

I think it makes less sense in fluorescence-assay-manuscript than here, I will just keep it here.

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

I have a derivative that I have used in the passed, and will add here when we get something going for the simpler competition assay prediction. If these two notebooks are redundant, we can delete one.

from assaytools.

jchodera avatar jchodera commented on June 12, 2024

Our fluorescence assay manuscript outline contains a figure on modeling the competition assay, so I thought it was much more relevant to have this there---where we actually need to make figures depicting a modeled competition assay---than in this repo, which contains examples of real data and scripts/notebooks to analyze them. But I'm happy with whatever you think is best!

from assaytools.

sonyahanson avatar sonyahanson commented on June 12, 2024

We have both the modeling and analysis here right now, and I think this makes sense for testing our methods. What do you think of this: https://github.com/choderalab/assaytools/tree/data_clean/examples/probe-assay ? We can add more description in the readme about what actually happens in these notebooks:

from assaytools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.