chevyray / math Goto Github PK

So, I was doing the thing where I idly skim peoples public code, even if the repo is probably not actually intended for public use^[1].

Anyway, I noticed a few some copypasta that might take you a while to track down^[2], so I felt that I should mention them to save you the headache:

• https://github.com/ChevyRay/math/blob/main/src/vec3.rs#L113 (z should be floored, not abs-ed)
• https://github.com/ChevyRay/math/blob/main/src/vec4.rs#L84-L92 (same kind of thing, but also for the other function)

I didn't look very hard, so if I were in your shoes I'd do a quick skim for similar issues, but your call either way. Hope this helps.

[1]: That is, I'm aware this isn't actually a library people are supposed to use. Utility code is sometimes fun to read (for me), and you occasionally pick up some tricks by skimming. (I don't particularly care if you fix this issue or not, I'm just reporting it to be helpful)

[2]: That is to say: they'd probably take me a while to track down... the issue seems likely to be pretty subtle — e.g. a element doesn't actually get floored, and (probably — assuming it's positive) just stays as-is... lots of times this would be hard to notice.