Describe the bug Commands added to the keyframes in behavior pack

Yes, there are other extensions besides Blockception. Though they're mainly used

If you want the output log here you go. I hope this helps! <div class="snippet-cli

Commands in server-side animations are causing errors about vscode-bedrock-development-extension HOT 6 CLOSED

r4isen1920 commented on July 23, 2024

Commands in server-side animations are causing errors

from vscode-bedrock-development-extension.

Comments (6)

DaanV2 commented on July 23, 2024

I cannot seem to reproduce this; the schema allows for this and have for a long time.

@r4isen1920 Can you check the following:

Are they any other extensions active?
What are the errors/warnings?

from vscode-bedrock-development-extension.

r4isen1920 commented on July 23, 2024

Yes, there are other extensions besides Blockception. Though they're mainly used for debugging and using other languages such as Python extensions, Git/file management, formatting and themes extensions.
The error/warnings shown are as follows:

Additional context:
I do have JSON schemas also pre-applied manually by myself on the built-in VSCode settings:

{
  "json.schemas": [
    {
      "fileMatch": ["/manifest.json"],
      "url": "https://bedrock-studio.github.io/bedrock-json-schemas/manifest.json"
    },
    {
      "fileMatch": [
        "/*.animation_controllers.json",
        "/*.controller_animation.json"
      ],
      "url": "https://bedrock-studio.github.io/bedrock-json-schemas/animation_controller.json"
    },
    {
      "fileMatch": ["/*.animation.json"],
      "url": "https://bedrock-studio.github.io/bedrock-json-schemas/animation.json"
    },
    {
      "fileMatch": ["/*.entity.json"],
      "url": "https://bedrock-studio.github.io/bedrock-json-schemas/actor_resource_definition.json"
    },
    {
      "fileMatch": ["/attachables/*.json"],
      "url": "https://bedrock-studio.github.io/bedrock-json-schemas/actor_resource_definition.json"
    },
    {
      "fileMatch": ["/*.render_controllers.json"],
      "url": "https://bedrock-studio.github.io/bedrock-json-schemas/render_controller.json"
    },
    {
      "fileMatch": ["/models/mobs.json", "/*.geo.json"],
      "url": "https://bedrock-studio.github.io/bedrock-json-schemas/geometry.json"
    }
  ]
}

Removing the schemas doesn't seem to have any effect either. Thought they'd overwritten the schemas applied on the settings perhaps.

from vscode-bedrock-development-extension.

r4isen1920 commented on July 23, 2024

If you want the output log here you go. I hope this helps!

	starting minecraft server
[Info  - 12:22:12 AM] Initializing minecraft server
[Info  - 12:22:12 AM] 	Version: 5.0.12
	Initialized minecraft server
[Info  - 12:22:12 AM] Traversing starting...
[Info  - 12:22:12 AM] Reseting database
[Info  - 12:22:12 AM] Updating settings
[Info  - 12:22:12 AM] Traversing workspace: c:\Users\Raisen\AppData\Local\Packages\Microsoft.MinecraftUWP_8wekyb3d8bbwe\LocalState\games\com.mojang\development_resource_packs\nextbots-run-rp
[Info  - 12:22:12 AM] Starting: Code action
[Info  - 12:22:12 AM] Completed: Code action
[Info  - 12:22:12 AM] Processing pack: c:\Users\Raisen\AppData\Local\Packages\Microsoft.MinecraftUWP_8wekyb3d8bbwe\LocalState\games\com.mojang\development_resource_packs\nextbots-run-rp
[Info  - 12:22:12 AM] Starting: Code action
[Info  - 12:22:12 AM] Completed: Code action
[Info  - 12:22:12 AM] Starting: Code action
[Info  - 12:22:12 AM] Completed: Code action
[Info  - 12:22:12 AM] Traversing workspace: c:\Users\Raisen\AppData\Local\Packages\Microsoft.MinecraftUWP_8wekyb3d8bbwe\LocalState\games\com.mojang\development_behavior_packs\nextbots-run-bp
[Info  - 12:22:12 AM] Updating settings
[Info  - 12:22:12 AM] Processing pack: c:\Users\Raisen\AppData\Local\Packages\Microsoft.MinecraftUWP_8wekyb3d8bbwe\LocalState\games\com.mojang\development_behavior_packs\nextbots-run-bp
[Info  - 12:22:12 AM] Updating settings
[Info  - 12:22:13 AM] Starting: Code Lens
[Info  - 12:22:13 AM] Completed: Code Lens
[Info  - 12:22:13 AM] Starting: Code action
[Info  - 12:22:13 AM] Completed: Code action
[Info  - 12:22:13 AM] Updating settings
[Info  - 12:22:13 AM] Starting: Code action
[Info  - 12:22:13 AM] Completed: Code action
[Info  - 12:22:13 AM] Starting: Symbols, Document
[Info  - 12:22:13 AM] Completed: Symbols, Document
[Error - 12:22:13 AM] Request textDocument/documentSymbol failed.
Error: name must not be falsy
	at i.validate (c:\Users\Raisen\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:94:25449)
	at new i (c:\Users\Raisen\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:94:25687)
	at B (c:\Users\Raisen\.vscode\extensions\blockceptionltd.blockceptionvscodeminecraftbedrockdevelopmentextension-5.1.0\client\out\extension.js:1:281257)
	at p (c:\Users\Raisen\.vscode\extensions\blockceptionltd.blockceptionvscodeminecraftbedrockdevelopmentextension-5.1.0\client\out\extension.js:1:147897)
	at t.map (c:\Users\Raisen\.vscode\extensions\blockceptionltd.blockceptionvscodeminecraftbedrockdevelopmentextension-5.1.0\client\out\extension.js:1:147983)
	at Object.asSymbolInformations (c:\Users\Raisen\.vscode\extensions\blockceptionltd.blockceptionvscodeminecraftbedrockdevelopmentextension-5.1.0\client\out\extension.js:1:289126)
	at o (c:\Users\Raisen\.vscode\extensions\blockceptionltd.blockceptionvscodeminecraftbedrockdevelopmentextension-5.1.0\client\out\extension.js:1:113755)
	at async n.provideDocumentSymbols (c:\Users\Raisen\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:98:32515)
[Info  - 12:22:13 AM] Traversing complete
[Info  - 12:22:13 AM] Diagnosing pack: c:\Users\Raisen\AppData\Local\Packages\Microsoft.MinecraftUWP_8wekyb3d8bbwe\LocalState\games\com.mojang\development_resource_packs\nextbots-run-rp
[Info  - 12:22:13 AM] Starting: Code Lens
[Info  - 12:22:13 AM] Completed: Code Lens
[Info  - 12:22:13 AM] Diagnosing pack: c:\Users\Raisen\AppData\Local\Packages\Microsoft.MinecraftUWP_8wekyb3d8bbwe\LocalState\games\com.mojang\development_behavior_packs\nextbots-run-bp
[Info  - 12:22:14 AM] Diagnostics completed
[Info  - 12:22:14 AM] Took: 0:1:879 for 938 items
[Info  - 12:22:17 AM] Updating settings
[Info  - 12:22:37 AM] Starting: Code action
[Info  - 12:22:37 AM] Completed: Code action
[Info  - 12:22:46 AM] Starting: Code action
[Info  - 12:22:46 AM] Completed: Code action
[Info  - 12:22:47 AM] Starting: Code action
[Info  - 12:22:47 AM] Completed: Code action
[Info  - 12:22:47 AM] Starting: Code Lens
[Info  - 12:22:47 AM] Completed: Code Lens
[Info  - 12:24:38 AM] Starting: Code Lens
[Info  - 12:24:38 AM] Completed: Code Lens

from vscode-bedrock-development-extension.

r4isen1920 commented on July 23, 2024

Interesting, based on some few testing, here's what I found out: So I have my files in the BP animations named in this format: *.animation.json. Maybe it's applying RP animations schemas instead of the BP animations.

This could be fairly quite confusing. We each have our own unique ways of formatting things. If possible, the file should be checked with the context of where it is located, not simply how it is named. Perhaps you can base that off from the pack manifest file.

from vscode-bedrock-development-extension.

r4isen1920 commented on July 23, 2024

A bit off-topic, but I would hope to have these simple schemas adjusted properly. I hate seeing red errors when there shouldn't be. The extension is overall good, but I hope there is a more lightweight version I can use where it doesn't diagnose even the simplest of stuff - and leave it as is.

I'm all in for the auto-completion, code lens, and those good stuff - honestly make things much easier and I wont have to go back and forth the documentation and VSCode.

For instance, I'm clicking on this "quick fix" but it doesn't really seem to do anything. 🤷

By the way, this trick actually works. min is a valid property in minecraft:health component that ensures your dummy entities wont get /kill-ed by accident. (Of course, we do assign minecraft:instant_despawn events to them. That way we have more control on when to actually remove the entity, if ever we need to do so.)

That's all for me, this has turn more into a feedback than it is a bug report. But nonetheless, great job on the extension you guys and I wish to be able to contribute - if I ever got the time myself. Thank you!

from vscode-bedrock-development-extension.

DaanV2 commented on July 23, 2024

Interesting, based on some few testing, here's what I found out: So I have my files in the BP animations named in this format: *.animation.json. Maybe it's applying RP animations schemas instead of the BP animations.

.animation.json is an rp thing, also by vanilla convention.

This could be fairly quite confusing. We each have our own unique ways of formatting things. If possible, the file should be checked with the context of its location, not simply how it is named. Perhaps you can base that on the pack manifest file.

It does this if you have bp or rp in the filepath, but animation.json takes priority over those

A bit off-topic, but I would hope to have these simple schemas adjusted properly,

They are everything but simple 😂 There are over 700 files.

By the way, this trick actually works. min is a valid property in minecraft:health component that ensures your dummy entities wont get /kill-ed by accident.

No its not, I have had this conversation 100 times, I have talked to MS multiple times about this and they don't want me to add it because it probably not intended behavior, so I don't include it

Closing this issue, since everything is working as intented

from vscode-bedrock-development-extension.

Commands in server-side animations are causing errors about vscode-bedrock-development-extension HOT 6 CLOSED

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent