Code Monkey home page Code Monkey logo

Comments (4)

blairconrad avatar blairconrad commented on May 31, 2024

Hi, @lmdulz! Maybe you're right. What happens if you change the code?

Possibilities

  • I'm generally doing stuff wrong
  • older pydicom required something different
  • older Python required something different

So many options!

I'll take a gander if I can find some time.

from dicognito.

blairconrad avatar blairconrad commented on May 31, 2024

While MultiValue objects aren't lists, they do act enough like list that there was no need to copy the individual values into a list, nor to serialize the results.
I don't really have enough interest to justify the time it would take to experiment with older versions of pydicom to see if this was not so in the past, so I'll just update the code and move on.

Thanks, @lmdulz.

from dicognito.

lmdulz avatar lmdulz commented on May 31, 2024

Unfortunately I was mixing up, how single-values are stored accessing them with pydicom and dcmjs (JS) (in dcmjs tag values are stored in a list, either one or multiple in a multivalue)
But I saw that you knew that and solved it in your commits - Thank you that you're still taking the time to update that!

from dicognito.

blairconrad avatar blairconrad commented on May 31, 2024

in dcmjs tag values are stored in a list, either one or multiple in a multivalue

I'm a little sad that pydicom didn't take a similar tack, but they probably had their reasons.
Cheerio.

from dicognito.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.