After last updates, the diff syntax highlight is not working anymore.

Now the color of keyword of sizeof is white. It is not good because it is a keyword.

Selection and selection matches highlight color is too light and too shallow, maybe a little deeper will be better~

I use the OneDark-Pro v2.7.2, the "titleBar.activeBackground", the "tab.activeBackground" and the "editor.background" are the same, I think that is not good; the "statusBar.background" is not the visual studio classical blue, is there something wrong?

Great work on getting this to work!

Is there a change-log of modifications to this repo?

Many thanks,

Neil

Given the recent name change I went to update my settings.json, and given that this installs with the display name "OneDark Pro" I naturally entered "workbench.colorTheme": "OneDark Pro".

Unfortunately the display name and label for this theme doesn't currently match, and it wasn't until I used the command palette to activate the theme that I realised I actually needed to enter "One Dark pro"

From a users' perspective it would be great seeing these be the same to avoid confusion.

Hi,
The boolean related keywords, such as and, or, not are not being highlighted properly in Python.
Here is a sample screenshot.

Thanks again for your support! 😄

Please change activity bar's badge foreground and background color and command palette color to make it go well with the theme.

Hi!

use AdvancedJsonRpc\{Request as RequestBody, Response as ResponseBody};

gets

I expect the second as to be in the same color of the first.

other thing:

I expect that array is as yellow as string. You probably got worried by the array constructor array()

public function __construct(string $uri = null, array $range = null)
    {
        $this->uri = $uri;
        $this->range = $range;
    }

Many of the attributes will not highlight correctly...notice float: left
and margin: 100px auto 0 auto

C++ ordinary code color become rose red

This has been requested and MS have confirmed a new config setting will be added: microsoft/vscode#26377

Leaving this issue to remind us to update it when Code is updated.

First of all, thanks for an amazing theme!

I'd love to see if it were possible to get a better contrast for diff's in comments.

Here with javascript

And this is C#

Comments might not be the most important thing in a compare view but it should at least be possible to see the changes at all 😄

It's great that you provided instructions on how to find scopes etc. and I learnt a lot about VSCode theming from it, however, this info applies to all theming (not just for this theme). Until MS improves their docs on this, maybe these instructions could be broken-out into their own website? Then other this theme and other theme makers could simply link to them. It could provide a central source for tips and knowledge. I like the idea of it opening with a simple tutorial, and walking people through to more advanced techniques and being able to read MS's docs with confidence. What do you reckon?

I think it is self-explanatory. Color of method name and parameter should not be same.

Hope you will take a look at it. 😄 Thank you for the awesome theme!

写点使用说明介绍吧？刚下了VS Code, 是主题么？还是项目中使用的？

I expect that 'desktop' is colored green.

Code:

<?php
new class {
     public static function getUserByLogin(string $userName, string $password, string $app = 'desktop') {
        $request = null;
        try {
            $request = RequestUtil::doRequest(HttpMethod::POST, '/auth/login', [
                'json' => [
                    'login' => $userName,
                    'pass' => $password,
                    'app' => $app
                ]
            ]);
        } catch(HitboxApiException $e) {
            throw new HitboxAuthException('Cannot authenticate with hitbox api! Check username or password.', 0, $e);
        }
    }
}

From

Maybe the best theme on VS Code!

To

Atom's iconic One Dark theme for Visual Studio Code

When changing the project from the shortcut "cmd+p" the drop-down color and the active menu background color (see screenshot) is not quite contrasting causing difficulty in opening intended projects.

Is there an option to change the background color of the active menu so that I can see clearly which option is currently I'm on?

Thanks.

This isn't really an issue but I'm just wondering, and since I'm using this theme I thought it'd be the right place to ask it. I looked around a bit to find out which setting changes whitespaces' and indent guides' colors but had no luck. Where should I edit to change the color of those vertical lines and dots in the screenshot?

Is there any particular reason that this extension gets update so frequently? Visual Studio Code tells me there is an update almost daily.

After the last updates, all comments have turned red 😞

One screenshot of the theme in the readme... can do wonders

One Dark Pro: 2.7.3 | 2017.5.10

I'm using VSCode Portable.

Syntax highlighting for Styled Componentswould be amazing.

In Javascript, I'd like my local variables (declared with let const var) to be a different color than function parameters. I've looked through the .tmTheme source and am not exactly sure what I'm looking for.

function(foo) {
   var bar = 'local variable';
   console.log(foo + bar);        // where foo & bar would be different colors, say bar is default red, and foo is maybe purple or something..
}

is it possible to override with some custom settings for this kind of thing or would I need to fork, change & install?

It's still awesome theme. But better if the support italic or bold font to key word.

such as this following pic:

Can you please add license information to the repository? This is required by some institutions for use. You may find this resource helpful
https://choosealicense.com/

Thanks!

The current package name is "name": "Material-theme". Is it possible to change this? Or will it screw-up users' installation? It may have been originally forked from the Material Theme but the name doesn't really go with the project now.

It did not work in linux minit and ubuntu.

Any chance to add support for italics on keywords and the like, similar to Dracula and Panda Syntax Themes?

Thanks and keep up the good work!

Does C # support?

Which font do you use?
请问，你的主题图示中使用的什么字体？

The current styling on Javascript is too overwhelming as compared to the original Atom One Dark syntax. The red takes over everything pretty easily.

This is OneDark Pro:

This is Atom's original One Dark:

Is this an issue or is it by design?

With the release of 1.11, more of the editor is now styleable allowing for a more cohesive theme.

https://code.visualstudio.com/updates/v1_11#_preview-workbench-theming

In the javascript code:
const a = [...Object.keys(b)]
const c = Object.keys(b)

"Object" has different colors in each line:

OSX 10.11.16
Material-Theme 2.2.5

The this key word is not high light in the javascript or jsx language mode.

You have to add credits to the official Material Theme and specify that this is a unofficial porting of the original one. Open source doesn't mean "Grab works done by others and publish them with your name" ;)

With Alt+Shift+Right Arrow or Left Arrow, VS Code has this nice expand selection feature.

For some reason it doesn't it doesn't expands to quotes properly. Ideally it should not select quotes into expansion but it does if the quotes have same color (see GIF).

I don't know how Dracula fixes this issue without changing color of the quotes, what I know is that he fixed it after I reported this to him (Dracula VS Code theme maintainer).

Please fix this expand selection to not to include quotes in your theme.

Hi,

first of all, I'm really a fan of your theme. And since I'm doing lots of php development, I would wish that the php syntax highlighting gets better.

These are the things that doesn't get beautiful as expected:

function tick(bool $block = false) : bool {
 // blabla
}

I expect that false gets to a boolean value.

foreach ($nextTick as $cb) {
            $cb();
}

I expect that the dollar sign gets viewed as a normal variable.

Thanks!

Hi,
There are some default types in Python, such as int, float, List etc. More details are available here:
https://docs.python.org/3/library/stdtypes.html

The theme is not currently highlighting these standard types as separate words.
Can you please check?
TIA!

Ref: Light/Dark Visual Studio theme needs improvements to handle expressions in template string

Details

Using

• Material-theme 1.0.3
• VSCode 1.6.1
• "Latest TypeScript and Javascript Grammar" package

不小心更新了新版插件，很不习惯新的配色呀，还是喜欢以前简洁的配色。

This issue makes it difficult to use this theme with a Vim Plugin.
edit: VSCode recently added this option as a workaround:

"workbench.colorCustomizations": {
  "editorCursor.foreground": "#fff000", // e.g highlight cusor color
  "editorCursor.background": "#000000" // e.g highlight text color
  },

However, it might be a good idea to modify the defaults so users don't run into this issue.