Unhandled exception on invalid email about gatsby-plugin-mailchimp HOT 7 CLOSED

lol same. went thru the same thought process and should've stuck w result. going to close this now and merge your PR. may need to make some edits later this weekend but good enough for now.

thanks @steebchen for the contrib! much appreciated.

from gatsby-plugin-mailchimp.

looking into this.

from gatsby-plugin-mailchimp.

we return an object: https://github.com/benjaminhoffman/gatsby-plugin-mailchimp/blob/master/src/index.js#L58

weird it's coming out as an exception. we could change this line: https://github.com/benjaminhoffman/gatsby-plugin-mailchimp/blob/master/src/index.js#L62-L65

to this:

if (!isEmailValid) {
  new Promise((_, reject) => {
      reject({
          status: 'error',
          msg: 'Please enter a valid email address.'
    })
  })
)

thoughts?

that still doesn't explain why it's throwing a UE.

from gatsby-plugin-mailchimp.

@steebchen ^^

from gatsby-plugin-mailchimp.

Ah, I just realized why this happens. The build file is outdated:

That would explain why it throws.

Now we still need to return a promise, though, because we can't use .then otherwise. However, I suggest to use Promise.resolve, because we can then use .catch for network errors when something failed horribly, and use resolve with { status: 'error' } { result: 'error', msg: '...' } to notify the user did something wrong: #19

from gatsby-plugin-mailchimp.

this sounds like a good strategy. question, do you recommend status instead result?

from gatsby-plugin-mailchimp.

Personally, I'd prefer status, but I suggest we stick to result to be consistent with mailchimp's responses.

from gatsby-plugin-mailchimp.