bayesimpact / bridge-uof Goto Github PK

1. Change "Number of officers involved" to "Number of sworn officers involved"
2. On officer page, remove the question that asks about sworn/non-sworn (include migration)

Ideally we would perform automated backups every day just in case.

At the very least, we should backup the DB before running any migrations on prod, because migrations are a relatively untested feature and could potentially mess things up.

When incidents are bulk uploaded, the sub-models (screener, general_info, involved_civilian, involved_officer) do not have a field linking back to the incident (incident_ids) that should be there (and is there in manually created incidents). It seems that mostly this doesn't matter, but in one case it does. Since general_info's "incident_id" is delegated to its linked incident, on the review page, incident id does not show up for these incidents. To reproduce:

1. Bulk upload test.json
2. Go to "View" one of the incidents
3. You'll see the incident ID is missing.
4. If you edit the general info, you'll see that it comes back, as saving it creates the link correctly.

The grey text is pretty light and hard to read, especially on a bright monitor. I'd suggest making it darker black

Right now we're giving 1 read capacity unit and 1 write capacity unit to each table. This is not enough for most tables!

Use db_capacity_spec as a guideline for how much capacity is needed for each table.

I tried to upload an old test.json file by accident, which still had the sworn_type field for officers. The app correctly threw an error to that effect and did not create the incidents. However, under the hood, it DID create dangling screener, general_info, and involved_civilian objects.

If the incident has the "occured on a K-12 campus" box checked, then for every CIVILIAN, ask a mandatory multiple choice question:
"Since this incident happened on a K-12 campus, was this civilian:
( ) A student
( ) A school employee
( ) Neither"

the dashboard navigation text "review complete" gets cut off by the adjacent box

Tried creating an instance, but I forgot to do steps 3 and 4 of installation:

3.
cp data/ori.csv.example data/ori.csv
4.
docker-compose build data
docker-compose run data

When I built the instance and ran it, the app splash page (for example) loaded fine. When I went to the dashboard, I got an "Ooops" page. The app's logs showed:

NameError (uninitialized constant Constants::CONTRACTING_ORIS):
  app/models/user.rb:77:in `contracting_oris'
  app/models/user.rb:81:in `allowed_oris'
  app/queries/get_all_incidents_query.rb:10:in `perform_query'
  app/queries/query.rb:6:in `run'
  app/queries/dashboard_incidents_query.rb:8:in `perform_query'
  app/queries/query.rb:6:in `run'
  app/controllers/incidents_controller.rb:155:in `set_incidents'

It took me some head scratching to figure this out. Instead, there should be an initializer function that throws a fit when the app boots, with an informative message, and the app should never start.

1. On State Submission Tab, change “When ALL of your state's incidents for 2015 are fully ready …” to “When ALL of your jurisdiction’s incidents for 2015 are fully ready …”
2. On General Info, change “Number of officers involved” to “Number of officers involved from [agency name].”
3. On civilian page, on "civilian arrested and/or in custody" question, change "In custody" to two options -- "In custody (W&I section 5150)" (which does NOT ask for a charge code) and "In custody (other)" (which DOES ask for a charge code).
4. On civilian page, change "resistance" to "active resistance" on both question and hover
5. On civ&officer pages in injury section, change "injury caused by pre-existing condition" to "medical aid received due to pre-existing condition", and hide this question if no medical aid received
6. On officer page, change "to effect arrest" to "to effect arrest or take into custody"

When "submit to state" is clicked, pop up a modal (or direct to another page) with several optional questions:

• Total number of K-9 officers in [year] that were seriously injured or killed
• Total number of non-sworn uniformed employees or volunteers in [year] that were seriously injured or killed
• Total number of non-sworn uniformed employees or volunteers in [year] that used force on a civilian, resulting in seriously injured or death to the civilian.

For example, a user can state in the screener that an officer was hurt, but then say they weren't hurt in subsequent pages.

Exactly how comprehensive this validation is and how it is to be implemented is open-ended.

It has been determined that either thru direct entry or thru the bulk upload process it is possible to end up with duplicate records in file.
There needs to be a way to not allow this to happen.

Probably something simple with url changes, but the little icons don't load. Console shows:

Failed to load resource: the server responded with a status of 404 (Not Found)    https://demo-ursus.bayesimpact.org/assets/fbi-bw-large.png

We should try to only push changes to prod (especially ones requiring a DB migrations) during some kind of maintenance window, to prevent state from getting messed up in any way.

How this maintenance mode is implemented is pretty open-ended. There could be an environment variable for it, or a flag inside the DB itself, or a pre-configured schedule.

"You (or another administrator) have reviewed and approved these incidents. It will be included in your annual state submission. You may still edit and make changes if necessary."

should read "They will be included"

Now that we have a way to backup dynamodb (#47), we should have regular (daily?) backups of our production DB.

In the long run, it would also be good to port the backup/restore code from the iPython notebook into rake tasks.