Minify causes page generation to hang about awestruct HOT 11 CLOSED

Any chance you could create a small test case or small site to demonstrate
this?

On Tuesday, July 26, 2016, Bartosz Majsak [email protected] wrote:

Having minify: true in site.yml and defined in pipeline.rb as below
causes generation process to hang.

transformer Awestruct::Extensions::Minify.new([:js])

Running awestruct built from master @a014121
a014121

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#526, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB1E61lEdN4ld6T3kKa4a_W5P-lSiSUks5qZb-bgaJpZM4JU4rR
.

Sent from Gmail Mobile

from awestruct.

Sure, but not this week :\ Have to catch up with other stuff.

from awestruct.

Not a problem.

On Tuesday, July 26, 2016, Bartosz Majsak [email protected] wrote:

Sure, but not this week :\ Have to catch up with other stuff.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#526 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB1E6wNZeZ3XnT8LbaJxoCqLgKB0gdsks5qZcuggaJpZM4JU4rR
.

Sent from Gmail Mobile

from awestruct.

Let me know when you have a test for this @bartoszmajsak.

from awestruct.

Same issue with debezium.io when moving to 0.6.0.alpha4 (see debezium/debezium.github.io#406). Any idea what's wrong here? Should we simply skip minifying?

from awestruct.

@gunnarmorling Any better if you add

generation:
  :in_threads: null

to your _site/config.yml?

from awestruct.

Yes, in fact it does. Thanks! Are there any implications to using this setting?

from awestruct.

It stops generation from being run in parallel. Depending on how complicated and large the site is it may mean something like a few seconds of additional build time to a couple of minutes (but I doubt debezium is that large, developers.redhat.com was a few years ago).

from awestruct.

@gunnarmorling the option is passed to the parallel package, you can check https://github.com/grosser/parallel#usage for details.

Setting in_threads to null overrides the default introduced in
3da3c68
so the parallelization falls back to the default defined here:
https://github.com/grosser/parallel/blob/master/lib/parallel.rb#L248
which may be more reasonable.

On the Jenkins site switching from Awestruct default to parallel default sped up the process twice AND made it less buggy (Coderay seems not to be thread-safe, maybe minifier has the same problem).

@LightGuard I'd suggest removing the Awestruct default.

from awestruct.

from awestruct.

@gunnarmorling the default was changed in 0.6.0RC1 which also has a fix for #549 so I think your site should compile without any changes to the config and without any workarounds in the build script. Please give it a try and let us know if it worked for you. Then we could promote RC1 to stable (likely in ~2 weeks if no negative feedback).

from awestruct.