Comments (1)
Team's Response
This is an implementation choice, of which can be read about in the DG. Rescheduling only takes place once the workout is overdue:
Reasoning: it is useful to know what workouts were scheduled in the day, when looking back to record workouts and calories burned using the add workout
command.
Items for the Tester to Verify
❓ Issue response
Team chose [response.Rejected
]
- I disagree
Reason for disagreement: While I agree that to be able to track all workouts on a current day, we should not reschedule workouts that already happened as long as its on the same day. However, based on my understanding, a scheduled workout should be something that at this point in time, I schedule something in the future. If I want to add a past workout that happened earlier in the day to record workouts and calories burned, shouldn't it be done using the add workout command directly, rather than adding a scheduled workout?
Also, I believe that this definition of overdue workouts should be in the UG to inform the user of this expected behaviour.
❓ Issue severity
Team chose [severity.Low
]
Originally [severity.Medium
]
- I disagree
Reason for disagreement: I believe this is quite confusing. Also not sure if this implementation choice is the best as while I understand the rationale for adding a workout that has already happened earlier in the day to track, it should be added using add workout rather than add schedule as schedule implies a future workout. Hence, I feel that anything that already happened in the past (even if on the same day) that is added using add schedule should be rescheduled.
from pe.
Related Issues (20)
- Unclear error message HOT 1
- Different behaviour when almost similar (invalid) inputs are entered for add workout HOT 1
- Unclear error message for delete schedule HOT 1
- Possible improvement to error message for list schedule command HOT 1
- Program picks the first date input if duplicate dates are keyed in HOT 1
- Workout on a future date can be added without scheduling command HOT 1
- No functionality for completing a scheduled workout, not sure what the purpose of meal and fluid library is HOT 1
- UG help message did not explicitly state that one can omit fluid calories in the add command if the fluid is already in the library HOT 1
- UG is unnecessarily long and includes many details that are redundant/overwhelming especially to a first time user HOT 1
- UG: Add scheduled workout with activity breakdown is too complicated HOT 1
- UG: Better ordering of example usage and expected outputs HOT 1
- DG: UML Diagram Mistakes -- sequence diagram footbox HOT 1
- DG: UML Diagram Mistakes -- class diagram HOT 1
- DG: Instructions for manual testing section is too long HOT 1
- DG: Lack of Object diagrams HOT 1
- DG: Missing Architecture diagram and an overall high level description of the architecture HOT 1
- DG: UML diagram comments HOT 1
- UG: Missing detail on how to use BMI and calorie intake calculator HOT 1
- UG: No v2.1 user stories HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pe.