Comments (1)
Team's Response
add workout
is to record workouts(mainly completed ones), with the calories burned.
add schedule
is simply to plan/schedule workouts, having an idea of your workout plan in the future.
Although not the conventional usage, add workout
retains the ability to record workouts in the future as some users might find some use for it. For example, some users might know they are doing a workout the next morning, they would find it useful to record a workout(with its calories) in advance, they know they will be doing in case they forget to record it.
Basically this is an implementation choice since it allows for user flexibility IF they want to record stuff in advance.
Items for the Tester to Verify
❓ Issue response
Team chose [response.Rejected
]
- I disagree
Reason for disagreement: With the functionalities of the 2 commands overlapping, I find this to be very confusing for the user. Would it not be better to just then have only 1 workout command that can add both past and future workouts? Then have a function to mark a workout as completed, because sometimes even if users add a workout to the future he may eventually not do it (hence the calories don't count). Else if schedule workouts is meant to be for future workouts, the regular add workout command (which requires the user to input calories burned, is to record workouts that are completed so as to count calories) should not be allowed to add future workouts right? Then similarly have a function to make a workout from the list of schedule workouts as completed on the day that the workout was scheduled.
❓ Issue severity
Team chose [severity.Low
]
Originally [severity.Medium
]
- I disagree
Reason for disagreement: The implementation is honestly quite confusing for me due to the overlapping command usage (and needing to handle 2 separate lists of workouts and schedule workouts yet without a clear distinction between the 2 commands). I believe this causes more than just a minor inconvenience that happens very rarely.
from pe.
Related Issues (20)
- Unclear error message HOT 1
- Different behaviour when almost similar (invalid) inputs are entered for add workout HOT 1
- Workout schedule does not reschedule overdue workouts that are scheduled today but already past the current time HOT 1
- Unclear error message for delete schedule HOT 1
- Possible improvement to error message for list schedule command HOT 1
- Program picks the first date input if duplicate dates are keyed in HOT 1
- No functionality for completing a scheduled workout, not sure what the purpose of meal and fluid library is HOT 1
- UG help message did not explicitly state that one can omit fluid calories in the add command if the fluid is already in the library HOT 1
- UG is unnecessarily long and includes many details that are redundant/overwhelming especially to a first time user HOT 1
- UG: Add scheduled workout with activity breakdown is too complicated HOT 1
- UG: Better ordering of example usage and expected outputs HOT 1
- DG: UML Diagram Mistakes -- sequence diagram footbox HOT 1
- DG: UML Diagram Mistakes -- class diagram HOT 1
- DG: Instructions for manual testing section is too long HOT 1
- DG: Lack of Object diagrams HOT 1
- DG: Missing Architecture diagram and an overall high level description of the architecture HOT 1
- DG: UML diagram comments HOT 1
- UG: Missing detail on how to use BMI and calorie intake calculator HOT 1
- UG: No v2.1 user stories HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pe.