Code Monkey home page Code Monkey logo

xivcomboplugin's People

Contributors

amenneholelane avatar attickdoor avatar caraxi avatar daemitus avatar goaaats avatar rreminy avatar tiny96 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

xivcomboplugin's Issues

SAM Request: Tsubame-gaeshi from Iaijutsu

Since Tsubame-gaeshi is exclusively available as a follow-up to Iaijutsu and Iaijutsu cannot be used twice in sequence, there is absolutely no reason for Tsubame-gaeshi to have a separate button. If it could combo from Iaijutusu, that would be enormously helpful for a Samurai's hotbar.
Thank you!

Suggestion: Toggle functionality command.

So for a few situations it would be nice to be able to use skills outside of their combo rotation. Such as using the samurai's ability to skip combo requirements for the next 3 abilities. Or the need to throw out one of the AOEs to aggro enemies as you run past a group.

Because of the way the combo system works, I can't actually do these kinds of things. Could there be a command to toggle functionality of the combo system? That way I could put it into a macro to slot into my hotbar. This would allow much more versatility of the tool, and enable users to manually break sequence when they need to.

GNB Wicked Talon combo freezes if Lvel 70+ and have Amnesia (no Abilities)

Discussion in Goat's discord regarding an edge-case where the Combo can freeze and not let you continue even though you could... I looked into it and summarised it here.
https://discord.com/channels/581875019861328007/685275026156683280/854532070331777024
Basically, it has to do with combos that go back and forth between the 3 action types (Ability, Weaponskill, Spell).

EDIT: I will note, I have not ingame tested this myself. It was enough to be able to review the code while "working".

The example provided was GNB when under the Amnesia affect (Heaven on High/Palace of the Dead).
When level 70+ the Wicked Talon combos (Weaponskills) lead into Continuation combos (Abilities) and then return to Wicked Talon combos.
The XIVCombo button locks up if you have Amnesia, as the code logic says "Your level 70 with a Ready to Rip/Tear/Gouge buff, so I should use the Ability instead of the Weaponskill that is next". But the user cant use the Weaponskill without a manual button.

Had a look through the current combos, and the only use-case I saw was the Gunbreaker one.
Every other instance I saw, the different actions were at the end of the chain or dependent on the previous, so they weren't "bouncing" between the two.

Again, I dont believe the same logic is required for "Pacify" or "Silence" buffs, or any other class, because almost every other instance of changing between Ability/Wepaonskill/Spell has the Weaponskil/Spell before the Ability (so being Pacified/Silenced would stop you getting there anyway). And if you do use a useful Ability (Hypercharge) when you cant use Weaponskills (Heat Blast)... well...

Plugin stops working

As title says sometimes this plugin stops working randomly and only shows last skill

Plugin not working for me

I see the plugin loaded (chat log says v1.0.0.5 loaded but XIV plugins show I have v1.0.1.0 installed). I enabled GNBs solid barrel combo. I hit save & close and put Solid Barrel on my bar. It does not swap to Keen Edge. I tried this on various MCH and DRK as well but no abilities swap. Am I doing something wrong or does this not work atm?

I tried removing the addon folder in app data and installed fresh and no luck.

Could we nerf this cause it's like cheating

Title, this feels like cheating because it's suffering the same effect that macro chainer did, where it enabled you to repeat macros over and over again, it's like botting and an unfair advantage to players.

[Suggestion] Visual indication of combo

Hi, would it please be possible to add some sort of visual indicator of what combo each icon is for jobs that have multiple combos beginning with the same skill ? Looking at you, Samurai...

MNK Request: Single/Buff Combos and maybe modifying how the combos proc

Essentially add the combos for Bootshine -> Snap Punch and Dragon Kick -> Demolish.

Also add that each combo sequence changes based on what stance you have if it doesn't already.
Then, when formless fist is activated, each one changes into one of the "buff" combos (Demolish/Twin Snakes/ Dragon Kick).

[GNB] Fated Circle Combo

GNB has a triple AoE combo I often use on trash mobs in dungeons :

Demon Slice -> Demon Slaughter -> Fated Circle

At the moment, the plugin only has a combo for the first two of those.

While I understand not wanting to use Fated Circle each time as it uses an aether charge, would it be possible to add an option to the plugin to add Fated Circle to the combo ?

RDM Ver Proc

it would be better if "verfire" and "verstone" replaced "verthunder" and "veraero" on proc, like in pvp

PLD : Royal Authority/Rage of Halone Combo

I didn't yet unlock the spell Roral Authority but the combo mentionned in the settings seems to indicate that the combo chain should work with Rage of Halone.

The problem I have is that Rage of Halone is never cast, and always Roral Authority is.

If I can help in anyway to debug it tell me, I didn't yet looked at the code but I could if you want and propose a Pull Request if I find a solution

Icon change option

Hello,
The option ''prevent the chain from updating its icon'' isn't working, every time you change jobs the icons change and you have to put them back again on your hotbars.

Combo chains starting with followup instead of chain starter?

sorry if that doesnt make sense, but using dragoon as an example, it has two different combo chains but both start with true thrust,

Is it possible to have the disembowl/chaos thrust combo start with disembowl iunstead of true thrust and the vorpal thrust/full thrust combo start with vorpal thrust instead of true thrust? as it stands my bars look like this

image

where one of the true thrusts leads to disembowl and the other leads to vorpal thrust.this causes some visual clutter and confusion.

i am admittedly fairly new to the game, maybe it'll ease with experience, would it still be possible to have chains like this start at their 2nd ability in the chain? it admittedly wouldnt save as much space on the bars as the current setup, but i do feel it could help reduce some confusion.

could you create new SAM combo?

for lv76 an lv80 。sorry i dont use c#. this is js logic if( SAM lv80 can use ){ use lv76 replace lv80 after use lv 80} else { use lv76}. thanks

Suggestion: Only update icon

This is the inverse of the "Prevent this chain from updating its icon" option.

I try to use xivcombo only for its convenient ui implications: I don't need to put my full combos on my screen to see what's going on. I still like to try and press my buttons as necessary.

Ideally this would be enforced by the plugin as well. When the button is pressed, the icon for the combo finisher changes from it's combo starter to the next in the chain without actually changing the functionality of the button.

DRK combo replacement breaks job quests

In the DRK job quests, you need to use Souleater on specific targetables out of combat. The issue is not that XIVCombo doesn't let that exist on the hotbar, but rather that it causes an invalid target error if you even try to execute it directly from the Actions menu.

demonstration

DNC request combine GCDs into single button

Would it be technically possible to do this? The way DNC plays is hit Cascade for single or Windmill for AOE and then keep hitting every skill that lights up. Same with Standard/Technical step. Functionally there is no reason to have anything other than those 2 buttons for GCD actions.

AST auto play cards

I am thinking if we can do something like:
if dps and dps already not having a card:
--if arrow, balance or spear or lord of crown:
----if melee dps:
------give to the highest enmity melee dps
----else:
------give it to the highest enmity dps
--else:
----if ranged dps:
------give it to the highest ranged dps
----else:
------give it to the highest enmity dps
else:
--give it to the highest enmity player

I have never done a pull request before, let me know if you'd rather me working on a pull request instead, i think this will really help those playing ast on a controller with the regular weaving card issue, and this is probably the best way to optimize AST game play.

And if you'd rather like me to work on a pull request, can you tell me which document to fork and edit and which are some sample? Thanks!

Plugin randomly stops working

It randomly stops working and just shows the last skill
For example Kasha on SAM instead of Hakaze
Disabling and enabling it again fixes it but it also happens mid battle which is pretty bad

BLM combos frequently stop working.

Hi there,

I'm having a lot of trouble with the BLM combo - I'm not sure if it's specific to BLMs in particular but that's where I've been encountering the issue so I'll report it as I've seen it. When it works, it works perfectly, but sometimes it just.. stops working. Often during instances, or after I've logged in.

When I open the plugin menu the combo checkboxes are all ticked as one would expect, but no combo functionality actually takes place. I generally have to reinstall the plugin to get things working again. Not sure if this would happen with other combos as well, I haven't tested them too much apart from with DRK though I didn't have any issues there so far - but the last time I played DRK was I think before FFXIV dropped a small patch, so maybe there's something in that?

Samurai back step combo chain

Hissatsu: Yaten -> Enpi -> Hissatsu: Gyoten

rather than having 3 buttons separately for this combo may as well make it one xd

Expand Actions to Combo

Sch:
Lustrate Turns into Aetherflow if no stacks available,
Indomitability turns into Aetherflow if no stacks available.
Doesn't happen under effect of Recitation
Summon Seraph turns into Consolation if Seraph is out

Whm:
Afflatus Misery automatically targets your target's target since you're using targetting the tank.

Rdm:
Turn veraero/verthunder into verstone/verfire if it's procced.

Blm:
Turn Thunder 3 into Thunder 4 if procced

Dnc:
Turns Reverse Cascade into Cascade version if not procced
Turns Fountainfall into Fountain if not procced

General:
Option to make the icon that displays with icon lock the end of the combo icon.

NIN Mudra Combos

Can't speak for everyone but (having an awful memory) I would very much enjoy being able to map the mudras and instantly activate the respective ninjutsu action on the same button. Has anyone tried to do this before?

Feature: SCH Fairy

I would like to request the Summon actions and Fairy actions for SCH to be consolidated.

  • If no fairy is summoned, Whispering Dawn and Fey Illumination cannot be used.
  • If one or both of them could turn into Summon buttons, when no fairy is summoned, it would also make it easier to see whether a fairy is summoned or not.
  • Each of the skills could be a different fairy and no functionality would be lost (besides changing fairy mid-fight, but I doubt anyone really wants that).
  • Nice-to-have: Let the user pick one of the fairies in the /pcombo window to change both action to, if they have a preferred fairy.

doesnt work in gamepad UI

i thought i was missing something at first then i pulled my chaos thrust out to one of my normal bars, and sure enough it works right as rain on normal actionbars.

any way to update this so it works on gamepad UI? i know this is only available on pc ffxiv, but if anyone needs pcombo, its def gamepad players.

Skill combos break in 'Instances' or in the overworld/FATE-syncs if Skill Quests are incomplete.

Job quests with skill upgrades need to completed 'at level' for the combo plugin to work properly. Leaving them incomplete will trigger the combo to get stuck on a greyed out skill not yet unlocked through the quest.

A workaround is to place the first skill (or continuation skill) of the combo somewhere on your hotbar to manually continue the combo chain.

This is only affected when doing instances or overworld fates that do not sync your level and disable the skill upgrades.

Found when I hit level 54 and neglected the questline "A Joye-ful Reunion" to unlock Heated Split Shot. Heated Split Shot was skill greyed out and unusable with Split Shot requiring manual clicking to update the combo.

(Awesome plug-in. Thanks!)

MCH Combo issues.

Both the Overheat/Heatblast and Spreadshot/Auto-crossbow combos do not appear to work in 5.3.

BLM Request Fire/Ice "Combo" Buttons

Merging of Fire with Blizzard (vice versa) and Blizzard II with Fire II,.
In my experience these abilities will generally only be in their respective astral and umbral states (and most people start off in fire anyway)

DNC combo issues with bloodshower

When placing bloodshower on your bar it is replaced with bladeshower, however it does not change properly into bloodshower when you get a Flourishing Shower proc. It does it properly for Windmill-> Rising Windmill but not Bladeshower->Bloodshower.

Suggestion for Bard DoT combo

A optional combo for bard that would condense the two DoTs into one icon for easier management rather then needing to have 2 icons on your hotbar for them.

IE: Venomous Bite/Caustic Bite and Windbite/Stormbite being combo'd together, press the button to apply the dot and swaps to the next one to apply the other. Could also see this adding Iron Jaws into the combo, so if it reads that both dots are applied to the target it will use iron jaws instead.

I feel like this could be done ingame via a macro but with the xivcombo it would make it a lot simpler, thanks for reading!

I'm afraid I'll get banned

This plugin is as detectable as using ACT, Triggernometry, or most other third party tools. If you aren't afraid of getting banned with those, you shouldn't be afraid of getting banned with this.

[Question] Bannable?

Just curious if this plugin is bannable in any way? Similar to paisley park with how it injects things into the game, as opposed to ACT which just reads data.

Some combos no longer work and do not advance their steps

Things found which won't advance thus far:

GNB Gnashing Fang combo
All of SMN tabs
Both BLM tabs
NIN Hakke Mujinsatsu combo
MCH Hypercharge to heat shot, spread shot to crossbow
Both SCH tabs

Everything else is either fine and working or I'm unable to test them personally. Hope this helps!

Combos for DoH classes

For example, the following combos would be great to condense into one button:

  • Observe → Focused Synthesis
  • Observe → Focused Touch
  • Name of the Elements → Brand of the Elements

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.