atom / one-dark-syntax Goto Github PK
View Code? Open in Web Editor NEWAtom One dark syntax theme
License: MIT License
Atom One dark syntax theme
License: MIT License
but keep stuff like brackets, punctuation etc dark. Origin: #9
Really like that this is the default theme now, but one thing different from Atom Dark that I find annoying is that keyword arguments in Python aren't highlighted. So if I have for example:
spam(ham, eggs='foo')
This would highlight eggs (but not ham). I'm quite used to this and I feel like I'm missing some instant grokability without it.
Something like in Atom dark https://github.com/atom/atom-dark-syntax/blob/master/index.less#L158-L161
Currently there are a few "specs" under atom/one-dark-syntax/spec
.
But it would be better to have them in a separate repo. Then all theme authors could use them and it's not tied to this One. Also, easier to update them in just a single place. And we could reference them from the docs.
I made a new repo here: https://github.com/simurai/language-examples. It contains examples for all the core languages.
@atom/feedback if this is a good idea, could somebody create a new repo for it, maybe atom/language-examples
?
The screenshots show beautiful, fizzy colours! They were perhaps a bit too bright for some, but I think over the last few months the One Dark combination has become a little gloomy.
So, since I know about nothing on this subject: is it possible to give the One Dark theme an option to inject a little bright, bold happiness into the syntax? Or do I need to fork this repo and make the changes?
tl;dr: Can a UI theme control/affect syntax themes in any way?
Apologies if this issue is inappropriate (because it really isn't an issue, more of a question).
A few syntax color variables have been added: https://github.com/atom/atom/blob/91710894660018988cfa87c5132333129dd1f0c6/static/variables/syntax-variables.less#L32-L43
Initially they will be used for autocomplete. Overriding them in the theme will make autocomplete look more consistent with the rest of the theme.
ps. don't forget the light theme and possibly more.
Standard code blocks are highlighted in green.
```
$foo = new Foobar;
```
But code blocks with their language specified don't have any highlighting at all.
```php
$foo = new Foobar;
```
[Enter steps to reproduce below:]
Atom Version: 1.0.19
System: Mac OS X 10.10.5
Thrown From: one-dark-syntax package, v1.1.0
Failed to activate the one-dark-vivid-syntax theme
At variable @syntax-bracket-matcher-background-color is undefined in /Users/zhanglizeyi/Downloads/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/editor.less:26:22
LessError: variable @syntax-bracket-matcher-background-color is undefined
at /Users/zhanglizeyi/Downloads/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/editor.less:26:22
-3:57.8.0 settings-view:install-packages-and-themes (atom-text-editor.editor.is-focused)
-3:32.1.0 core:paste (atom-text-editor.editor.mini.is-focused)
-3:29.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
-2:44.2.0 core:paste (atom-text-editor.editor.mini.is-focused)
-2:42.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)
-2:37.5.0 core:backspace (atom-text-editor.editor.mini.is-focused)
-2:36.7.0 core:confirm (atom-text-editor.editor.mini.is-focused)
-0:33.5.0 symbols-view:toggle-file-symbols (div.settings-view.pane-item)
-0:20.3.0 core:paste (atom-text-editor.editor.mini.is-focused)
-0:19.8.0 core:confirm (atom-text-editor.editor.mini.is-focused)
{
"core": {}
}
# User
atom-rainbow-syntax, v0.1.1
# Dev
No dev packages
Problem: One Dark is originally based on base16-tomorrow which uses red for highlighting (e.g. variables). In base16-tomorrow it's somewhat muted, but in One dark the red is stronger and could make it look like it's some kind of "error".
Ref: atom/language-javascript#263, atom/language-javascript#258
Solution: Replace red with something else.
As the title says, the word "DISTINCT" in SQL doesn't seem to be highlighted - and it's a quite important keyword in my opinion.
[Enter steps to reproduce below:]
Atom Version: 1.2.4
System: Mac OS X 10.11.1
Thrown From: one-dark-syntax package, v1.1.1
Failed to activate the gruvbox theme
At variable @mono-3 is undefined in /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9
LessError: variable @mono-3 is undefined
at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9
{
"core": {
"themes": [
"gruvbox",
"one-dark-ui",
"one-dark-syntax"
]
}
}
# User
Parinfer, v0.9.0
hyperclick, v0.0.35
minimap, v4.16.2
nuclide-file-watcher, v0.0.35
nuclide-fuzzy-filename-provider, v0.0.35
nuclide-open-filenames-provider, v0.0.35
nuclide-quick-open, v0.0.35
nuclide-recent-files-provider, v0.0.35
nuclide-recent-files-service, v0.0.35
proton-mode, v0.1.0
python-yapf, v0.9.1
relative-numbers, v0.2.4
vim-mode, v0.63.0
# Dev
No dev packages
I've noticed that in Ruby, symbols are now the same color as strings, which makes it kind of hard to figure out just from the color scheme whether something is a symbol or string.
(Also applies to one-light-syntax)
It would be nice if this theme highlighted valid CSS property names like in e.g. Atom Dark.
Hi, what css do I need to write into my custom css atom file if I want to decrease the brightness of the grey editor background?
It think it is a really good looking theme but for me personally the background is too bright to look at it all day long. (In the risk of the grey color being part of a color composition together with the other colors. Maybe there is a bigger thought behind this?) Thanks.
Thank you, thank you, THANK YOU!!! π π π
I sometimes use <a href="blah" target="_blank">
HTML tags in my Markdown code when "open the link in a new browser" behavior is appropriate.
Unfortunately the underscore character with in "_blank" triggers the syntax to try to show "Markdown italicized" formatting until a "closing" underscore is encountered somewhere else.
See attached image.
I want to test some change in the styles of my local Atom, but I can't find where one-dark-syntax package is. My goal is to add support for pug (jade) syntax.
Can you help me?
The One Syntax theme breaks when using https://atom.io/themes/isotope-ui.
I think the problem is that Isotope tries to use the @syntax-background-color
from One, but that one uses a variable imported from another LESS file (color.less), which Isotope does't (and shouldn't) import. https://github.com/atom/one-dark-syntax/blob/master/stylesheets/syntax-variables.less#L17
I'll have to look into it more, but maybe as a rule, the "official" syntax variables aren't allowed to be dependant on importing other files.
/cc @braver (no need to change anything in Isotope, just FYI)
[Enter steps to reproduce below:]
Atom Version: 0.210.0
System: Mac OS X 10.10.3
Thrown From: one-dark-syntax package, v0.7.1
Failed to activate the retro-gruvbox theme
At variable @mono-3 is undefined in /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9
LessError: variable @mono-3 is undefined
at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9
-0:34.7.0 settings-view:install-packages-and-themes (ul.list-inline.tab-bar.inset-panel)
{
"core": {
"themes": [
"atom-dark-ui",
"one-dark-syntax"
]
}
}
# User
atom-jade, v0.3.0
autocomplete-php, v0.3.6
autocomplete-python, v0.4.3
autocomplete-ruby, v0.1.0
color-picker, v2.0.7
language-htaccess, v0.1.1
minimap, v4.10.0
# Dev
No dev packages
I noticed that using this theme (and a few others such as Firewatch and Gruvbox) that the comments shift text on code lines below such that it pushes them almost onto other lines like so:
Using the atom dark
syntax theme rather than one dark
syntax fixes this however.
Not sure what causes this or if it is intended. :)
The comment in one-dark-syntax is a little hard to read, even though I love the rest part, this drawback is painful.
hello. i work with large json files periodically, and noticed something that i miss in 'one dark syntax' theme.
sublime material theme has next json highlighting:
this is the same chunk, but in atom with one dark syntax:
keys of keys has more saturated red color, and 'root' keys are purple at all.
it is not critical, but significantly improves understanding of structure, especially when you are tired.
also - maybe there is a reason to make color of quotes a bit darker, so user could focus more on keys / values, not quotes (example)
Carried over from atom/atom#6141
One Dark syntax theme colors all Java code yellow
I've installed the package and I'm using the default Atom font family which looks a little different. Can you tell me which family is the one used in the screenshots.
Thanks a lot
My understanding is that in a code block characters that would otherwise require escaping with backslash (i.e. *, _ etc) do not require escaping.
I am finding that whilst the generated result is correct the source syntax highlighting is ruined. This is particularly painful as I am writing SQL code blocks which contains lots of underscores and stars.
I'm not sure if this is the platform (ArchLinux) or the font (Source Code Pro) to blame, but this doesn't occur with the Atom Dark theme.
Steps to reproduce:
[Enter steps to reproduce below:]
Atom Version: 1.0.11
System: Mac OS X 10.10.4
Thrown From: one-dark-syntax package, v1.1.0
Failed to activate the 2-dark-syntax theme
At variable @mono-3 is undefined in /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9
LessError: variable @mono-3 is undefined
at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9
-8:39.3.0 core:backspace (atom-text-editor#one-dark-ui.fontSize.editor.mini.is-focused)
-8:38.9.0 core:confirm (atom-text-editor#one-dark-ui.fontSize.editor.mini.is-focused)
6x -8:15.3.0 application:new-file (atom-pane.pane.active)
4x -8:09.0 core:close (atom-text-editor.editor.is-focused)
-6:41 core:confirm (atom-text-editor.editor.mini.is-focused)
-6:32.2.0 core:backspace (atom-text-editor.editor.mini.is-focused)
-5:05.9.0 core:move-right (atom-text-editor.editor.mini.is-focused)
2x -5:05.4.0 core:move-left (atom-text-editor.editor.mini.is-focused)
2x -3:52.8.0 color-picker:open (div.settings-view.pane-item)
-3:18 core:undo (atom-text-editor.editor.is-focused)
-3:03.4.0 core:backspace (atom-text-editor.editor.mini.is-focused)
-2:48 core:confirm (atom-text-editor.editor.mini.is-focused)
4x -2:15.7.0 core:close (atom-text-editor.editor.is-focused)
-2:13.7.0 settings-view:open (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-one-dark-syntax.theme-one-dark-ui)
{
"core": {}
}
# User
atom-smart-tabs, v0.1.0
browser-plus, v0.0.34
code-links, v0.3.11
color-picker, v2.0.11
less-autocompile, v1.0.0
less-than-slash, v0.8.0
navigate, v0.1.10
new-tab, v0.4.1
tabs-to-spaces, v0.11.1
# Dev
No dev packages
I would like to see this mistake:
be more visually dissimilar from the intended code:
But I'm afraid my implementation is too tightly coupled to language-babel.
Would a PR for such an effect be wanted? If so, is .meta.brace.curly.js
an appropriate thing to target to reset the style back to normal for JS blocks escaped by { }
?
Syntax highlighting for TypeScript works really well, but it does not work in the case where I'm writing JavaScript with Flow type annotations.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.