Comments (19)
Everything seems to have a slight bluish-tint to it when this theme syntax is applied.
from one-dark-syntax.
True. I think making plain text a neutral color (some sort of gray or off-white) would improve readability.
from one-dark-syntax.
@stramel Yes, there is some blue-ish tinting to match the background color. Initially the plan was to add some options to the settings so you could change things like hue, saturation, lightness. But that had to be put on ice for the moment.
So yeah.. for now, let's reduce the tinting and increasing the contrast a bit. I think in the end, it always depends on the environment that you're in. Dark room vs coffee shop with sunlight.
from one-dark-syntax.
Dark room vs coffee shop with sunlight.
Split the difference, and use an office cubicle with lots of fluorescent lighting...
from one-dark-syntax.
ok.. started a new branch. Will tinker a bit with the colors.
One day we'll get light-level
Media Queries and then it could adapt to the environment automatically.
from one-dark-syntax.
One day we'll get light-level Media Queries and then it could adapt to the environment automatically.
Wouldn't that be awesome? I was working on doing similar stuff for house lighting. I hadn't thought about computers.
from one-dark-syntax.
Until that day: https://justgetflux.com ;) Seriously though, light levels are a huge reason for me to switch between light and dark themes, and I'd love some choice in between.
from one-dark-syntax.
Yeah, I use flux on my home pcs
from one-dark-syntax.
Heh.. yep, I used flux a while back and probably still would but I found myself temp disabling it way too often to see the "real" colors.
Something I'm not sure with light-levels
. Should a theme completely switch from dark to light or just adjust the contrast a bit. I'm thinking automatically switching could be annoying and will throw you off.
from one-dark-syntax.
I would hate to have a theme, or any UI self adjust. I've disabled things like auto brightness on my Mac and iPhone.
On Feb 23, 2015, at 10:22 PM, simurai <[email protected]mailto:[email protected]> wrote:
Heh.. yep, I used flux a while back and probably still would but I found myself temp disabling it way too often to see the "real" colors.
Something I'm not sure with light-levels. Should a theme completely switch from dark to light or just adjust the contrast a bit. I'm thinking automatically switching could be annoying and will throw you off.
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-75691795.
from one-dark-syntax.
In my case, I really like that for example Instapaper switches automatically to light text on a dark background when it gets dark, like at night. Easier to read and less jarring. But that's just when reading text. Having syntax highlighting automatically change is probably a different story.
from one-dark-syntax.
iBooks also does that flip to negative and it works well enough to leave it on. Just be sure not to put anything in front of the sensor.
For code though I think you would need a syntax theme like Solarized, that maintains the colouring and overall contrast, but flip the base back and foreground color. Transitioning between dark and light is though, how do you deal with contrast?
There is already this and this that enable manual 'flipping'. And apparently this theme that does it automatically based on a mac's light sensor (altough I kinda doubt that one still works).
from one-dark-syntax.
Just tested Outdoor theme and it works for me when turning on/off my room lamp. But only if I change the "Light Level to Switch" to 500000
. Probably it needs to be calibrated.
Anyways.. I'll try it for a few days and see how it feels.
from one-dark-syntax.
@smlombardi Was this resolved?
from one-dark-syntax.
i can't tell, really. The conversation digressed. Any other status
reports?
On Fri, Feb 27, 2015 at 6:02 PM Michael Stramel [email protected]
wrote:
@smlombardi https://github.com/smlombardi Was this resolved?
—
Reply to this email directly or view it on GitHub
#7 (comment).
from one-dark-syntax.
Sorry, not yet. I started a sm-neutralize
branch, but it hasn't been merged into master.
I'll reopen this again.
from one-dark-syntax.
Text color is now less blue:
from one-dark-syntax.
Does this show up in the next Atom release, or do we need to install this package as well?
from one-dark-syntax.
You don't need to manually update. It will be part of one of the upcoming Atom releases.
from one-dark-syntax.
Related Issues (20)
- PHP highlighting messed up in Atom Beta (1.21.0) HOT 8
- Wrong curly bracket color HOT 5
- Make background pure black, and/or add config option for background color HOT 1
- Code background color is not same with background color HOT 2
- Comments move text below HOT 6
- Syntax highlight issue HOT 4
- "DISTINCT" in SQL is not highlighted HOT 2
- improve json highlighting HOT 4
- and, or, ... keywords not highlighted HOT 1
- 1.6.0 breaks syntax highlighting on one light/dark HOT 4
- Syntax highlight broken after update HOT 10
- Latest Atom Breaks One Dark Syntax HOT 2
- Markdown Syntax coloring (links vs. emphasis) HOT 1
- Question about custom syntax HOT 3
- <unknown> is deprecated. HOT 1
- PHP syntax highlighting issue inside HTML quotes HOT 1
- Improve LESS Highlighting
- Syntax color is mismatch for this PHP source (1.18.0) HOT 1
- How to remove italics from comments HOT 1
- Comment documentation highlighting is incorrect for class properties. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from one-dark-syntax.