Implement Display for Vector about rulinalg HOT 6 CLOSED

Would be reasonable to just do something like this, right? If the vector has data vec![a, b, c] where a, b and c all impl Display, just return [a b c]? Should be pretty straightforward from there.

Edit: Just reread your point. How would you specifically handle "natural" line wrapping? i.e. how many characters are you going to want to wrap it to?

from rulinalg.

Yes I think this is indeed appropriate. The only other thing worth being aware of is allowing the accuracy of floats to be specified (we do this for Matrix).

And as for your edit - I'm not too sure what I meant myself! I believe I just meant we can return the string all on one line and let the user's terminal handle new lines? I'm not too sure how this part of Rust works but it seems like an acceptable start point?

from rulinalg.

Would you think it's a good idea to use a max_datum_width size as in Matrix? I feel like since the vector can have arbitrary length it may introduce unnecessary whitespace, e.g. if the vector was something like vec![1000000000, 1, 2, 3].

from rulinalg.

I agree with you, I don't think it really helps the user in this case. Let's just keep a space after each comma.

from rulinalg.

Makes sense. I'll take a look at this; I'll try to get something PR'd before Rustconf :)

from rulinalg.

Awesome, thank you!

from rulinalg.