Generate enum instead of type + const about orval HOT 6 CLOSED

https://blog.graphqleditor.com/enums-are-still-bad

from orval.

@Wtiben, the article is misleading, because it says:
Essentially we're getting everything we would from an enum, without the drawbacks of actually using an enum.
and
key issue of ‘why not just use a const’ will remain for those who find them entirely redundant.

I gave the answer to their question above, but I'll duplicate it here for you. With a constant, you will get a non-working code:

export type MyEnum = typeof MyEnum[keyof typeof MyEnum];
export const MyEnum = {
    testA: 'testA',
    testB: 'testB',
    testC: 'testC',
} as const;

const a = MyEnum.testA;
const arr = [MyEnum.testB, MyEnum.testC];
arr.includes(a); // TS2345: Argument of type '"testA"' is not assignable to parameter of type '"testB" | "testC"'. 

At the same time, with enum you will get a working and more concise code:

export enum MyEnum {
    testA = 'testA',
    testB = 'testB',
    testC = 'testC',
}

const a = MyEnum.testA;
const arr = [MyEnum.testB, MyEnum.testC];
arr.includes(a);

Besides, I don't insist on generating enum by default. this can be done by some flag in the config

from orval.

PR is welcome!

from orval.

Hey, I've taken up the gauntlet and contributed my first PR to the project with an optional configuration parameter to generate native Typescript enums and the code to handle it.

from orval.

@dsthode sent you 1 review comment

from orval.

@melloware thank you for the comment, I've performed the changes requested.

from orval.