Comments (7)
@soartec-lab assigned this to you as you fixed the original ticket.
from orval.
I'll test it as the release is out there.
To clarify the issue:
With the return type now added to the .msw.ts
file, the type check is more strict.
As an example, if the Schema of Dog
has an literal or enum as a return value, orval uses the following code:
faker.helpers.arrayElement([
faker.helpers.arrayElement(Object.values(DogType)), // DogType is not imported
undefined,
])
This is great.
But if you want to override this value with the override function we can not type the enum. As an example in the config we currently have.
override: {
operations: {
api_countries_get_collection: {
mock: {
data: () => {
const countries = ["GB"] // We limit the Enum list here due to testing security
return countries
}
},
},
},
}
The expected return type is a list of enum.
In the previous version this would result in no errors. With the strict return type the countries
const now types to a string.
And we have no way to update this to a typed value as the config uses common js.
Hope this clarifies the issue.
from orval.
Similar to #1201
from orval.
@dipsaus9
Thank you for made this report.
I would like to understand this problem correctly, so could you please tell me the error message that is output?
from orval.
I have fixed the issue where it did not work correctly by #1205 when enum types were included.
from orval.
Hi, @dipsaus9
Since we released "v6.25.0" this issue has been fixed 👍
from orval.
@soartec-lab Release v6.25.0 did not fix our issue.
I opened a PR that can be a fix #1229
from orval.
Related Issues (20)
- NonReadonly type incorrectly includes readonly fields HOT 4
- Prettier: true fails for zod when not generating a schema
- Unstable return reference of generated hook when using a custom mutator hook.
- Zod: unstable/breaking variable names for validation lengths HOT 7
- Type Issue: RegEx is not accepted in `defineConfig.[name].input.filters.tags` HOT 1
- Feature request: support different enum key
- Question: Limitations of client instance customisation
- Add support to nested `useInfiniteQueryParam`
- Non-reactive query params in Vue when using useInfiniteQueryParam HOT 2
- Zod: only generates 200 response bodies HOT 7
- Types in generated react-query schema have unstable order, causing noisy diffs HOT 1
- [Feature] Add ability to pass custom types for a string given a format hint
- Strange enum generation while using anyOf in schema HOT 2
- support `fetch` client
- MSW: overrideResponse should allow async functions
- Non-requred requestBody results in TS error
- Faker types are incompatible with contract definition for number enums
- [Feature]Enable `faker.helpers.fromRegExp()` to be applied to msw mock from pattern keyword
- support faker for API schemas HOT 5
- Zod: type string format date should be "YYYY-MM-DD" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orval.