Pass an additional option object in fetcher function when using custom axios instance about orval HOT 4 OPEN

This issue is similar to #379, but while that one was just a matter of lacking documentation, this one is a real bug.

from orval.

The problem seems to be that the library assumes that if the mutator is overridden, it doesn't use Axios, therefore it doesn't add the arguments or the imports:

Here:

And here (my use case uses split-tags, so that's how I got here):

Maybe in more places too. One possible solution would be to add a isAxios option to the override.mutator attribute:

module.exports = {
  test: {
    output: {
      ....
      client: 'swr',
      override: {
        mutator: {
          path: './custom-instance.ts',
          name: 'customInstance',
          isAxios: true // 👈 This is a fix, not sure if it's acceptable
       },
       ...
      },
    },
  }
}

Then we could (pseudo code):

const swrMutationFetcherOptions = 
   (!mutator || (mutator && override?.mutator?.isAxios)) && isRequestOptions ? 'options?: AxiosRequestConfig' : ''; 

  hasGlobalMutator: !!output.override.mutator && !output.override.mutator.isAxios, 

from orval.

I’ve encountered the same issue, and for now, I’ve downgraded to version 6.23.0.

from orval.

Thank you for made this report.
I understood that when using a custom instance of Axios, the settings of Axios cannot be passed to the custom instance via hooks.
I think a good solution is to specify a custom instance using Axios via the orvrride property and i prefer to use isAxios: true over clinet: 'axios' because the custom instance may have additional clients in the future.
You can submit a PR and I'll submit in turn.

from orval.