I think it as an issue, when we play a song and as soon as I press the back button it stops. I feel it should still play in background as a service or something.
Should i work on this ?

After clicking on the "amahi anywhere" link in Overview.html, it shows only the half part of the web page (vertically) instead of complete web page.

Working on it currently. Any suggestions?

Error:Cause: invalid stream header: 2332EB25
Unable to build android app.

As the API information due to security reasons kept private but new contributors don't know how to get them that's why they have been asking at different places. Same happened with me as well
I have added basic info on the same in the updated readme without exposing any API related actual information.

There is no retry button present in this side navigation bar. If the fetching of hda list from the server fails for some reason, there is only one option that is to close the app and reopen again.

This happens a lot with me and it is irritating. So I would like to implement this feature. Suggest if a Button should be added or SwipeRefreshLayout.

I am working on this...

Fixed by PR #57

ContentDescription for the buttons is for the Accessibility Features of Android. The contentDescription is what get's read back to the (assumingly blind or hard-of-sight user) so they have an idea of what the picture is since they aren't able to view it.
Can i send a PR for this ?

As discussed with @cpg in #36. The search results will be fetched from the API and will be displayed in the Files Fragment.
I will be working on this issue

I want to implement a feature which changes the song on swiping the AudioActivity just like done in Google Play Music. Can i work on it ?

Working on this right now!!

this is a feature requested by users: make each folder remember the last sorting option used when the user was there.

from out bug tracker bug 1544

After complete zoom of a picture, when we swipe left to see till the right most part of the image, it just changes the picture instead of showing the right part of the picture which I think should not happen.

App is crashing on changing the Orientation in Login Screen.

Screenshots :

@cpg this is needed to be fix as soon as possible.
shall i send a PR for this?

this task is to enable the app to become fully localization available, including directions for translators on easily providing a new locale.

i can translate to spanish. some related strings that may be useful here are available in the platform locale strings.

I'm facing an error on the login page

HTTP FAILED: java.net.ConnectException: Failed to connect to api.amahi.org/208.115.201.202:443 after updating my fork

When we open the app in signed out state. The first activity that is appearing on screen is Navigation activity. Then after checking authentication through service, app gets redirected to AuthenticationActivity for asking user credentials. This is the current app flow.

The point is that logically if the app is in signed out state, Authentication activity should be the first activity to appear in front of user, not the Navigation activity.

I want to fix this app flow. But need some discussion.

I think adding reactive extensions in the app will make the code more concise. For example the task of disabling the sign in button until the user types the both name and password can be done using rx. This is just one simple example.It can be implemented in many tasks. I would like to work on this :)
@cpg any views on this idea ?

The search feature implemented in #36 by @octacode is a great addition but unfortunately it has some bugs.

• To reproduce the bug first type something in the search bar and then with the search query typed in, click on a directory to open its content. Now if you type anything more in the search bar, the app crashes.

• Also instead of adding 5 images for different sizes, a single vector drawable can be added.

I would like to send a pr for resolving this bug.

While testing the app, I have found a bug in the api. It returns 0 file size for folders/directories inside a share even when they contain files inside them. I am not sure if it is a bug or it was meant that way.

For the time being the activities don't support AppCompatActivity.

Benefits of using AppCompatActivity

It not only provide backwards compatibility to our app but also provides us the access to the Material Design Library too. After this we can easily add FloatingActionButtons, Snackbars, AlertDialogBoxes and other material design widgets easily which now we can't.

I'd be working on it.

@megabitdragon created a new vlc2 branch in this tree that tries to use libvlc 2.1.1.

He only added the library dependency without any other changes to the code. The application will not build as is in that branch.

The task in this issue is to update the code as necessary to account for the new libvlc SDK and make it 1) compile properly and 2) run properly.

You can check this commit to get started by looking at what the VLC team did with their sample embedded player to get it adapted to the new version of the library. Presumably, our code may have to change in similar ways to adapt to the library.

Side note: no policy changes as to when invoke this player should be done. That is left for #17.

This is self explanatory. Replace the actionbar with a toolbar using the support library.

Summary:
There should be a button to view typed in password just like in all popular apps.

Screenshot:

as @cpg mentioned there is a problem in some phones where the keyboard covers up the textfields , So what @cpg suggested was to move the logo down below like:

What would you all suggest?

I have the code up and running. Where can I find URL, ID and SECRET to be updated in api.properties? I have registered on Amahi website.

url.amahi = URL
url.proxy = URL
client.id = ID
client.secret = SECRET
what is the value for URL SECRET and ID
I'm facing issues in Retrofit

On selecting Version option from settings of the app, currently it is opening default browser and opening the web page. "Good practice" is to show the web page in the app only using web view, instead of redirecting it outside the app.

Currently we have png drawables for everything like back button, menu and other icons. Replacing png drawables with their vector counterpart which will be a one XML file for five drawables will definitely going to reduce APK size. Vector drawables also scale very well. PNG is a compressed image trying to make it bigger or smaller will make image doesn't look right.

As of now Tell a Friend Option looks a bit dull as in Screenshot

But it can be improvised according to the latest guidelines, Moreover, you can share it with recent people on Messenger and WhatsApp.

A cache of size approx 10 MB has been set to the default singleton OkHttpClient. So as a http content is request, for the first time it fetches it from the server but from next time onwards it does not send an actual request and rather load the previous response from the cache itself.
This results in data not getting updated even on refreshing the content in the app.

So according to me this http cache can be removed.

Right now we don't have any screen transitions between intents. I think it will be good to add a nice slide_in and slide_out transition effect during intent transitions. I would like to work on this issue.

RecyclerView is much better than ListView and GridView performance wise and this is the reason why google prefers RV over list and grid view. For List view I will use R.V with LinearLayoutManager and for grid view We have to use GridLayoutManager.
I WOULD LIKE TO WORK ON IT

When inside a directory Home up button directly takes the user to the list of shares instead of taking it in the upper folder.
For Example :- if we are in Demo/music and if home Up is pressed. We'll be redirected to the Shares fragment instead of Demo.
I am sending a PR for this.
Thanks

ideas?

$ ./gradlew assembleRelease

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'pluto'.
> Could not resolve all dependencies for configuration ':classpath'.
   > Could not resolve com.android.tools.build:gradle:0.12.+.
     Required by:
         :pluto:unspecified
      > org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V
      > org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V
   > Could not resolve com.crashlytics.tools.gradle:crashlytics-gradle:1.+.
     Required by:
         :pluto:unspecified
      > org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V
      > org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V
   > Could not resolve com.jakewharton.sdkmanager:gradle-plugin:0.12.+.
     Required by:
         :pluto:unspecified
      > org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V
      > org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 9.941 secs

I want to update landscape layout for login screen.
The new layout that I am proposing is more optimized design and deals with balanced use of space.

Login Landscape layout (Present design)

Updated Login Landscape layout (Want to do)

For the time being there's a sort feature in the ServerFilesFragment which obviously is awesome. I was thinking of adding search feature also. I will use a menu option which will be always shown clicking on which will actually open up the soft keyboard and text will be entered into the action bar. The actionbar edit text will have a textWatcher which will change the results according to per key click.
if there's any other implementation you all would like to suggest then please do.
I AM GOING TO WORK ON THIS ISSUE

Fixed by PR #73

As of now in App we are using many libraries of Support Library, so we can create a variable in Build.gradle to remove redundancy.

After that we don't need to change Support Library Version Number for every Library(or Dependency)
, We just need to change value of that variable.

could not build the project. it says
"Error:Failed to open zip file.
Gradle's dependency cache may be corrupt (this sometimes occurs after a network connection timeout.)
Re-download dependencies and sync project (requires network)
Re-download dependencies and sync project (requires network)"

any help?

After clicking on sign out button in settings page, app gets redirected to login page. But then if user presses back button it reopens main activity, whereas as per expected behavior after login page appearance. Back button should close the app.

As commented here the app crashes on opening Apps tab.
Should I send a new pr for correcting this or the old pr #34 (which made this change) should be reverted back and the commits to be edited? @cpg

android.support.v4.app.ActionBarDrawerToggle has been deprecated more than a year back and new android guidelines suggest us to use android.support.v4.app.ActionBarDrawerToggle. Above class and its few methods are still in use.

Api.properties Error
url.amahi = URL
url.proxy = URL
client.id = ID
client.secret = SECRET

@megabitdragon @cpg where to get these keys from?

We have discussed this before, and as we move forward, we will want to handle libvlc as smoothly as possible.

From my point of view (not being an Android expert), I see two main issues:

1. compilation process for this app to bundle it in. we talked about using gradle to get it in. I am not sure if this is settled or not, though I see people compiling apks that crash with [1] when trying to stream video. I think we had a branch for this, but I don't know the status of it. Perhaps someone can review? This task has been separated for #33.
2. the policy of when to invoke libvlc at run time. i don't know the current policy shipped, but the policy in iOS (which worked well), was: whitelist a default set of media types that will stream well in the main built-in video player in the platform (which means it will get Chromecast support, etc.), and for the rest of media types, fall back to vlc

[1] Can't load vlcjni library: java.lang.UnsatisfiedLinkError: dlopen failed: /data/app/org.amahi.anywhere-2/lib/arm/libvlcjni.so: has text relocations

I want to work on this issue.
If someone else is already completed his work on this issue please do notify me, I will work on something else.

I would like to add some more features to the video player.

• Subtitles View along with dialog fragment to select the subtitles file
• Screen Gestures:
  • swipe up/down on left to increase/decrease screen brightness
  • swipe up/down on right to increase/decrease volume
  • swipe left/right to seek the video
• Showing the progress bar while buffering the video from remote

Suggest if any more features are required and can be added?

update app to work well in android 7

bug 2127

According to me the following features are missing in the Image Viewer of app:

• Zoom in / Zoom out feature
• Image Full Screen View (toggling fullscreen view onClick), just like in Video Viewer

Suggest if any more features can be added! Also I would like to work on this.