Comments (7)
IMHO opinion SwipeRefreshLayout would better, in terms of UI/UX as well as latest guides.
from android.
In my view, a button (or some link) takes space. A PDTR action is generally as intuitive and it takes no space. Merged.
from android.
I would recommend making try again text as a clickable link. On clicking of which will refresh the screen.
from android.
@sukhbir-singh But the thing is that this "Connection Error" not only appears in the navigation drawer but also when we click on the Shares menu in navigation drawer and it doesn't open. So, I think, we can't add try again button eveywhere we get "Connection Error". So, I'll go with the idea of @vjs3 .
from android.
Yes, I agree with you @hshrimali. SwipeRefreshLayout must be implemented in main screen.
But also In case navigation itself donot load then also user would need an option to load.
from android.
Ya.. having a SwipeRefreshLayout in the NavigationDrawer itself is quite cumbersome. I too would recommend having a button.
from android.
I tried both ways and the swipeRefreshLayout looks more efficient and cooler than a button to me. I have implemented the same in #68.
Thanks for your suggestions! :)
from android.
Related Issues (20)
- Introduction to github actions
- Alphabetical ordering to languages in settings
- Text Capitalization problem HOT 5
- Improve Instructions in Languages.md for adding new Languages
- Inform User to Select a Server Before Selecting a Share in Settings
- Adding More Information in the File Info Dialog
- Adding Press Back Button Again To Exit App Functionality
- Adding Default System Language Option in Settings
- Scrollbar in Settings Activity Not Themed
- System Following Dark and Light Mode
- Prevent Memory Leaks
- File Info Not Opening for Recent Files
- app is not open from navigation bar(Foreground service) HOT 1
- Refresh Icon in Recent Files Activity Not Themed
- App Crashes When Video Player is Closed HOT 6
- Adding Retry Action to Snackbar when File Upload Fails
- Thumbnails Not Showing In Shares
- German Language Not Working Bug
- Build fails due to bintray HOT 1
- How about migrating the project from java to kotlin.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android.