Hi! Thank you for great extension!
I want to use on Firefox, do you have any plans?

Overview

Noticed while reviewing PRs with GitHub actions related notifications, that those particular files break or hinder the rendering flow. More investigation required.

These sections should be added to the explorer as well, or could potentially be layered as a second explorer. The goal here being that they still need visibility, and should be distinct from file references.

Currently the folders are lighter in colour and it's not entirely clear the a file is part of a folder.

• Implement style changes to improve colour difference and visibility between files and folders
• Add more indentation and a small indicator that a file is a part of a folder

Update packages recommended by GitHub as being affected.

Looks like the UI in the Files Changed section has been updated and the UI no longer renders. Will need to track down and add some additional changes. As an aside should try using Puppeteer to pull the UI and determine if the structure has changed in a way that would break things.

Because the matching rules are probably only run on page load, navigating to the files changed once in a PR doesn't load properly.

The splash page could use some styling updates and general improvements on other browsers.

Hi,

I'm very interested in using this lightweight file explorer, but the required permissions put me off a bit:

    "permissions": [
        "tabs",
        "http://*.google.com/"
    ],

When I install it from the Chrome WebStore it tells me it needs permissions for github.com (which is clear), but also for *.google.com and my browsing history. Why?

(Octotree on the other hand only requires permission for github.com.)

Allowing the explorer column to be resizable by the user will cover any cases where a pull request is becoming hard to read with smaller-width displays

Thoughts on this @alexmdodge ?

(Added for tracking on the issue)

• Make explorer resizeable
• Add buttons to quickly collapse and expand the width of the explorer

Need to create a quick splash page with some info on it, as well as a privacy policy. This can also be wired up to Jenkins to deploy when the version is updated.

When the width of the tree pane is shorter than the actual tree content, a user should be able to scroll the tree horizontally, but it seems like there's neither a horizontal scroll bar nor scrollability, at least in Firefox version of this addon. It'd be nice to have a horizontal scroll bar until #72 is resolved.

Setup build paths and proper output, as well as scaffold Google chrome extension requirements.

Need to implement some base Jest tests as well as continuous integration testing on the PR merges.

It appears the width is no longer 100%, potentially due to a structure change or similar on GitHub's side:

Clicking a branch in the tree should expand all of the sub branches, and clicking a file should reveal that change

In general there are some useful UI updates to additionally aid developers while reviewing pull requests:

• Add a simple checkbox in the file header which can be clicked to indicate review of that file is complete No longer required since the viewed feature was added
• Note when the viewed box has been selected and cross out a menu item accordingly
• Add accompanying state within the file explorer to display review files
• Add ability to distinguish whether a file was deleted or not to help in reviews
• Add comment icons which update the count dynamically through pull request reviews

Build a small script which modifies the version within the manifest as well as the package json.

Overview

Currently the demo pages are more complex than they need to be. For ease of path related issues, and to prevent additional dependency related issues, move everything into simple html files.

[ Migrated to #26 ]

Clean up the styling and animations to better display file changes

Overview

Across Firefox and Chrome, dark mode is now a feature supported by GitHub. In is current state the extension works, but key visual elements aren't working correctly.

This task is to do the following:

• Invert and provide binary colour switching for icon elements and font colours
• Invert the main GDE icon in the header

To do this, it appears across both Chrome and Firefox, GitHub exposes the same data elements for tracking:

document.getElementsByTagName('html')[0].dataset
// DOMStringMap(3)​
// colorMode: "dark"​
// darkTheme: "dark"​
// lightTheme: "light"

The polling is working to determine when a specific page is loaded, but leaves a bit to be desired when responding to DOM change while loading content. Some ideas around improving this,

• Use mutation observers where appropriate to detect DOM changes and respond
• Load the explorer container first, while keeping the other file explorer views loading. This allows for better user experience and loading indication

Currently the extension popup could use a facelift. Some improvements could be,

• Adding a clearly defined header using the logo
• Add a small controls section which could be the start of adding more configuration at a later date. For now it could be a simple on/off toggle
• Style the acknowledgements better

When referencing lines from a file diff, and then opening that link, it simply opens the file explorer to the default file.

Probably need to check the URL for a commit line hash and ensure that file opens.

Need to update to Webpack v4 and also support better bundling and file minification.

For PRs with particularly large diffs, adding a loading animation would be useful to indicate something is happening, as it can take a while to process the diffs. At the same time should look into optimizing the seek and seeing if performance can be improved.

• Add loading animation with logo included
• Investigate performance improvements involving caching
• Migrate away from timeouts and attempt another method of detecting load completion

Navigating back and forth between PR tabs breaks the active file selection logic.

For PRs that have many many changes the page may load triggering the script but all of the diffs may not be visible. This either results in some files missing from the explorer or the explorer not loading.

Need to build a simple dev page with mock content to more easily simulate DOM traversal and switching between contexts.

• Build a dev page that simple loads the extensions JavaScript similar to how the extension would
• Add more extensive unit tests that check the higher levels function for DOM composition which can be then tested for completely during the continuous integration steps

The Plugin currently only works with github.com but it would be nice if it also worked with a custom GitHub enterprise instance.

A dependency was flagged. The library should be identified and either substituted or removed. If it's a build related process it can be left as it does not represent client facing code.

In a Java project repository (or some complex project with deep directory structure), I see a tree like this:

It'd be nice if this extension detects such cases and compress the tree like this:

+- moduleA/src/main/java/com/....
   +- FooBar.java
+- moduleB/src
   +- main/java/...
      +- AliceBob.java
   +- test/java/...
      +- CharlieDelta.java

.. so that the left side of the pane is not wasted.

It can be better.

Overview

Still need to investigate but it appears that for large PRs, GitHub has changed the structure of the loading elements. Now the explorer renders immediately instead of waiting for the loading to complete.

Fix

Most likely will need to check new elements and update the load / render operation.

New to this extension but really love it. It brings at least one of the features I prefer about Azure DevOps PRs to GitHub. It would be nice, however, if you also supported GitHub's filter filter, which also allows you to filter files based on what you own via .github/CODEOWNERS.

When I filter to files (via extension or CODEOWNERS) it would be great if you filtered the file explorer view as well. For smaller PRs, the existing behavior is not so bad. I can still see the files. But on larger PRs it would help reduce potential noise (say, filtering out machine-generated files) and let me focus on the files that need to be reviewed.

Thanks for considering.

Overview

Upgrade the codebase to the newest version of TypeScript.

Overview

Initial issues during review for enabling the extension in Firefox related to having Chrome specific terminology in the descriptions of the extension / add-on. Should add a specific section in each of the manifests for each browser.

When navigating back to a file change diff with the explorer the active state is no longer existent but the DOM is still in place. Need logic to rebuild the state based on the local state persisted through storage or DOM structure.

When toggling between the split and unified view the explorer disappears. This is good, but the explorer should be expandable so it can be hidden when a split view is preferred.