Comments (4)
Definitely would be possible. I'd have to get my hands on the trial subscription to see what the DOM structure looks like. If they maintain parity between their UI then it would just be the work required to allow people to authorize their particular domain. When I get some time I'll look into what it would be like to get it working.
from github-diff-explorer.
@tomquist A little bit delayed but I've been making some upgrades lately and have had some thoughts around the best way to accomplish this.
There are generally a complications around adding broad permissions, and to support enterprise, they would have to be extremely broad to account for all potential hosting options. Instead I'm wondering if adding a generate approach where you can more easily build the extension locally and provide the custom URL of your enterprise instance would work better.
For instance I could provide something like the following:
npx github-diff-exporer generate --enterprise --host=custom.github.com
Assuming that all internal paths remain the same for any hosted instance, then that could be loaded locally and should work out of the box.
from github-diff-explorer.
@alexmdodge Would definitely be a solution, however not that convenient. The "Better Pull Requests for GitHub" extension works for GitHub enterprise too. I'm not an expert in chrome extensions but I think you could declare optional_permissions
like they do and provide a button to request permission for accessing the page.
from github-diff-explorer.
@tomquist Thanks for the links, I'll check those out.
from github-diff-explorer.
Related Issues (20)
- Task: Update Extension Popup
- Task: Add Comment Notifications
- Task: Corresponding Download Page and Privacy Policy
- Task: Refactor Polling to use Mutation Observers
- Task: Add Mobile Support for Splash Page
- Why does this extension need permission for *.google.com and my browsing history? HOT 2
- Task: Update Severe Packages from Audit
- Bug: Fix Broken Structure HOT 2
- Bug: Width is no Longer 100%
- Enhancement: support the file filter on GitHub's PR page HOT 1
- Task: Simplify demo application to base html
- Bug: GitHub actions files break explorer rendering
- Enhancement: Support Firefox HOT 5
- Enhancement: Update codebase to TypeScript HOT 1
- Docs: Update description to be browser agnostic
- Enhancement: Support Dark Mode Rendering
- Task: Ability to compact nested directories HOT 1
- Task: Add horizontal scroll bar automatically HOT 3
- Bug: For Large PRs GitHub Loading Structure has Changed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-diff-explorer.