alcueca / erc7399-wrappers Goto Github PK

https://etherscan.io/address/0x0c86c636ed5593705b5675d370c831972C787841#code

Confirm that this deletes the storage variable

It does. You could also do delete _callbackResult which is more readable and should save 150 runtime gas. Additionally, if you wanted to save more gas you could have a non-zero value represent empty similar to how 1 and 2 are used in the re-entrancy guard instead of 1 and 0.

HEre's a diagram i made while researching the basic lending workflow

sequenceDiagram
    Borrower->>Wrapper: flash(to,token,amt,data,callBack)
    Wrapper->>Lender: flashLoan(this,asset,amount,data)
    Lender-->>Wrapper: transfer loan amount
    Lender->>Wrapper: lender specific callback()
    Wrapper -->>Wrapper: bridgeToCallback()
    Wrapper-->>Borrower: transfer loan amount
    Wrapper->>Borrower: callback()
    Borrower -> Borrower: Borrower does stuff
    Borrower -->> Wrapper: transfer loan amount + fee
    Borrower ->> Wrapper: callback return
    Wrapper --> Wrapper: approves token repayment to lender
    Wrapper -->> Lender: lender calls transferFrom(wrapper, amount + fee)

It seem that the env.example file is a bit outdated since when running forge test I encountered the following:

Resolved only by setting this specific environment variable in my .env file. Am I missing something?

This does not appear to present any security risk currently.

For the Withdraw and Deposit actions created in the Dolomite wrapper, the otherAddress member of the ActionArgs struct is set and passed as an argument to Dolomite.operate().

However, according to the documentation, this field is not used for Withdraw and Deposit and therefore may be removed.

Also note, in this same contract this otherAddress field is correctly being used for Call along with the data field.