Unused argument incorrectly passed in Dolomite wrapper about erc7399-wrappers HOT 3 CLOSED

The link to the documentation is wrong, but I assume that it intended to point here. In there, it specifies that otherAddress is unused, and same for primaryMarketId.

However, here the Withdraw action takes a to parameter. I assume that the first linked documentation is wrong, and the otherAddress parameter in Action is actually used as to in Withdraw. Otherwise that feature would be not implemented, which would be weird.

Furthermore, our tests use a separate contract to receive the flash loans, which the MockBorrower pulls funds from. Given that we are giving the loanReceiver address to Dolomite in the otherAddress variable, and the funds are actually appearing in the loanReceiver (shown below) it follows that the implementation is right, and the documentation wrong.

On primaryMarketId being also described as "unused" in the same documentation, Dolomite uses a single contract as entry point for all operations and the only way that we can tell Dolomite which token we are taking a flash loan of is with primaryMarketId as seen here. As a test, if we don't pass a primaryMarketId to Withdraw the token transferred from Dolomite to LoanReceiver is not the asset that we wanted to borrow (probably it defaults to something).

From Dolomite to LoanReceiver:

Attempted retrieval of asset

from erc7399-wrappers.

Sorry, but where does it say primaryMarketId is unused?

First comment says it's needed for Deposit & Withdraw

from erc7399-wrappers.

Great, I'm glad this wasn't an issue after all.

I think it says not needed for otherAddress and data. Agree with ultrasecreth it says it's needed for primaryMArketId.

Anyways, closing, sorry for the fire drill!

from erc7399-wrappers.