aghost-7 / critiq.vim Goto Github PK

I like to review PRs mostly commit by commit to understand the thought process of the implementer. Sometimes I then cross-check with the final version to see if some change I would request is already made.

I can see that the list of commits in a PR can be shown. However, I am missing a way to jump to a diff for only one commit. And then a command to jump to the next/previous commit-diff.

Error detected while processing function <SNR>98_exit_handler[20]..<SNR>97_on_diff[6]..<SNR>100_on_open_pr_diff[23]..
critiq#views#pr_header#render[7]..<SNR>104_set_text:                                                                 
line   31:                                                                                                           
E684: list index out of range: 0                                                                                     
Press ENTER or type command to continue                                                                              
Error detected while processing function <SNR>98_exit_handler[20]..<SNR>97_on_diff[6]..<SNR>100_on_open_pr_diff[23]..
critiq#views#pr_header#render[7]..<SNR>104_set_text:                                                                 
line   31:                                                                                                           
E15: Invalid expression: 'Body: ' . body[0]                                                                          
Press ENTER or type command to continue  

I get this when running CritiqOpenPr, I'm not sure what's up, there's nothing particularly special as far as I know.

For the pr header (#7) I am pulling a list of reviews so this should be trivial to implement (and won't add more to the rate limit).

Firstly, I just discovered this plugin today after looking for something like it for a long time. Thank you for providing this!

I looked around the source but could not find this.

Is there a feature planned to view a comment chain on a line? Maybe a binding that opens a read-only split that shows the comment chain?

Should be able to see the ~ file in the pr diff using CritiqOpenFile.

• I want to see what message the person who opened the PR left for me to view.
• I also want to be able to view who is the last person to review the PR.
• merge target

Still have to make up my mind when it comes to these.

Not sure if I'm missing something but here what I did

1. :CritiqApprove
2. Leave a comment in the buffer that opens
3. :q or :bd that buffer
4. ??? nothing happens ???

I think the only thing I need is to get the job API abstracted. Ale does this, so I can reference the project again. This will require adding more tests, and running the suite against vim8.

Comment list should update when I add a comment of my own. Needs to be implemented for:

• Highlights
• Comments list

If there is more than one target repository in the list, I should be showing the repository name.

I would rather pass GH_USER as a vim variable and GH_PASS in a hidden file or ideally use the keyring.
Lots of cheers from my side, I have been dreaming about such a plugin for quite some time.

I tried to comment a line in a PR via critiq but the comment did not show up.

I opened the PR and used :CritiqCommentLine on a diff line that changed in the PR.
I wrote something and closed the scratch window with :q.
The comment did not show up in the PR. I did not got any error message.

I'm using nvim v0.3.4 + critiq 3852670

Considering I'm already using containers, circle ci makes a lot more sense.

Would be nice to be able to view the commits of a pull request. The only concern is going to be handling whether the person ran :CritiqPull or :CritiqCheckout.

really don't think this is possible to do through the tui without being clunky. I use them if I find ui bugs during my review, which currently forces me to use the github interface.

I'm not sure if this is possible, but rhubarb works by using the .netrc file in the home directory.

This means no environment variables need setting, and also means I can configure both plugins the same way.

Great plugin, is there anyway of viewing the diffs with/like vim-fugitive ?

Hi,

First, Thanks for this awesome project.

Is it possible to open github diff in the vimdiff mode? it is diffsplit somefile ?

I used git difftools and vimdiff a lot. I think the diff mode display is much better than reading github diff file.

Beside direct support for PR diff view, is it possible to pull the PR branch locally and then view it inside !git difftools for example? I know it might be or might not be harder to set CritiqCommentLine in diffsplit mode.

Thanks again for the awesome plugin.

Hi,

any plans for supporting bitbucket?

I only want to see PRs which are ready for review.

Add ability to delete the PR branch.